jean-pierre charras
ea95d8604a
Ensure we do not use a non existing pin in SIM_MODEL::MigrateSimModel()
...
From master branch
Fixes #14522
https://gitlab.com/kicad/code/kicad/issues/14522
2023-04-12 09:41:07 +02:00
Marek Roszko
35def3ab2e
Prevent VIEW::UpdateItems and onShowTimer from firing repaints if GAL did not complete init
...
This appears to be a possible event race on startup
Fixes sentry KICAD-10A
(cherry picked from commit bfad8bb0d5
)
2023-04-12 02:10:34 +00:00
Marek Roszko
5527c12a8d
Fix crash due to extra right parens in pcad files
...
Fixes sentry KICAD-TA
(cherry picked from commit 37eaa29679
)
2023-04-12 01:53:29 +00:00
Mark Roszko
fb1cc72013
Don't crash on empty pcad polygons
...
Fixes sentry KICAD-103
2023-04-12 01:41:06 +00:00
Jeff Young
1f34883a27
Make symbol/footprint trees sensitive to language change.
...
(cherry picked from commit eef3492fc0
)
2023-04-12 00:01:58 +01:00
jean-pierre charras
724262651f
manage libraries dialog: show new state of widgets as soon as the context-menu
...
activate/deactivate changes their state
From master branch
Fixes #14517
https://gitlab.com/kicad/code/kicad/issues/14517
2023-04-11 18:55:51 +02:00
Alex
d7b2247878
opengl_gal: Remove extra padding of bitmap textures.
...
Since the format has been changed to RGBA8, default (UN)PACK_ALIGNMENT = 4
works correctly, so the texture width padding to 4 is not needed anymore.
Fixes https://gitlab.com/kicad/code/kicad/issues/14432
(cherry picked from commit e91b53fc39
)
2023-04-11 04:32:42 +00:00
jean-pierre charras
372e7b6312
fix 2 issues related to SCH_GLOBALLABEL items:
...
- Ensure the first field in m_fields has id = 0 to be seen has hypertext
(it was not the case after reading a .kicad_sch file)
- when converting this item to another label/text, remove this special Field
from the copied field list to the converted label.
From master branch.
2023-04-10 10:02:50 +02:00
Jeff Young
323a2d83fa
Ease acquisition of a target item.
...
pickSingleItem() had a two-attempt algorithm, but the second attempt
was never made because we'd check for no hits before throwing out the
aAvoidItems.
The second attempt would fail anyway because QueryHoverItems() ignored
the aUseClearance flag when not idle, and didn't factor in the actual
clearance.
(cherry picked from commit d040690f60
)
2023-04-09 23:13:44 +01:00
Jeff Young
03c3393616
Handle more pad shapes when building diffpair gateways.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/1883
(cherry picked from commit 1d19672054
)
2023-04-09 23:07:38 +01:00
Jeff Young
cbff011e3c
Don't delete default intersheetrefs field from global labels.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14493
(cherry picked from commit a226f7fc14
)
2023-04-09 19:04:33 +01:00
Jeff Young
2ba6fad633
Centralize NPTH has-annulus processing.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/13437
(cherry picked from commit 3b63d70d01
)
2023-04-09 19:04:33 +01:00
Mark Roszko
bc4878d71e
Update ngspice to 40 in vcpkg
2023-04-09 02:16:09 +00:00
jean-pierre charras
e991ae504b
DIALOG_IMAGE_PROPERTIES: fix some issues:
...
- add missing panel_image_properties_base.fpb file
- fix not displayed image.
From master branch
2023-04-08 17:04:02 +02:00
Seth Hillbrand
c18181042f
Simplify test for substantial nubs
...
Substantial elements following a divot should be at least as far in each
cardinal direction from the origin point in order to be considered
substantial. This catches cases where the "substantial" element is
actually a straight segment away from the divot
Fixes https://gitlab.com/kicad/code/kicad/issues/14130
(cherry picked from commit 914b5a4d21
)
2023-04-07 16:41:11 -07:00
jean-pierre charras
3de80d3b20
Plot gerber: fix a too zealous plot of negative objects on the silkscreen layers,
...
when merging layers to silkscreen layers.
From master branch
2023-04-07 11:34:42 +02:00
Seth Hillbrand
39dcd0a352
Handle nested netclass assignments
...
Netclass directives should not be overriden, instead hold our error
checking for actually missing nets
Fixes https://gitlab.com/kicad/code/kicad/issues/14494
(cherry picked from commit 012737593b
)
2023-04-06 17:38:42 -07:00
Jeff Young
199e31ea3f
Eagle template footprints don't actually belong to board.
...
Set their parent to nullptr before deleting (as the board may have
already been deleted).
Likely fix for Sentry KICAD-79.
(cherry picked from commit 13e79af8a0
)
2023-04-04 14:21:19 +01:00
Jeff Young
dce2247925
Improve scoping control of connetion members.
...
(The real bug here is that CONNECTION_GRAPH::assignNetCodesToBus() was
growing the bus aliases members list because it used a non-const
reference to it as a local storage list. The const scoping of it will
prevent this type of error in future.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14269
2023-04-04 11:35:06 +01:00
Jeff Young
89e78c0276
Fix Mac crash-on-quit when timed infobar is up.
...
(cherry picked from commit b3e2cf218f
)
2023-04-03 23:47:14 +01:00
Jeff Young
9a57c11348
Possible protection from acessing deleted window data.
...
(Long shot for Sentry KICAD-MM.)
(cherry picked from commit bd60f38569
)
2023-04-03 23:47:09 +01:00
Jeff Young
1dbe8b2a79
Nullptr safety.
...
(This is a long shot for Sentry KICAD-MV, but you never know....)
(cherry picked from commit a4e8fa96d4
)
2023-04-03 23:47:00 +01:00
Seth Hillbrand
29fd0caf58
Update translator contributions
...
Adds a number of missing contributors to our translations
(cherry picked from commit d135295ac8
)
2023-04-03 13:07:33 -07:00
jean-pierre charras
d30701ed59
Fix compil warnings.
...
(cherry picked from commit ac71227e75
)
2023-04-03 10:14:14 -07:00
Seth Hillbrand
e39550e77f
Update to Clipper 1.2+
...
Updates to Clipper2 742614f, which includes bug fixes for specific KiCad
boards beyond Clipper2 itself
Fixes https://gitlab.com/kicad/code/kicad/issues/14294
(cherry picked from commit 97558b62ec
)
Fixes https://gitlab.com/kicad/code/kicad/issues/14475
2023-04-03 10:06:34 -07:00
Jeff Young
a21e7a5eee
Don't pass a FRAME-based UNITS_PROVIDER to a modeless dialog.
...
(The dialog may outlive said frame.)
Should fix Sentry KICAD-3A.
(cherry picked from commit 9b4627e782
)
2023-04-03 17:20:06 +01:00
Jeff Young
927b5ae707
Use enums for column ids.
...
(The nickname, in particular, is no longer column 1.)
Fixes https://gitlab.com/kicad/code/kicad/issues/14291
2023-04-02 15:28:11 +01:00
jean-pierre charras
f59626004c
PCB_TEXT::TransformTextToPolySet(): fix missing code for knockout texts.
...
From master branch
Fixes #14473
https://gitlab.com/kicad/code/kicad/issues/14473
2023-04-02 10:29:18 +02:00
Jeff Young
2ece2719d0
Naming conventions and nullptr usage. No functional changes.
2023-04-01 15:14:35 +01:00
Jeff Young
78ee542d8d
Naming conventions.
2023-04-01 14:11:56 +01:00
Jeff Young
cea9b38815
Update local coords after changing footprint item properties.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14348
(cherry picked from commit 0f9a4ef7b7
)
2023-04-01 13:57:47 +01:00
Jeff Young
cb8f6db68d
Add hole clearance to moutning hole keepouts for SPECCTRA.
...
Fixes https://gitlab.com/kicad/code/kicad/issues/14439
2023-04-01 13:57:47 +01:00
Seth Hillbrand
85038c2b46
Prevent PCB Editor from opening multiple board_setup
...
ShowBoardSetup can be called multiple times from multiple locations,
resulting in duplicate board setup dialog boxes. This is confusing and
should be prevented. We use the established patter from the symbol
picker to ensure that only one copy of the dialog is ever opened at a
time
(cherry picked from commit 7695d510d6
)
2023-03-30 15:34:42 -07:00
Roberto Fernandez Bautista
1e8055f504
CADSTAR PCB Importer: Ignore construction layers on outer surfaces
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14443
7.0 version of d5bc223ff2
(no strings)
2023-03-31 00:17:06 +02:00
jean-pierre charras
a7a5f20d1c
Pcbnew: fix incorrect position of cached text shapes when moving a footprint.
...
when moving a footprint, the position of texts living in FP_TEXT_BOX was
not updated when the text shape was cached (non Kicad fonts).
From master branch.
Fixes #14452
https://gitlab.com/kicad/code/kicad/issues/14452
2023-03-30 17:33:44 +02:00
jean-pierre charras
0d744a4e74
kicad-cli, layer names: allows using both names used in GUI and in board files
...
From master branch
Fixes #14455
https://gitlab.com/kicad/code/kicad/issues/14455
2023-03-30 13:50:09 +02:00
jean-pierre charras
216ec60dc1
kicad-cli, export drill files: fix duplicate options and fix some others:
...
- remove --separate-files duplicate option
- change --units to --excellon-units (valid only for Excellon) and default to mm
- Gerber resolution: 5 -> 6 (default must be always the higher resolution)
From Master
Fixes #14454
https://gitlab.com/kicad/code/kicad/issues/14454
2023-03-30 10:35:46 +02:00
Roberto Fernandez Bautista
3d9047bec4
Revert "CADSTAR PCB importer: Fix incorrect position of overridden pads"
...
This reverts commit 5cab66fb18
2023-03-29 21:53:14 +00:00
Roberto Fernandez Bautista
08d65beb26
CADSTAR PCB importer: Fix loading of rounded rectangle pads
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14445
(cherry picked from commit aaeb8ca739
)
2023-03-29 20:56:14 +00:00
Roberto Fernandez Bautista
5cab66fb18
CADSTAR PCB importer: Fix incorrect position of overridden pads
...
(cherry picked from commit 89441d807d
)
2023-03-29 20:55:50 +00:00
jean-pierre charras
9466624f9d
Footprint editor: always export the currently loaded footprint.
...
Previously, it was not always the edited footprint, but a footprint
selected from the library tree.
It was especially annoying when the footprint was loaded from the board editor:
The footprint was not the loaded footprint, but its copy from library.
From master branch
2023-03-29 20:30:25 +02:00
jean-pierre charras
80b842a704
Footprint viewer: ensure the footprint is updated after new library selection
...
Previously, if the first fp of the new lib has the same name as the old
displayed fp, the old fp was not replace by the new fp.
From master branch
2023-03-29 16:59:12 +02:00
Seth Hillbrand
d513a9fe5c
Locked shadow needs to be in shadow color
...
Otherwise, text shadow is stroked by text color
(cherry picked from commit f93fde15b7
)
2023-03-28 13:02:18 -07:00
jean-pierre charras
c98081cb04
QA test: disable Silk clearance test in solder mask bridge QA test.
...
the Silk clearance test has nothing to do with a solder mask bridge QA test
From master branch
2023-03-27 12:50:14 +02:00
Jon Evans
17a1dc18be
Properties: Hide Net Class from GUI
...
It is confusing users who want to change the netclass of a net.
(cherry picked from commit 3f42e6b702
)
2023-03-26 19:50:10 -04:00
Jon Evans
b22ff229db
DbLib: Get rid of some GCC warnings
...
(cherry picked from commit c35cefe1d5
)
2023-03-26 19:48:58 -04:00
Jon Evans
23b03fd6ab
Properties: Rename methods to better reflect their purposes
...
(cherry picked from commit 65193487a6
)
2023-03-26 19:48:46 -04:00
Jeff Young
97b273905a
Manual cherry-pick of a214ac0310
.
2023-03-26 21:06:24 +01:00
Jeff Young
e759c4d27a
Only report on clearances where there was one defined.
...
If it's 0, it's just a straight-up collision.
(cherry picked from commit 9976b9ce8c
)
2023-03-26 20:59:41 +01:00
Jeff Young
76685ae2d9
Run SILK_CLEARANCE rules on mask layer when testing silk-to-mask clearance.
...
This allows custom rules to be authored without firing the auto-generated
rule from Board Setup > Silk Item Clearance (which should be only for silk-
to-silk clearances).
Fixes https://gitlab.com/kicad/code/kicad/issues/14417
(cherry picked from commit 0266d03f79
)
2023-03-26 20:59:36 +01:00