904eb82368
Fix a DRC crash on some installs.
...
It looks like D_GLIBCXX_ASSERTIONS=ON activated on some Linux versions creates too zealous tests at run time.
This patch just calculate the same pointer value using a slightly different formula.
Fix also a hard-to-understand comment
Fixes: lp:1770414
https://bugs.launchpad.net/kicad/+bug/1770414
2018-05-16 09:20:04 +02:00
23a9fcd91d
Fixed a typo in the STEP generator message
2018-05-14 10:59:48 +02:00
2832f997c5
PcbNew; fix crash on copy/paste
...
Due to a bug introduced by commit ba1e0efdahttps://bugs.launchpad.net/kicad/+bug/1771003
2018-05-13 21:50:59 +02:00
a9dc417319
Fix bug in pruning of selection.
...
Fixes: lp:1770939
* https://bugs.launchpad.net/kicad/+bug/1770939
2018-05-13 15:23:41 +01:00
b94e0a2031
Fix forgotten change (m_Zone to m_SegZoneDeprecated)
2018-05-13 09:19:44 +02:00
e57cd291ff
class BOARD: rename m_Zone to m_SegZoneDeprecated to avoid mistakes in code.
...
m_Zone is a fully deprecated list of SEG_ZONE items (similar to TRACK), used to fill copper zones in *very old* boards.
it is even unlikely there are still boards that use them.
So it should be removed one day.
2018-05-13 08:39:36 +02:00
ba1e0efdad
Pcbnew, GAL mode: Fix incorrect management of zones in append board and copy from Paste from clipboard.
...
Fixes: lp:1770855
https://bugs.launchpad.net/kicad/+bug/1770855
2018-05-12 20:48:50 +02:00
6e5131be5a
Minor fix in fp editor and fp viewer: display the fp info instead of the useless board info.
...
board info makes sense only in board editor, not in fp editor and fp viewer.
2018-05-12 10:44:31 +02:00
dffdf04cd9
Update footprint value when it's a proxy for FPID.
...
Fixes: lp:1769207
* https://bugs.launchpad.net/kicad/+bug/1769207
2018-05-10 12:16:00 +01:00
a65088419e
More forgiving keyword search.
...
In particular, allow comma separators in footprint filters without
making users type them in when searching.
Fixes: lp:1391533
* https://bugs.launchpad.net/kicad/+bug/1391533
2018-05-10 12:16:00 +01:00
933ff189ad
Remember the last directory in FPLib Wizard.
...
Fixes: lp:1577965
* https://bugs.launchpad.net/kicad/+bug/1577965
2018-05-10 12:16:00 +01:00
e339007d22
3D viewer: fix some issues when opened from a frame and changes are made in a other frame:
...
* Refresh the view only when changes are made in the caller frame.
* Allows recreate a new instances when try to open the 3D view from a frame taht is not the initial caller
* Remove duplicate code in kicad frames.
2018-05-10 12:49:20 +02:00
d41e64b0ff
Fix dialog grid sizer padding issue on GTK builds.
2018-05-09 17:38:06 -04:00
7bd9fc9235
Fix footprint editor options dialog layout.
...
Add padding to standard dialog button sizer. On windows, the buttons are
slammed against the bottom of the dialog with no border which looks awful.
Fix alignment and padding in grid sizers.
2018-05-09 14:12:26 -04:00
7b887c4844
Fix static text iss in board editor footprint properties dialog.
...
Replace degree symbol with the word degrees. On windows, this does not
translate to the degree symbol.
2018-05-09 14:01:50 -04:00
b67bab2f98
Fix layout issues in footprint editor footprint properties dialog.
...
Add padding to standard dialog button sizer. On windows, the buttons are
slammed against the bottom of the dialog with no border which looks awful.
Replace degree symbol with the word degrees. On windows, this does not
translate to the degree symbol.
2018-05-09 13:52:04 -04:00
1f898b1e80
Fix control padding in choose footprint dialog.
2018-05-09 13:23:45 -04:00
03b85c7544
Fix control alignment and padding in footprint properties dialog.
2018-05-09 13:11:36 -04:00
b9808da0a8
Use wxStdDialogButtonSizer in dialog.
...
Use .step instead of .stp as step file extension.
2018-05-09 18:14:49 +02:00
787ee62db3
Fix inconsistent padding in Pcbnew plot dialog.
2018-05-09 11:33:26 -04:00
31b026c70f
Another attempt to fix the initial button layout on GTK.
2018-05-08 20:01:29 +01:00
e5374981aa
Improve spacing of Plot button on GTK.
2018-05-08 18:48:23 +01:00
36850a539b
Make layers manager terminology consistent.
...
Fixes: lp:1769788
* https://bugs.launchpad.net/kicad/+bug/1769788
2018-05-08 18:48:23 +01:00
a997aad144
Fix issue on re-titling sdbSizer button on GTK.
...
While "fixes" isn't quite the right word, we do want this commit
associated with the following bug, and "fixes" is the easiest
way to do that:
Fixes: lp:1712579
* https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-08 17:11:48 +01:00
dcf4d7caa7
router: allow placing via without track in shove mode
...
Fixes: lp:1769782
* https://bugs.launchpad.net/kicad/+bug/1769782
2018-05-08 15:18:10 +02:00
2b46bda2f2
PNS router: apply the last stable state after dragging
...
Previously, dragging changes were applied only if the last cursor move
finished with a successful drag operation. It made items squeezing
difficult, as it required accurate cursor movement to apply the changes.
2018-05-08 11:50:37 +02:00
471e3de5a7
Fixed board append function, broken in 046e73ec
...
The previous implementation cleared all DLISTs, but has not added
everything back on append.
2018-05-08 11:21:55 +02:00
8cb3aa79f2
pcbnew_control.cpp code formatting
2018-05-08 10:40:33 +02:00
046e73ecac
Clear the source DLIST when pasting items to a BOARD
...
Fixes the assert triggering when items already belonging to a list are
added to another one.
2018-05-08 10:40:33 +02:00
ad6956b05d
Move zone fill check for plot to a checkbox option.
...
Fixes: lp:1712579
* https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-08 00:22:45 +01:00
dbc2eea3db
Optimize itemset
...
When counting items, many cases exist where we want to count all items
without checking flags. This short-circuits the loop to provide the
immediate count.
2018-05-07 13:59:12 -07:00
4c7f5f2a2f
Allow disabling snap-to when placing vias
...
This allows the user to selectively disable the snap-to behavior when
placing stand-alone vias. Full solution will require an update to the
segment distance calculation that takes into account the rounded line
caps.
Fixes: lp:1769523
* https://bugs.launchpad.net/kicad/+bug/1769523
2018-05-07 13:58:26 -07:00
ef698384a7
Eagle PCB importer: changed m_Track.Insert() to m_Track.PushBack()
...
The latter better reflects the intention.
2018-05-07 16:51:06 +02:00
d35a6f1e6d
Gerber job file, update to the latest file specification: add a change forgotten in the first commit.
2018-05-07 08:50:17 +02:00
07e7340a96
Make sure doc gets refreshed when zone check results in refill.
2018-05-06 14:05:50 +01:00
b29550de5d
Gerber job file: minor update to the latest file specification.
2018-05-06 12:03:46 +02:00
aa7da5dfcd
Treat ${...} and $(...) envvar references uniformly.
...
Fixes: lp:1769282
* https://bugs.launchpad.net/kicad/+bug/1769282
2018-05-05 23:40:40 +01:00
a31017bc9c
Check zone fills before plotting.
...
Also adds a "Draft Plot" button for those who wish to sidestep
zone checking (which can be slow).
Fixes: lp:1712579
* https://bugs.launchpad.net/kicad/+bug/1712579
2018-05-05 23:40:40 +01:00
1f5b575eaf
Pretty-up new pad clearance UI.
2018-05-04 23:55:03 +01:00
c23b263e39
Fix display issues in Layers list in Keepout Zone Properties.
2018-05-04 23:55:03 +01:00
bfe636d327
Query user to create library on save
...
Revising 5ca6864a4
2018-05-04 09:59:35 -07:00
5ca6864a40
Improve error message granularity
...
When saving a library, check and report on libraries that do not exist
as well as those that exist but are read-only.
Fixes: lp:1769190
* https://bugs.launchpad.net/kicad/+bug/1769190
2018-05-04 09:12:08 -07:00
9648584827
Adjusting the breakout optimizer for custom pads
...
Rather than using the center of the bounding box, we keep the start
track on the custom pad's connection pad when optimizing the breakout.
2018-05-04 08:23:20 -07:00
b2c4519c2c
Setting custom pad shape to be outline for PNS
...
Changes SHAPE_CONVEX to SHAPE_SIMPLE to better reflect the limitations.
Changes SHAPE_LINE_CHAIN::PointInside calculation to allow points
strictly inside a line chain
Fixes: lp:1768862
* https://bugs.launchpad.net/kicad/+bug/1768862
2018-05-04 08:23:20 -07:00
93c7f65d96
mask clearance parameters: use clearances only for pads on copper layers, and never for pads on technical layers only.
2018-05-04 14:55:38 +02:00
684f085ac5
Coverity fixes
...
CIDs:
dereference before null check:
175439 @ drc.cpp
uninitalized field:
175435 @ point_editor.cpp
174162 @ zone_filler.cpp
163188 @ footprint_info_impl.cpp
logically dead code:
155146 @ pcb_editor_control.cpp
2018-05-04 14:06:08 +02:00
1ac905d3ee
Allow PNS to select nearest pad when two overlap
...
Usually pads do not overlap. However custom pads are represented as
their convex hull, so they may enclose other pads. This change allows the
router to select the closest pad to the cursor position.
2018-05-03 09:48:15 -07:00
296ada95a3
Remove unused private vars
2018-05-03 09:48:15 -07:00
5b44e80355
Fix incorrect gerber job file syntax, when a board has inner layers.
2018-05-03 18:27:02 +02:00
7c7a6ea979
Fix board file formatting bug.
...
The roundrect_rratio token was missing a leading space which made the
file formatting different from all other formatting when using rounded
rectangle pads.
Fixes lp:1768355
https://bugs.launchpad.net/kicad/+bug/1768355
2018-05-03 10:21:40 -04:00
a2448cf4a5
Add missing settings to ModEdit's preferences.
...
Fixes: lp:1768477
* https://bugs.launchpad.net/kicad/+bug/1768477
2018-05-03 15:07:24 +01:00
2eddf1d8db
router: prevent a very unlikely infinite loop in PNS::LINE::Walkaround() causing an OOM&segfault
...
Fixes: lp:1767587
* https://bugs.launchpad.net/kicad/+bug/1767587
2018-05-02 15:06:08 -07:00
af739f5b00
Check for duplicates when adding libraries.
...
This is particularly important when bulk adding (by director, etc.)
as otherwise the user might end up having to click OK to many
many error dialogs.
Fixes: lp:1764057
* https://bugs.launchpad.net/kicad/+bug/1764057
2018-05-02 21:49:57 +01:00
106dd60e45
Only adjust LAYER_WIDGET font size if larger than indicator.
...
Also moves adjustment into LAYER_WIDGET so all the callers don't
have to deal with it individually.
Fixes: lp:1767965
* https://bugs.launchpad.net/kicad/+bug/1767965
2018-05-02 21:49:57 +01:00
2f157f9b23
Enable magnetic pads in Modedit.
...
Also fixes a bug where a FOOTPRINT_EDIT_FRAME was being passed
in to a PCB_EDIT_FRAME.
Also tidies up Modedit settings handling for settings which can't
be edited in Modedit's preferences dialog. They're now copied
from Pcbnew.
Fixes: lp:1768477
* https://bugs.launchpad.net/kicad/+bug/1768477
2018-05-02 21:49:57 +01:00
037f7a1698
Cosmetic enhancement: Add missing icons in GAL Select submenu (context submenu).
2018-05-02 21:42:41 +02:00
6b973f42eb
Re-enabling lock/unlock context menus in legacy
...
This partially reverts 36d36de and 3bac100, moving the legacy footprint
lock/unlock code from the autorouter (which remains disabled) to
pcb_edit_frame.
2018-05-02 09:06:10 -07:00
76d3b6f04a
Adding locking to the context menu for modules
...
Locking submenu was activated only for tracks and via but it makes sense
(and is probably expected) when right-clicking on modules as well.
2018-05-02 08:35:53 -07:00
73eab29802
Removed 2 unused variables from PNS::LINE::Walkaround()
2018-05-02 17:06:13 +02:00
69a31242b9
Change status bar Unconnected to Unrouted.
...
This should help make it clear that this is not the same as the
more authoratative DRC unconnected count.
2018-05-02 10:34:33 +01:00
2836d36de8
Removing legacy autorouter menu options
...
The autorouter was removed in 3bac100 but a few items were left in
place but mostly unconnected to functions.
Fixes: lp:1768357
* https://bugs.launchpad.net/kicad/+bug/1768357
2018-05-01 16:36:43 -07:00
aec490e3ac
Handle single- and double-click in Place Footprint history list.
...
Old code failed to set the wxEventType during acceptance, and
failed to set the default button during initialization.
Fixes: lp:1768253
* https://bugs.launchpad.net/kicad/+bug/1768253
2018-05-01 23:28:01 +01:00
75e91f4cfd
Make sure Cvpcb doesn't use its own FP_LIB_TABLE.
...
It's just a vestige of when Cvpcb was a separate app.
Fixes: lp:1768251
* https://bugs.launchpad.net/kicad/+bug/1768251
2018-05-01 21:49:03 +01:00
295941c14d
Don't leave Zones with "dead" nets.
...
When reading netlist or updating board from schematic, if the
changes leave a zone with a net with no pads then change the
zone's net to the new net of one of it's connections.
Also improves update-board-from-schematic's dry run reporting
to include zone nets and single-pad nets.
Fixes: lp:1609401
* https://bugs.launchpad.net/kicad/+bug/1609401
2018-05-01 13:54:31 +01:00
6b3410974d
Fix "same layers" test when duplicating zones.
2018-05-01 13:54:31 +01:00
b2b70ed7e3
Fix minor signed/unsigned comparison
2018-04-30 11:15:29 -07:00
12487e14ab
Reduce extra loop comparison
2018-04-30 09:14:23 -07:00
5ac4dbe641
Fix window/crossed selection mode recognition in flipped view
...
Fixes: lp:1767233
2018-04-30 14:57:38 +02:00
c8a784058e
Allow duplicating a zone onto the same layer in a GAL canvas.
...
Duplicate already works, so there's little reason to disallow
using the zone dialog to do it.
The legacy canvas can't be fixed because we'll immediately
union the two zones, resulting in a no-op.
Fixes: lp:1464677
* https://bugs.launchpad.net/kicad/+bug/1464677
2018-04-29 20:28:45 +01:00
ae711d9994
Separate clearance axes when plotting pads to DXF (among other things).
2018-04-29 18:51:18 +01:00
41b92b6d0f
Don't discard footprint's library ID when saving.
...
Fixes: lp:1767736
* https://bugs.launchpad.net/kicad/+bug/1767736
2018-04-29 09:45:05 +01:00
2a87117edc
Speed load/unload of complex boards
...
Corrects an error in polyline estimation
Syncs graphics to world PNS by whole layer set rather than
individual layer at a time.
Prevents reloading of full pns TOOL_BASE during reset of tools unless
the tool is being activated.
Fixes: lp:1766626
* https://bugs.launchpad.net/kicad/+bug/1766626
2018-04-28 16:11:07 +02:00
cfd2f1d001
Missed some menu items in the earlier clean-up.
2018-04-27 15:26:00 +01:00
942d4e7658
Check footprint history list for validity.
...
Fixes: lp:1767108
* https://bugs.launchpad.net/kicad/+bug/1767108
2018-04-27 15:26:00 +01:00
ccce376e33
Refinements for commit 986b904
...
(Add comments and a minor fix)
2018-04-27 16:01:59 +02:00
986b90424b
Fix an issue in LoadPlugins(bundlepath=None) python method (Windows specific).
...
For some obscure (for me) reason, the path separators in bundlepath are seen as escape seq, and the path can be incorrectly handled
(when \n or \r are found in this string).
it happens only for this path, not for other paths in LoadPlugins.
For bundlepath parameter, unix separator is now used.
Fixes: lp:1766879
https://bugs.launchpad.net/kicad/+bug/1766879
2018-04-27 14:04:24 +02:00
641c8bb548
PCBNew: Fix crash while routing in Legacy canvas
...
it was due to a incorrect behavior of TRACK::GetBestInsertPoint( BOARD* aPcb )
Also: update comment for this method.
Fixes: lp:1767061
https://bugs.launchpad.net/kicad/+bug/1767061
2018-04-26 19:42:55 +02:00
7a923ab969
vrml export: fix line min width to 0.05mm (instead of 0.12mm)
2018-04-26 19:42:54 +02:00
5342aacf97
Implement magnetic pads & tracks for measurement tool.
...
This really needs to get put into the VIEW_CONTROLS for all the
tools, but that's probably a bit too risky for 5.0 at this
point.
Fixes: lp:1766547
* https://bugs.launchpad.net/kicad/+bug/1766547
2018-04-25 23:36:17 +01:00
7a7da560bc
Keep unknown nets at 0 while routing.
...
Previous algorithm used a static variable which it decremented
for each new unconnected track, but this resulted in the router
marking earlier fixed segments as collisions (because they
would get set to netcode = 0 when "fixed").
Fixes: lp:1762043
* https://bugs.launchpad.net/kicad/+bug/1762043
2018-04-25 10:54:32 +01:00
8d017c9261
Re-enabling global spread and place
...
This had been removed along with autorouter but its functionality is
still desired. If/when the autorouter is resurrected, these IDs will
need to be deconflicted.
Fixes: lp:1766550
* https://bugs.launchpad.net/kicad/+bug/1766550
2018-04-24 11:44:08 -07:00
d0ffff3b88
Prevent deletion while actively routing
...
Fixes: lp:1766280
* https://bugs.launchpad.net/kicad/+bug/1766280
2018-04-24 10:44:49 -07:00
345f7d0732
Fix VRML export bugs
...
Corrected polygon export missing vertex.
Set pads to export on copper layer when not masked, keeping visual
output similar to physical.
Fixes: lp:1766634
* https://bugs.launchpad.net/kicad/+bug/1766634
2018-04-24 09:20:40 -07:00
bfc70c8208
Fix an issue in footprint editor, "Create Pad from Selected Shapes" command.
...
If the initial pad was a custom pad converted in a usual pad + graphic items by the command:
"Explode Pad to Graphic Shapes"
the "old" primitives were not cleaned, and the new created pad contained these old primitives, regardless the new selected shapes.
(Usual case when a user want to edit a custom shape)
2018-04-24 17:00:29 +02:00
143d580596
Fixed relative coordinates reset when a tool forces the cursor position
...
Fixes: lp:1759044
* https://bugs.launchpad.net/kicad/+bug/1759044
2018-04-24 12:56:19 +02:00
482fd866b3
Correct minor error in SPECTRA rounded-rect
2018-04-23 16:43:13 -07:00
bd5eee50f4
Unify correction factor calculations
2018-04-23 16:43:13 -07:00
3693e3b1e0
Standardize colons in track-via properties dialog
2018-04-23 11:53:18 -07:00
b2a9df33ea
Standardize colons in set grid dialog
2018-04-23 11:53:18 -07:00
6f6b65821a
Standardize colons in select pretty lib dialog
2018-04-23 11:53:18 -07:00
0cbc611135
Standardize colons in select net dialog
2018-04-23 11:53:18 -07:00
938f8b1a9a
Standardize colons in Print using printer dialog
2018-04-23 11:53:18 -07:00
006bfabbdf
Standardize colon and remove abbr. in Print dialog
2018-04-23 11:53:18 -07:00
0e79538601
Standardize caps in position relative dialog
2018-04-23 11:53:18 -07:00
e219ff0c2f
Standardize colons pns settings dialog
2018-04-23 11:53:18 -07:00
3d2e103374
Standardize colons pns length tune dialog
2018-04-23 11:53:18 -07:00
3c00b2a2a8
Standardize colons plot dialog
2018-04-23 11:53:18 -07:00
fbb8ccb9ad
Standardize colons in pad properties dialog
2018-04-23 11:53:18 -07:00
30d1db6b1f
Standardize colons non-copper zones dialog
2018-04-23 11:53:18 -07:00
9b9345abba
Standardize colons and wording in netlist dialog
2018-04-23 11:53:18 -07:00
d562a7b26d
Standardize colons modedit_options_base
2018-04-23 11:53:18 -07:00
b834031425
Standardize colons layers_setup_base
2018-04-23 11:53:18 -07:00
9956ea20e7
Standardize colons layer_selection
2018-04-23 11:53:17 -07:00
bc7ccab642
Standardize colons global footprint edit
2018-04-23 11:53:17 -07:00
0ed6751ebe
Standardize colons global deletion
2018-04-23 11:53:17 -07:00
38dae061ce
Standardize colon board editor options
2018-04-23 11:53:17 -07:00
f96328afef
Standardize colon gendrill_base
2018-04-23 11:53:17 -07:00
0b07f2ba9e
Standardize colon and file/table in footprint lib dialog
2018-04-23 11:53:17 -07:00
65c3046fc9
Standardize colons for edit_footprint_text_base
2018-04-23 11:53:17 -07:00
f977d210ad
Standardize colons for edit_footprint_for_fp_editor
2018-04-23 11:53:17 -07:00
b9adcbdbe3
Standardize colons edit_footprint
2018-04-23 11:53:17 -07:00
8234cf721c
Standardize colon drc_base
2018-04-23 11:53:17 -07:00
340b9fc2a5
Standardize colon display_options_base
2018-04-23 11:53:17 -07:00
a73cbe221a
Standardize colong dimension editor base
2018-04-23 11:53:17 -07:00
f55ad77da6
Standardize colon design_ruls_base
2018-04-23 11:53:17 -07:00
202e81eaa5
Standardize colon create_array_base
2018-04-23 11:53:17 -07:00
34fed2075a
Standardize colon copper zones base
2018-04-23 11:53:17 -07:00
87f18665fc
Standardize colon block_options_base
2018-04-23 11:53:17 -07:00
c8d1e056f3
Standardize colon SVG_print_base
2018-04-23 11:53:17 -07:00
cfa9916836
Prevent issuing a print command before the previous one is finished
...
Fixes: lp:1765965
* https://bugs.launchpad.net/kicad/+bug/1765965
2018-04-23 11:25:28 +02:00
3cc0554e33
Code formatting
2018-04-23 11:18:51 +02:00
e75762b1e3
Better wording
2018-04-21 16:31:41 +02:00
a93da4aba6
Restored wxPD_APP_MODAL flag for progress dialogs
...
The flag is required on Linux, otherwise applications hang right after a
progress dialog disappears.
2018-04-20 22:55:39 +02:00
4302394990
Consistency between dialog titles and menu items.
...
... and between eeschema and pcbnew.
Also moved the Symbol & Footprint library table tabs to the top
so it's more clear what "by Scope" means.
Fixes: lp:1765359
* https://bugs.launchpad.net/kicad/+bug/1765359
Fixes: lp:1765516
* https://bugs.launchpad.net/kicad/+bug/1765516
2018-04-20 15:33:46 +01:00
5fb7f5a615
Fixed an assert in 3D shape download wizard
2018-04-20 14:23:53 +02:00
86906b05e0
Fix 3D shape & footprint download wizards freeze on OSX
...
Fixes: lp:1758095
* https://bugs.launchpad.net/kicad/+bug/1758095
2018-04-20 12:36:34 +02:00
536529e48f
Fixed unused captured variable warning
2018-04-20 08:44:41 +02:00
f81c77cd4e
Edit Tool: update the reference point for in-place modification
...
Fixes: lp:1765027
* https://bugs.launchpad.net/kicad/+bug/1765027
2018-04-19 17:10:06 +02:00
0a58de0c46
Selection Tool: reset is-hover flag
...
Fixes: lp:1765034
* https://bugs.launchpad.net/kicad/+bug/1765034
2018-04-19 16:17:54 +02:00
dce0743ddb
Removed nagging dialog in the delete tool.
2018-04-19 15:35:10 +02:00
a695c995c7
pcbnew: fixed a warning regarding unused captured variables
2018-04-19 14:42:53 +02:00
7e47ef7471
Fix warnings for unreferenced local variables
2018-04-18 15:08:37 -04:00
f68268c8ca
Only update msgpanel when dimension started
...
Fixes: lp:1765118
* https://bugs.launchpad.net/kicad/+bug/1765118
2018-04-18 10:06:23 -07:00
ad0deb16a2
Fix pcbnew: refresh canvas on opening a file only after mouse move
...
Fixes: lp:1760819
* https://bugs.launchpad.net/kicad/+bug/1760819
2018-04-18 09:01:13 +02:00
794e8d8a04
Moving IsOk dialogs to correct parents
2018-04-17 17:27:15 -07:00
ca544eb138
Adding radius info to panel for arcs/circles
2018-04-17 11:21:34 -07:00
6d855cbccb
Remove extraneous assert
...
Fixes: lp:1764619
* https://bugs.launchpad.net/kicad/+bug/1764619
2018-04-17 10:53:27 -07:00
45d1c19eb7
Add tooltip text to drag options.
2018-04-17 08:59:52 -07:00
0294e41cbc
fix minor compil warnings (about signed/unsigned comparison)
2018-04-17 16:08:12 +02:00
e84e5606c9
Fix compiler warning.
2018-04-17 15:06:38 +01:00
000457db7c
Move Fields Editor to wxGrid.
...
Makes in-place editing much easier and fixes some other issues
(see bug reports).
Fixed sorting bugs in References and added better sorting for
Values.
Removed Description column as it wasn't editable and caused more
confusion than value.
Removed auto-column-width after initial render.
Re-implemented undo/redo.
Fixes: lp:1749287
* https://bugs.launchpad.net/kicad/+bug/1749287
Fixes: lp:1737361
* https://bugs.launchpad.net/kicad/+bug/1737361
Fixes: lp:1759756
* https://bugs.launchpad.net/kicad/+bug/1759756
Fixes: lp:1763223
* https://bugs.launchpad.net/kicad/+bug/1763223
Fixes: lp:1761378
* https://bugs.launchpad.net/kicad/+bug/1761378
2018-04-17 11:39:44 +01:00
268aeeb18f
Pcbnew: More explicit tool tip in right vertical toolbar (place auxiliary axis origin tool).
2018-04-17 10:06:11 +02:00
12ec56bc15
Prevent reentrancy in footprint loading.
...
Also removes parallel implementation in favour of using the
normal one (with a new wxGauge-backed PROGRESS_REPORTER).
Fixes: lp:1764196
* https://bugs.launchpad.net/kicad/+bug/1764196
2018-04-16 23:19:08 +01:00
07dc12fdd3
Fix incorrect UI management of Zoom to Selection, created by fix 2a419156
2018-04-14 17:44:17 +02:00
a1acec5f13
Revert broken hotkey fix.
...
The hotkey fix committed in 53b1ec81
2018-04-14 08:24:25 -04:00
2a419156e0
Don't try to check uncheckable menu items.
...
When updating toolbars make sure the events are coming from the
toolbar in question (and not the menus which share the same ID).
Fixes: lp:1763563
* https://bugs.launchpad.net/kicad/+bug/1763563
2018-04-13 21:42:31 +01:00
81843c37a4
Organize trace debugging code for ease of maintenance.
2018-04-13 09:59:01 -04:00
b907fb856d
Fix names of libraries added to symbol/footprint library tables
2018-04-13 14:24:57 +02:00
3f734eb1b5
Improved validation of library and entry names
...
Symbol/footprint library and entry have the same set of forbidden
characters with a single exception, space character. To accommodate for
this difference, LIB_ID validation and fix methods have been extended to
specify the LIB_ID type that is checked (schematic/board).
LIB_ID::HasIllegalChars() and LIB_ID::FixIllegalChars() had two different
sets of characters treated as invalid in LIB_IDs. The set has been
factored out to another function to avoid duplication.
2018-04-13 14:24:57 +02:00
1663627135
Update msg panel on create/modify graphic items
...
This clears the msg panel when not editing an item and updates the
position information when moving
2018-04-12 10:07:24 -07:00
4e99b0d0e7
pcbnew: refresh message panel while drawing & editing graphical lines, arcs, circles and texts
...
Fixes: lp:1763052
* https://bugs.launchpad.net/kicad/+bug/1763052
2018-04-12 18:23:33 +02:00
c1ae2fd0a8
Typo
2018-04-10 20:27:54 +02:00
9ea360f168
Pcbnew: avoid useless validation dialog about modifications when closing pcbnew or opening a file, when the initial board is empty.
...
Some changes (enable/disable a layer) set the dirty bit even for empty boards.
So when closing pcbnew, the dialog asking for saving the board was shown, even when no board loaded.
2018-04-10 20:17:47 +02:00
84151990cd
Don't set dirty bit when adding MARKERs.
...
They're not saved in the file, so they shouldn't dirty it.
Fixes: lp:1762497
* https://bugs.launchpad.net/kicad/+bug/1762497
2018-04-09 21:19:11 +01:00
f83ebb316e
Don't refill if zone fills aren't out-of-date.
2018-04-09 17:04:51 +01:00
05dae96275
Move zone out-of-date check to the right place.
...
Fixes: lp:1760097
* https://bugs.launchpad.net/kicad/+bug/1760097
2018-04-09 15:09:47 +01:00
900bf0c7a6
Allow connections to no-net items in Highlight Collisions mode.
...
If the track being routed is unconnected, or the end-point
clicked on is unconnected, allow the connection by changing
the unconnected item to the net of the connected one.
Fixes: lp:1548129
* https://bugs.launchpad.net/kicad/+bug/1548129
2018-04-09 11:05:14 +01:00
a597ebc85e
Break a track when placing a via on it.
...
Fixes: lp:1737349
* https://bugs.launchpad.net/kicad/+bug/1737349
2018-04-09 11:05:14 +01:00
d54a252eaa
Check zone fills for being out-of-date during DRC.
2018-04-09 11:05:14 +01:00
9f5316e38f
Remove code related to Gerber job file old format writer, as this format does not exist now.
...
This old format is now officially replaced by a JSON syntax.
2018-04-09 09:26:01 +02:00
a11714b1a4
fix misspelled 'an other' -> 'another'
2018-04-08 13:24:37 -04:00
77b3a662fc
fix misspelled 'Allows to' -> 'Allows one to'
2018-04-08 13:24:30 -04:00
1f32f7c55b
fix misspelled 'allows to' -> 'allows one to'
2018-04-08 13:24:18 -04:00
efa2a13eaa
Don't install Python shell when wxPython support is disabled.
...
Fixes lp:1760200
https://bugs.launchpad.net/kicad/+bug/1760200
2018-04-08 13:20:49 -04:00
7f6e26e55a
DrawGraphicText: remove a static variable, and replace it (when needed) by a new parameter in argument list.
...
It make this function thread-safe (as far as wxString is thread-safe)
2018-04-07 19:57:26 +02:00
baef22df9a
Fix memory leak and push menu change to other apps.
...
Fixes: lp:1761848
* https://bugs.launchpad.net/kicad/+bug/1761848
2018-04-07 14:14:55 +01:00
be4d7987d3
Rebuild apple menu along with others when language changes.
...
Fixes: lp:1761848
* https://bugs.launchpad.net/kicad/+bug/1761848
2018-04-07 11:01:56 +01:00
2bfbff104e
Very minor fix: remove a trailing space in string. Mainly to help translations.
2018-04-06 20:12:33 +02:00
fdb6bbab7b
Footprint Wizard now also handles custom Env paths
2018-04-06 14:51:09 +01:00
15c64ee92d
pcbnew: CONNECTIVITY_ALGO should always mark newly added nets as dirty
...
Fixes: lp:1761698
* https://bugs.launchpad.net/kicad/+bug/1761698
2018-04-06 14:57:27 +02:00
24b8768f43
Fix missing include.
2018-04-06 11:39:35 +01:00
db73daa09c
Workaround for wxString's lack of thread safety.
2018-04-06 11:26:59 +01:00
94dbcc7199
Fixed crash after multiple 'cut' commands in the footprint editor
...
When multiple cut commands were issued, the cut command handler would
restart multiple times and keep running until the handler that was
invoked first finishes. As all handlers kept a selection copy, they
would try to save the deleted items to the clipboard resulting in a
crash.
Fixes: lp:1761221
* https://bugs.launchpad.net/kicad/+bug/1761221
2018-04-05 00:26:57 +02:00
bbb513e2e5
Ensure that we are drawing holes and outlines
...
Set hole colors in output to non-transparent values.
Ensure holes are traced when drawing drill marks.
Fixes: lp:1646482
* https://bugs.launchpad.net/kicad/+bug/1646482
2018-04-04 10:20:15 -07:00
906b389fab
fp editor: minor cosmetic fix in main menu.
2018-04-04 17:40:42 +02:00
df43f071e1
Keep track of open sockets and dispose of them in d'tor.
...
Fixes: lp:1760936
* https://bugs.launchpad.net/kicad/+bug/1760936
2018-04-04 12:02:40 +01:00
5e36fe8df7
Move timestamp setting where it will alwasy get set.
...
Also update the rest of the symbol-chooser usage to current
specs, including examining the timestamp to see if the list
needs loading at all.
Partial fix to: lp:1760936
* https://bugs.launchpad.net/kicad/+bug/1760936
2018-04-04 12:02:40 +01:00
8b21a0a53d
Changed PCB_BASE_FRAME::CreateNewModule() to stop adding modules to the board
...
When a new footprint is created, CreateNewModule() added it to a dummy
board in the footprint editor. If a footprint was indeed created (the
action has not been aborted) then the dummy board was cleared,
destroying the just created footprint. Also, the new footprint is later
added with AddModuleToBoard() call.
Fixes: lp:1761052
* https://bugs.launchpad.net/kicad/+bug/1761052
2018-04-04 09:34:12 +02:00
2e4f50f206
Make sure segments read from file are in correct order.
...
Fixes: lp:1752033
* https://bugs.launchpad.net/kicad/+bug/1752033
2018-04-03 22:01:34 +01:00
7943372e8b
Refill zones only when required
...
Previous implementation refilled zones every time they have been
unselected. This patch adds a flag that tracks whether the
zone has been actually modified, so it will be refilled only when
necessary.
Fixes: lp:1760903
* https://bugs.launchpad.net/kicad/+bug/1760903
2018-04-03 22:28:05 +02:00
f8a3ec4974
Add a method to facilitate Tools handling in main frame toolbars.
...
Fix also a bug in gerbview_frame.cpp, about a broken toolbar accessor (fortunately not used in current code)
2018-04-03 13:00:20 +02:00
d391489596
Don't clear old footprint till after user has hit OK.
...
Fixes: lp:1759190
* https://bugs.launchpad.net/kicad/+bug/1759190
2018-04-02 22:32:09 +01:00
f4c972db5e
Name the Get and Move Footprint dialog to match the command.
...
Fixes: lp:1760635
* https://bugs.launchpad.net/kicad/+bug/1760635
2018-04-02 20:16:26 +01:00
89381e1103
Eagle Import: Correct layer set based on cream setting and rotate rectangles
...
Fixes: lp:1758747
* https://bugs.launchpad.net/kicad/+bug/1758747
2018-04-02 10:59:54 -07:00
ee05b1c92e
Add polygon arc support to Eagle import
2018-04-02 10:49:43 -07:00
532bf09817
Don't save broken polygon
...
If a polygon has fewer than 3 points, it is invalid. We need to
register this as failure, otherwise we save the formatting/closing
s-expr for the polygon without the actual polygon points. This breaks
the footprint and board.
2018-04-02 10:18:10 -07:00
62c5a706d5
DIALOG_GRAPHIC_ITEM_PROPERTIES: fix a not very understandable error message (especially when Dwgs.User layer is disabled).
...
Rename the method PCB_LAYER_BOX_SELECTOR::SetLayerSet to the better name SetNotAllowedLayerSet
2018-03-31 10:46:52 +02:00
7d3d9f7188
Wrapping left-over debug printf() in DBG()
2018-03-30 16:17:29 -07:00
4917540069
Clarify timestamp type for wxDateTime
2018-03-29 09:29:05 -07:00
0f0d9afa66
Pcbnew, legacy mode: fix ratsnest display artifacts when finishing or removing a track
2018-03-29 09:28:41 +02:00
d1ab62fb4d
pcbnew: Save only edited footprint when saving
...
Don't re-save all files in a library when editing a single footprint.
This creates issues with formatting in version control systems where
unmodified files are re-written without being explicitly changed by the
user.
Fixes: lp:1752991
* https://bugs.launchpad.net/kicad/+bug/1752991
2018-03-28 14:42:32 -07:00
6740a37632
move and swap layers: make changes undoable.
...
minor code cleanup.
2018-03-28 15:30:11 +02:00
6a4d14bade
Fix cosmetic issues in dialog. Use move instead of swap in dialog, to avoid mistakes, as the dialog allows moving objects between layers, and do not really swap layers.
2018-03-28 12:45:54 +02:00
ffa454d6f9
class MODULE: use timestamp_t instead of time_t in SetLastEditTime and GetLastEditTime, like in all other methods using a time stamp.
2018-03-27 20:43:52 +02:00
2edc675eaf
DIALOG_LAYERS_SETUP: force 4 non copper layers to be always in use.
...
edge cut, courtyard and margin layers are (or can be) used in DRC.
So they are seen as mandatory, and the dialog always force them active.
2018-03-27 20:26:48 +02:00
78161b5922
Layers setup management: Warn user if some removed layers are in use in footprints loaded on the board.
...
Fix also memory leak and missing connectivity rebuild.
2018-03-27 13:44:59 +02:00
602d9e1972
Fix a missing init in gerber plot script demo.
...
Fixes: lp:1759071
https://bugs.launchpad.net/kicad/+bug/1759071
2018-03-27 13:42:51 +02:00
0ded476f9d
Add a hotkey to control net highlighting
...
Fixes: lp:1757446
* https://bugs.launchpad.net/kicad/+bug/1757446
2018-03-26 23:09:44 -04:00
9472444b41
Fix minor rounding error in curved wire import
2018-03-26 15:18:47 -07:00
ced0fcee1e
Updating Eagle Importer to take curved zones
...
Fixes: lp:1755879
* https://bugs.launchpad.net/kicad/+bug/1755879
2018-03-26 15:09:56 -07:00
886dc48cc4
Point Editor: reset the pointer to the modified point as it becomes invalid
...
Fixes: lp:1759024
* https://bugs.launchpad.net/kicad/+bug/1759024
2018-03-27 00:03:48 +02:00
778a3a4777
Count pins instead of using netcount as a proxy.
...
Fixes: lp:1703155
* https://bugs.launchpad.net/kicad/+bug/1703155
2018-03-26 19:57:08 +01:00
ca4e4aead4
router: don't push vias if push force is zero
...
Fixes: lp:1758540
* https://bugs.launchpad.net/kicad/+bug/1758540
2018-03-26 20:13:32 +02:00
347f6daddc
Eagle Converter: Adjust arcs to use error-based alg
...
Implements the revised, difference-error based algorithm in the Eagle
arc import rather than using the hard-coded 32-segments/360°
2018-03-26 10:39:23 -07:00
a8b1c2a8f2
Change dimension style to improve display and be more standard
2018-03-25 21:50:57 -04:00
c8c5b5da07
Fix zoom to selection in bug in gal canvas.
2018-03-25 16:12:56 -04:00
a763435b59
Change zone segment count to high/low res.
2018-03-25 20:20:51 +01:00
f4ce8766e3
Implement shared FOOTPRINT_LIST.
...
While we already cache the loaded footprint files, parsing said files
into the list is also time-intensive. Since the FOOTPRINT_LIST is
already hash-stamped against the current timestamps of the files that
make up the list, sharing a single copy of the list is quite
straight-forward.
2018-03-25 19:21:28 +01:00
8d8c422a19
Add zoom to selection menu entry to all editors.
...
Fixes lp:1753339
https://bugs.launchpad.net/kicad/+bug/1753339
2018-03-25 12:34:19 -04:00
6b51cc33da
Set appropriate parent for 3D library downloader progress dialog
...
Fixes: lp:1758095
* https://bugs.launchpad.net/kicad/+bug/1758095
2018-03-24 21:08:35 -04:00
4b5ca0ec14
Drawing tool: prevent creating zero-length lines
...
Fixes: lp:1758570
* https://bugs.launchpad.net/kicad/+bug/1758570
2018-03-24 23:57:06 +01:00
97fffe875f
Notify clients when GRID_TRICKS toggles checkboxes.
2018-03-24 13:13:57 +00:00
f317b10adf
Ensure that the current copper zone is not first
...
The zeroth index is reserved especially for the <no net> tag, so we need
to keep the current net at 1 or greater to keep it connected.
Fixes: lp:1758488
* https://bugs.launchpad.net/kicad/+bug/1758488
2018-03-23 20:38:47 -07:00
fb882633b2
Save layers regardless of view
...
We do not modify the underlying board when saving. Previously only the
visible layers were saved. This created a discrepancy between the board
that the user was editing and the board that was saved to disk.
Fixes: lp:1754049
* https://bugs.launchpad.net/kicad/+bug/1754049
2018-03-23 09:32:56 -07:00
fbf10e941b
Switch zone fillets to absolute-error algorithm.
...
And some general cleanup to related constants, etc.
2018-03-23 12:46:17 +00:00
d2d0660647
Open viewer even when FPID is invalid.
...
Just show an empty viewer.
2018-03-23 12:46:17 +00:00
a0364a1137
Don't make user click twice to toggle checkbox in wxGrid.
2018-03-23 12:46:17 +00:00
5b653c0c1e
Update MacOS icons
...
Fixes: lp:1750284
* https://bugs.launchpad.net/kicad/+bug/1750284
2018-03-22 11:45:42 -04:00
94c780975e
Very minor cosmetic fix.
2018-03-22 12:01:06 +01:00
62fd734007
Footprint Viewer: do not try to preselect an empty footprint
...
Empty string is treated as an invalid LIB_ID, so it ends up with an
exception.
2018-03-22 11:38:10 +01:00
4152069504
Make vias selectable even if top and bottom layer are hidden
2018-03-21 22:15:17 -04:00
79fe134495
Init Footprint Viewer with current FPID.
...
Fixes: lp:1757421
* https://bugs.launchpad.net/kicad/+bug/1757421
2018-03-21 23:11:55 +00:00
99e659ff54
Coverity fixes.
2018-03-21 23:11:55 +00:00
ff3f229871
Decouple vias from tracks in selection filter
2018-03-21 17:21:08 -04:00
ea3f8743fd
Fixes in GAL selection filter:
...
- vias were always left selected, include vias in tracks filter - as in legacy
- make text filtering work
- cleanup drawings filtering code
- hide checkbox "Include items on invisible layers" because it does not work in GAL
2018-03-21 17:21:01 -04:00
7b4a8d7eb5
Gerber job file: update file format due to a recent change.
...
Please: note the gerber JSON file format is currently a moving target, although most of the format is now fixed.
Most, but not all.
2018-03-21 12:40:10 +01:00
285bf79370
Fix strings for save/load project menu options; standardize on "Load"
...
Fixes: lp:1753659
* https://bugs.launchpad.net/kicad/+bug/1753659
2018-03-20 22:20:54 -04:00
b9ce203487
Fix pad selection requirements in footprint editor
...
Fixes: lp:1757295
* https://bugs.launchpad.net/kicad/+bug/1757295
2018-03-20 21:15:05 -04:00
b53ed148f3
Optimization to track DRC and some formatting cleanup
2018-03-20 20:37:35 -04:00
c78171d01f
DRC: Add an optional mode to report all track errors
...
Fixes: lp:1754442
* https://bugs.launchpad.net/kicad/+bug/1754442
2018-03-20 19:54:06 -04:00
73408f3f21
Correct DRC calculation on segments
...
If objects are at the clearance limit, they qualify as passing DRC.
Therefore, all comparison functions that indicate failure should be
strictly greater than or less than while all comparison functions that
indicate success (in the DRC) should be greater/equal or less/equal.
This also corrects a rounding error at the nm scale and handles
scaling zero-length and large segments correctly.
Fixes: lp:1756403
* https://bugs.launchpad.net/kicad/+bug/1756403
Fixes: lp:1593373
* https://bugs.launchpad.net/kicad/+bug/1593373
2018-03-20 15:35:53 -07:00
683be7155e
Mirror-image coordinate system on back of board for PNP.
...
Also converts any delimiters in tokens to underscores.
Fixes: lp:1679205
* https://bugs.launchpad.net/kicad/+bug/1679205
2018-03-20 16:57:42 +00:00
b5f1fdd981
Add icon to Get and Move context menu item in GAL mode.
...
Windows does not like mixing menu items with and without icons (sizing error).
Fixes: lp:1756263
https://bugs.launchpad.net/kicad/+bug/1756263
2018-03-20 08:30:02 +01:00
3103e3dc4c
DRC: Center zoom on marker location, not DRC item start location
...
For some DRC checks, the location of the marker is not the location
of the first item in the resulting DRC_ITEM, so centering the screen
on PointA of the DRC_ITEM can be confusing.
2018-03-19 22:25:55 -04:00
33dcc080ea
STEP exporter: check board outline continuity
2018-03-19 17:34:11 +01:00
5ba3e43d31
Converted STEP exporter dialog to use WX_HTML_REPORT_PANEL
2018-03-19 17:04:38 +01:00
2ff74cb3fc
Add support for .gbrjob new file format (JSON format) in Gerbview
...
Add experimental code to generate .gbrjob files in the new JSON file format
2018-03-19 15:14:20 +01:00
1a845bc4ad
Safer way to commit in-progress changes in wxGrid.
...
In some cases the wxGrid would attempt to close the editor in
the middle of the d'tor, resulting in segfaults.
2018-03-19 12:13:28 +00:00
ce610f33a2
Coverity fixes
...
resource leak: #172233
negative array index write: #102363
uninitialized scalar field: #174540 #174539
structurally dead code: #169334 #169331
2018-03-19 10:02:05 +01:00
aa0ae48dda
Update status bar and toolbars on language change.
...
Fixes: lp:1392582
* https://bugs.launchpad.net/kicad/+bug/1392582
Fixes: lp:1748428
* https://bugs.launchpad.net/kicad/+bug/1748428
2018-03-18 22:17:27 +00:00
89ebab5df2
Comments for SELECTION_TOOL::guessSelectionCandidates().
2018-03-18 22:17:27 +00:00
df924a5e68
Follow standard FBP naming conventions.
2018-03-18 22:17:27 +00:00
e0e0687cd7
Revert "Allow 5.0 to read 6.0 files with hole-to-hole clearance settings."
...
This reverts commit 0a4c04530a
2018-03-16 22:22:15 +00:00
b8fd2f3c79
Revert "Don't be pedantic about the file format."
...
This reverts commit 1537cbc59c
2018-03-16 18:11:36 +00:00
d3e7efcd66
Ignore pads when selecting drag candidates in router tool.
...
Fixes: lp:1747156
* https://bugs.launchpad.net/kicad/+bug/1747156
2018-03-16 18:01:40 +00:00
1537cbc59c
Don't be pedantic about the file format.
...
It's just another form of nagging.
2018-03-16 16:57:38 +00:00
3f52e87224
Standardize terminology for automatic zoom to "Zoom to Fit".
...
Fixes lp:1753336
https://bugs.launchpad.net/kicad/+bug/1753336
2018-03-16 08:38:36 -04:00
3b0a758f97
Ensure router layer is visible.
...
Fixes: lp:1663556
* https://bugs.launchpad.net/kicad/+bug/1663556
2018-03-16 02:43:17 +00:00
0a4c04530a
Allow 5.0 to read 6.0 files with hole-to-hole clearance settings.
2018-03-16 00:48:35 +00:00
a1a4275e8b
Cancel interactive tools when entering DRC.
...
Fixes: lp:1541526
* https://bugs.launchpad.net/kicad/+bug/1541526
2018-03-16 00:28:02 +00:00
jean-pierre charras
Maciej Suminski
Jeff Young
Wayne Stambaugh
Tomasz Włostowski
Seth Hillbrand
Andrzej Wolski
Simon Richter
Jean-Samuel Reynaud
Carsten Schoenert
Mario Hros
Kristoffer Ödmark
Russell Oliver
Jon Evans