haskal
/
kicad
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,822 Commits 9 Branches 105 Tags 1.3 GiB
Commit Graph

216 Commits

Author SHA1 Message Date
Wayne Stambaugh cf00319c85 More NULL expunging. 2021-07-20 07:27:18 -04:00
Jeff Young ea6769b702 The REPORTER interface is inherently line-based. 
Also fixes a bunch of error messages that were similar but not
identical (which just increases translation burden).

Fixes https://gitlab.com/kicad/code/kicad/issues/8723
 2021-07-05 13:41:06 +01:00
Jeff Young c8444913df Implement lock between zone filler and drc. 
Fixes https://gitlab.com/kicad/code/kicad/issues/8621
 2021-06-16 16:12:01 +01:00
luz paz f968fc8719 Fix source comment / documentation typos 2021-06-09 19:32:58 +00:00
Marek Roszko d946d6e68f Cleanup some pgm_base.h includes 2021-06-08 21:56:00 -04:00
Marek Roszko 8f2819cfa4 Kill the last of wx/wx.h in headers 2021-06-07 17:59:20 -04:00
Marek Roszko 10e60acf34 Clean up including of board_design_settings.h 2021-06-06 15:03:42 -04:00
Jeff Young 3de60231db Allow clearance debugging of exact items in DRC violation. 
ADDED: Run clearance resolution tool... RMB menu item to DRC
clearance errors.

Fixes https://gitlab.com/kicad/code/kicad/issues/8438
 2021-05-21 00:00:24 +01:00
Jeff Young 5ea68c7694 Copy some bug fixes from DRC dialog across to Footprint Checker. 2021-04-08 22:37:14 +01:00
Jon Evans c04e19f9ac Include optimization: move some things from common.h to point-of-use 2021-03-20 12:09:18 -04:00
Jon Evans 720147d272 Remove transitive inclusion of bitmaps.h 2021-03-07 16:08:57 -05:00
Marek Roszko 622baa6531 Silence more unused exception var warnings 2021-02-20 12:01:51 -05:00
Zoltan Gyarmati bbe2ee39a0 pcbnew: actually reload DRC parity checkbox value in project mode 
Fixes https://gitlab.com/kicad/code/kicad/issues/7551
 2021-02-19 00:37:29 +00:00
Jeff Young 0bce280424 Make sure design rules get recompiled after netclass changes. 
Fixes https://gitlab.com/kicad/code/kicad/issues/7082
 2021-01-13 12:37:20 +00:00
Jeff Young f30fa60ed7 Need to start with full layer set if we want to end up with any. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6822
 2020-12-23 15:15:09 +00:00
Jeff Young 3b35bfc0a5 Don't write out synthetic severities (they're headings). 
Fixes https://gitlab.com/kicad/code/kicad/issues/6726
 2020-12-14 13:34:53 +00:00
Jeff Young af841d1318 Pay attention to flashed layers when doing DRC layer switch. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6710
 2020-12-11 17:58:36 +00:00
Jeff Young df262eaa06 Make prev/next marker work reliably on all platforms. 
Requires us to move from arrow-keys to our own commands (the only
way that the OSX wxWidgets impl doesn't eat the keys when the dataVIew
has focus).

While there we might as well add a command to exlucde markers.

ADDED Prev Marker, Next Marker, Exclude Marker

Fixes https://gitlab.com/kicad/code/kicad/issues/6575

Fixes https://gitlab.com/kicad/code/kicad/issues/5501
 2020-12-01 22:37:07 +00:00
Jeff Young b123318cf6 Encourage use of full DRC for board & footprint malformed outlines. 
It shows much more detail.  Removes some nag dialogs and places
hypertext links in others.

Also fixes the auto-layer-showing to correctly show Edge.Cuts or
F.CrtYd or B.CrtYd for errors relating to them.

Fixes https://gitlab.com/kicad/code/kicad/issues/6446
 2020-11-20 17:24:52 +00:00
Jeff Young a207bd97bb Naming conventions. 2020-11-17 16:05:49 +00:00
Jeff Young 7bd31d5237 Naming conventions. 2020-11-14 18:26:03 +00:00
Jeff Young 115fd1d7f3 Move track-to-zone testing to RTrees. 
Also implemente pad-to-zone testing and removes the control in the
GUI (now that it's fast).
 2020-10-31 15:45:41 +00:00
Jeff Young f1e9ecad41 Display full count in tab headers (even if actual list is truncated). 2020-10-31 15:45:41 +00:00
Ian McInerney 06bf7943b7 Minor warning fixes 2020-10-21 00:30:50 +01:00
Jeff Young 229a505b11 Only suppress all-green (0) error counts when DRC hasn't been run. 2020-10-20 16:57:56 +01:00
Jeff Young f772e49d25 Adjust DRC badge spacing on OSX. 
Also added dynamic badge sizing based on number of digits.
 2020-10-20 16:57:56 +01:00
Ian McInerney 7c9acc605d Introduce a new number badge UI element for DRC and ERC reporting 
This new badge allows for proper UI scaling and will not cut off
the number being displayed.

Fixes https://gitlab.com/kicad/code/kicad/-/issues/5734
Fixes https://gitlab.com/kicad/code/kicad/-/issues/6011
 2020-10-20 02:35:48 +01:00
Jeff Young 725082786e Move ERC dialog to DRC architecture. 
This is mainly to remove the annotation nag dialogs in favour of the
HTML links.  But it also allows you to see more than a few messages,
and implements a progress reporter architecture if the ERC checks ever
get slow enough to benefit from it.
 2020-10-19 15:17:49 +01:00
Jeff Young 8c68857f02 Add immediate mode to WX_HTML_REPORT_BOX for use as progress messages. 
Fixes https://gitlab.com/kicad/code/kicad/issues/6052
 2020-10-18 14:20:36 +01:00
Jeff Young c5d45f8a78 Move DRC dialog to same DRC rule reporting mechanism as inspectors. 2020-10-17 20:40:05 +01:00
Jeff Young eea7957e16 Inform user of bad DRC rules when filling zones. 
ADDED: facility for hypertext links in infobar.

Also made use of this for via constraint errors when routing.

Fixes https://gitlab.com/kicad/code/kicad/issues/5800
 2020-10-16 12:44:20 +01:00
jean-pierre charras 8285110c2a more cleanup about removing useless include 2020-10-02 08:58:19 +02:00
Jeff Young 803f53d6b2 Don't reload DRC lists on activate event. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5701
 2020-10-01 22:45:54 +01:00
jean-pierre charras 39d2a46b30 Avoid Pcbnew crash when double clicking in DIALOG_DRC on a error item. 2020-09-28 21:07:51 +02:00
Jon Evans 0783669633 CHANGED: Design rules files now use .kicad_dru extension 
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5763
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5444
 2020-09-24 21:26:23 -04:00
Jeff Young 5ad76a237e Moving checking the rules up a level so we can properly exit DRC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5778
 2020-09-24 15:17:46 +01:00
Jeff Young 660cdcb056 More defensive coding for wxDataViewCtrl selection access. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5747
 2020-09-23 20:31:48 +01:00
Jeff Young 6dae769944 Progress reporting for connectivity tests. 
Also makes via annulus terminology more consistent.
 2020-09-23 16:28:00 +01:00
Jeff Young 167ae374fd Don't allow two DRC runs at the same time. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5745
 2020-09-23 14:10:07 +01:00
Jeff Young 6020b70596 Display green badge for zero errors or zero warnings. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5735
 2020-09-21 11:59:27 +01:00
Jeff Young c6fb799fcd Restore severity in saved DRC/ERC reports. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5733
 2020-09-21 11:59:27 +01:00
Jeff Young ad2407867a Disable Save Report while DRC is running. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5723
 2020-09-20 13:55:58 +01:00
Ian McInerney 89dcc46898 Coverity cleanup and remove unused variables 2020-09-20 02:20:41 +01:00
Jeff Young 67b5d24995 Support ESC & Cancel for DRC. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5698
 2020-09-18 22:14:00 +01:00
Jeff Young a3d65a2b43 Smoother progress reporting for DRC checks. 
Also moves Messages tab out to an overlay, and restores the longer
messages now that messages are no longer a textbox in the upper right.
 2020-09-17 20:13:39 +01:00
Jeff Young 2b43ffd12d Better error reporting; better nullptr safety. 
Also clears the marker lists before running a DRC, and sets
the drcRun flags afterwards so that the notebook tab counts
get updated.

Fixes https://gitlab.com/kicad/code/kicad/issues/5659
 2020-09-16 22:14:41 +01:00
Jeff Young ce3819abf8 Remove redundant clearances from DRC dialog. Fold progress bar in. 2020-09-16 16:06:29 +01:00
Jeff Young b6a8e165c3 Don't allow schematic/pcb DRC tests when in standalone mode. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5635
 2020-09-15 21:14:11 +01:00
Jeff Young 514da2f886 Move DRC dialog to new DRC engine. 2020-09-14 22:39:36 +01:00
jean-pierre charras 4cda653dbd dialog_drc: fix a minor issue when saving dialog drc options. 
Fixes #5623
https://gitlab.com/kicad/code/kicad/issues/5623
 2020-09-14 17:45:39 +02:00
Jeff Young 5e9ec82642 Correctly resolve textVar refs in worksheet items in ERC. 
Also fixes a null-ptr bug in DRC.

Fixes https://gitlab.com/kicad/code/kicad/issues/5506
 2020-09-04 21:38:07 +01:00
Ian McInerney 4491f24d5e Ripout the old SyncToolbars infrastructure reminants 
The tool framework no longer needs to request updates of the UI
state for the controls, wxWidgets will do it for us.
 2020-08-16 19:10:26 +00:00
Jon Evans bd14f8a82a ADDED: New appearance control widget for PcbNew 
Featuring:
- Layer view presets
- Per-type opacity for tracks, vias, pads, zones
- Net and netclass color and visibility controls

CHANGED: Simplified object visibilty controls

Fixes https://gitlab.com/kicad/code/kicad/-/issues/1951
Fixes https://gitlab.com/kicad/code/kicad/-/issues/1981
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2003
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2173
Fixes https://gitlab.com/kicad/code/kicad/-/issues/2254
Fixes https://gitlab.com/kicad/code/kicad/-/issues/4325
 2020-08-15 15:24:28 -04:00
Tomasz Wlostowski 47919cdc54 pcbnew/dialogs: use shared_ptr for RC_ITEM 2020-08-13 14:50:59 +02:00
Tomasz Wlostowski d937fadd6f Migrate RC_ITEM to use shared_ptr 2020-08-13 14:50:59 +02:00
Jeff Young f65a0037dc Display violation layer (and select it) for DRC errors. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5123
 2020-08-11 17:47:39 +01:00
Jeff Young ae404e6339 Update board markers from DRC changes before dialog is closed. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5110
 2020-08-08 19:09:22 +01:00
Jeff Young 0f3d79245e Tidy up delete-all-markers. 
Fix a typo in the order of booleans, and move from 3 buttons to
2 buttons and a (remembered-for-session) checkbox.
 2020-08-04 13:28:16 +01:00
Jeff Young f67ba62c11 Don't stop when current item is reached: there might be more. 
In particular, the two sub-items also count as "current" and need
to be deleted.

Fixes https://gitlab.com/kicad/code/kicad/issues/5057
 2020-08-04 13:28:16 +01:00
Jeff Young 9c9fdb2569 More performant (and more correct) deletion of DRC markers. 
Fixes https://gitlab.com/kicad/code/kicad/issues/5057
 2020-08-04 11:45:07 +01:00
Jeff Young c56599ab07 Allow ERC/DRC markers to be deleted without deleting exclusions. 
Fixes https://gitlab.com/kicad/code/kicad/issues/4953
 2020-08-02 22:45:48 +01:00
Jon Evans 12b4a55ae8 Port Eeschema to new project settings 
DRC/ERC error serialization changed to use explicit tokens
Old stored severities and ignored errors are discarded
 2020-07-02 22:08:54 -04:00
Jeff Young 6d5b6c8b81 A bit more refactoring to get code out of the DRC tool. 2020-05-29 22:06:48 +01:00
Jeff Young 6ef6284924 Make sure markers get removed from view when deleted. 2020-05-26 22:09:31 +01:00
Jeff Young 160981ee71 Better error reporting for DRC rule parsing. 2020-05-25 22:51:47 +01:00
Jeff Young d3f017d825 DRC rules parser and engine. 
Fixes https://gitlab.com/kicad/code/kicad/issues/2182

Fixes https://gitlab.com/kicad/code/kicad/issues/2116

Fixes https://gitlab.com/kicad/code/kicad/issues/1958

Fixes https://gitlab.com/kicad/code/kicad/issues/1965
 2020-05-16 15:53:05 +01:00
Jon Evans 51eac3e3e6 Split pcbnew and footprint editor settings getters for clarity 2020-05-05 21:46:00 -04:00
Jeff Young e0da677d4d Add min clearance to DRC; rename Min Via Drill to Min Through Hole. 
Also fixes a crash bug when ignoring a DRC violoation with multiple
markers.

Fixes https://gitlab.com/kicad/code/kicad/issues/2528
 2020-05-04 22:08:36 +01:00
Jeff Young fd6dffe170 Only save changed severities etc. if the modify bit is set. 
(Also means we need to set said bit when changing them.)

Fixes https://gitlab.com/kicad/code/kicad/issues/4164
 2020-04-24 23:09:10 +01:00
Jeff Young 32db9eb0f1 Add some distances to a few DRC errors. 2020-04-24 22:17:45 +01:00
Jeff Young 1535c83b88 Lay some groundwork for adding distances to DRC errors. 
modified:   eeschema/lib_rectangle.cpp
 2020-04-24 14:46:22 +01:00
Jeff Young 840cab4eec Allow user to show layer if DRC object is hidden. 
Fixes https://gitlab.com/kicad/code/kicad/issues/3686
 2020-04-07 17:29:58 +01:00
Jeff Young cee973dc04 Move ERC error reporting over to the new framework. 
Fixes https://gitlab.com/kicad/code/kicad/issues/1989
 2020-03-16 11:06:15 +00:00
Jeff Young 2359d19cf4 Add menu item to DRC dialog to go to Board Setup / Violation Severities. 2020-03-04 21:52:30 +00:00
Jeff Young d20f36511f Fix issue with severities not get initialised in DRC_TREE_MODELs. 2020-03-04 21:52:30 +00:00
Jeff Young 0894674869 Save severities settings in the DRC dialog. 
Fixes https://gitlab.com/kicad/code/kicad/issues/3978
 2020-03-04 21:52:30 +00:00
jean-pierre charras b7cd0c54c2 Fix compil issues, especially on Windows: 
Replace SEVERITY_ERROR by RPT_SEVERITY_ERROR to avoid collision with a system definition.
Replace other SEVERITY_XXX by RPT_SEVERITY_XX for consistency.
Fix compil warnings and some other compil issues.
 2020-03-04 10:48:18 +01:00
Jeff Young 85c2e0d23a Add user-defined severities, exclusions and colors to DRC markers. 
Exclusions are currently persisted in the project file.

Fixes https://gitlab.com/kicad/code/kicad/issues/1989
 2020-03-04 00:39:28 +00:00
Ian McInerney d5ceb8252e Clean up some warnings 2020-02-28 00:06:52 +00:00
Jeff Young 3860ab9f0c Fix issue returning pointers to items inside std::vector. 
(When the vector is re-allocated your pointers become bogus.)
 2020-02-27 22:00:51 +00:00
Jeff Young 82ae9db262 Another variation on the wxDataViewCtrl issue.... 2020-02-26 17:56:47 +00:00
Jeff Young cdad62022b Bug fix for double-click in DRC dialog. 
Also better clean-up of highlighting in board editor window.
 2020-02-25 12:18:24 +00:00
Jeff Young a4837f7d32 Move DRC dialogs to wxDataView. 
This allows for hierarchy and better selection handling.
 2020-02-24 23:19:17 +00:00
Jeff Young c5077aeb97 Move weak-reference stuff to UUIDs. 2020-02-24 23:19:17 +00:00
Jon Evans e59a3d981e Implement a new settings framework across all of KiCad 
CHANGED: Settings are now stored in versioned sub-directories
ADDED: First-run dialog for migrating settings from a previous version
CHANGED: Settings are now stored as JSON files instead of wxConfig-style INI files
CHANGED: Color settings are now all stored in a separate settings file
CHANGED: The symbol editor and footprint editor now have their own settings files
CHANGED: Color settings are no longer exposed through BOARD object
CHANGED: Page layout editor now uses Eeschema's color scheme

Settings are now managed through a central SETTINGS_MANAGER held by PGM_BASE.
Existing settings will be migrated from the wxConfig format on first run of each application.
Per-application settings are now stored in one class for each application.
 2020-02-19 23:44:56 -05:00
brian piccioni 8341398082 Save footprint errors in the DRC log 
Fixes https://gitlab.com/kicad/code/kicad/issues/3754
 2020-01-18 01:40:43 +00:00
Mark Roszko 11ff16be4e Switch to scoped enums 2019-12-20 14:11:39 +00:00
jean-pierre charras 5cd7f3fdee DIALOG_DRC_CONTROL: fix a crash on wxWidgets 3.1.3, Windows, 
Happens when right clicking on an item in displayed lists.
The crash was due to a bug in wxWidgets, and the fix is only a workaround

Also remove duplicate code.
 2019-12-02 11:27:40 +01:00
jean-pierre charras 16f4958430 Pcbnew: avoid crash when closing pcbnew if the DRC dialog is open. 
Cvpcb: change from commit 9ceca583:
the root class close event that save settings is now seeing the close event.
 2019-09-19 09:16:12 +02:00
Jeff Young a25368cc6b Improve spelling. 
The groundwork here is thanks to kunda1.

Fixes: lp:1831510
* https://bugs.launchpad.net/kicad/+bug/1831510
 2019-08-20 19:14:05 +01:00
Jeff Young da71a51029 Cleanup. 2019-07-02 00:48:05 +01:00
Jeff Young 8f84c3ec4f Grid rid of GetCanvas/GetGalCanvas distinction now that there's only gal. 2019-06-13 19:58:37 +01:00
Jeff Young 4e11dcfa31 Better error reporting for board edge collisions. 2019-06-04 13:56:54 +01:00
Jeff Young fbfbb64387 A bit of cleanup of stale DRC code. 2019-06-04 13:56:54 +01:00
Jeff Young d7574db805 Fix regression in dialog-avoidance when focusing on a location. 2019-06-03 21:08:30 +01:00
Jeff Young 7553cc2651 Clean up some dangling legacy odds and ends. 2019-06-01 01:17:46 +01:00
Jeff Young d6e9bdf07b Convert remaining legacy drawing code to print code. 2019-05-31 21:54:22 +01:00
Jeff Young 03bab2f4a9 Remove some more legacy drawing stuff. 2019-05-31 21:54:22 +01:00
Jeff Young 1e9da7f57b Remove CurItem() architecture and legacy routers and drawing code. 2019-05-29 00:26:30 +01:00
Seth Hillbrand b3b5ffe799 pcbnew: fixup small type issue 2019-05-15 09:53:42 -07:00