Jeff Young
4a561b04bc
Code cleanup and compiler warnings.
...
(cherry picked from commit 51848a0b43
)
2024-02-23 16:53:35 +01:00
Jeff Young
98cd040952
Set up default netclass wire & bus widths.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17024
(cherry picked from commit 2d7f4faf72
)
2024-02-23 16:53:35 +01:00
Jeff Young
2c49ba4252
Formatting.
...
(cherry picked from commit c75bb5d01a
)
2024-02-23 16:53:35 +01:00
Jeff Young
19dedccd98
Improve layout of schematic colors preview.
...
Also, set pin name/number sizes. Don't use defaults (which
will get plucked out of the Symbol Editor's settings).
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17043
(cherry picked from commit df8f043c16
)
2024-02-23 16:53:35 +01:00
Jeff Young
17a37a55f0
When updating RefDes only update the prefix.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16991
(cherry picked from commit b6036f368e
)
2024-02-23 16:53:34 +01:00
Jeff Young
2cd9fbab9d
Check known m_Desc field before m_Fields.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16971
(cherry picked from commit 25291d6e3a
)
2024-02-23 16:53:34 +01:00
Jeff Young
ca3cd706e5
Show friendly name in toolbar button tooltips.
...
(Don't require the same text to be put into the tooltip.
It's error-prone and also disallows us from having a separate
tooltip for toolbar buttons.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17009
(cherry picked from commit f4a085575a
)
2024-02-23 16:53:33 +01:00
Jeff Young
800bbd8841
Delete empty Netclass fields only if there are others.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16997
(cherry picked from commit a34b242f4e
)
2024-02-23 16:53:33 +01:00
Jeff Young
57dcf285c5
Various string issues held over from 8.0 string freeze.
...
(cherry picked from commit a610542a19
)
2024-02-23 16:53:31 +01:00
Jeff Young
23c2104ffa
Improve alignment tooltips.
...
(cherry picked from commit 2ab492474e
)
2024-02-23 16:53:31 +01:00
Jeff Young
f161a1eaac
Ignore duplicate/repeat when drawing an existing item.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16885
(cherry picked from commit 3caede3799
)
2024-02-23 16:53:30 +01:00
Jeff Young
9ff66d0e71
Don't capture references to local variables for CallAfter.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16934
(cherry picked from commit 9d40374baf
)
2024-02-23 16:53:30 +01:00
Roberto Fernandez Bautista
d464d7995b
Thread safety: replace ++m_modHash by IncrementModifyHash()
2024-02-23 14:59:10 +00:00
Roberto Fernandez Bautista
991ddfe6be
Add cache to SCH_IO_DATABASE to improve loading performance
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17031
2024-02-23 14:59:10 +00:00
Roberto Fernandez Bautista
07ab18a1e6
Legacy libraries: De-duplicate field names on load
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-23 14:57:57 +00:00
Roberto Fernandez Bautista
420413969e
Altium: Don't create duplicate fields
2024-02-23 14:57:57 +00:00
Roberto Fernandez Bautista
1a6e6a06eb
Altium: Don't load library parameters with an owner for now
...
In Altium many objects can have parameters (including pins). For now
we will drop library parameters belonging to any sub-components of a
symbol.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17048
2024-02-23 14:57:57 +00:00
Wayne Stambaugh
27911d9b5a
Fix crash when changing sheet file name that contains a highlighted net.
...
Performing a full connectivity rebuild after changing a sheet file name
ensures that there are no stale connectivity object pointers laying around.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/17011
2024-02-17 08:50:22 -05:00
Ian McInerney
206a631135
Ensure stream is valid before checking for Eagle XML tag
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16989
Fixes KICAD-7QQ
2024-02-16 11:14:10 +00:00
Marek Roszko
f894a41dc2
LIB_SYMBOL::IsMulti() seems to be wrong, use the iterate conditional as the multi-unit check instead
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16932
2024-02-16 00:18:05 -05:00
Marek Roszko
9e08e6e4f1
USe setactive in cli in the LoadSchematic helper too
2024-02-16 00:08:10 -05:00
Jon Evans
7b0bb59b37
Remove hard-coded versioned env vars in most places
2024-02-15 15:31:08 +00:00
Seth Hillbrand
0775d1364a
Add bezier icon
...
Fixes https://gitlab.com/kicad/code/kicad/issues/16830
2024-02-14 02:01:01 +01:00
Marek Roszko
f73d45b0cf
Add $schema prop to drc/erc
2024-02-13 19:08:55 -05:00
Mike Williams
c92728715d
Schematic: import schematic sheet content, allow move and undo
...
Otherwise, the schematic is just plopped on the screen, causing
connections and junctions to be missing that should be present.
2024-02-13 12:18:46 -05:00
Jeff Young
12c8f5b14d
Update compatibility mode and save flags in ngspice.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16955
2024-02-13 14:50:15 +00:00
Marek Roszko
2afe4db945
Add some missing newlines in cli output without changing strings
2024-02-11 21:12:21 -05:00
Marek Roszko
6a37f99e94
Fix crash if we exit lib table setup
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16917
2024-02-11 21:05:23 -05:00
Marek Roszko
d694bb5960
Use file name rather than path for erc/drc json and text reports
2024-02-11 20:16:22 -05:00
Alex
b5982f7319
EasyEDA import: force close some line chains.
2024-02-11 23:52:56 +03:00
Alex
bf9d085c15
EasyEDA schematic import: fix nan center for elliptic arcs.
2024-02-11 23:52:56 +03:00
Jon Evans
22669bcc4d
Unselect saved image when reverting a commit if modified item is unselected
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16938
2024-02-11 11:55:02 -05:00
Jon Evans
ec2cd99405
Guard actions that change project against running in non-standalone mode
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16942
2024-02-11 09:36:17 -05:00
Jon Evans
ef0204a44b
Remove debug output
2024-02-11 09:04:10 -05:00
Jon Evans
4eba781013
Try harder to remove stale pins from connectivity
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 23:26:37 -05:00
Graham Keeth
24cf0c0c62
use new align-to-grid icon
2024-02-11 01:30:47 +00:00
Wayne Stambaugh
e302261067
More issue #16846 invalid pointer checks.
...
This has now pushed the issue down to a broken RTree issue. Skipping the
asserts in debug builds will still crash but now it's pushed down to the
RTree.
2024-02-10 15:41:10 -05:00
Wayne Stambaugh
b409aee28a
Force schematic symbol pin update when reverting a commit.
...
Apparently somewhere in our schematic code base we are allowing pins
to be added to symbols without correct setting the parent symbol object.
This causes all kinds of issues when the pin's parent object need to be
accessed.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-10 08:49:41 -05:00
Wayne Stambaugh
ae9175927b
Fix broken schematic pin selection caused by commit 1ac5666164
.
2024-02-10 08:26:52 -05:00
Alex Shvartzkop
ff17a22e31
Internationalize Image Properties dialogs.
2024-02-10 08:34:19 +03:00
Marek Roszko
d3ca82b0b5
Fix another build error
2024-02-09 20:18:13 -05:00
Seth Hillbrand
cd548e392a
Add document type icons
...
Update Macos script to use doctype icons for icns builds
Fixes https://gitlab.com/kicad/code/kicad/-/issues/14754
2024-02-09 15:55:57 -08:00
Seth Hillbrand
f303996f9c
Add new icons for tools
...
Align elements to grid
Cleanup graphics
Cleanup tracks/vias
Drag
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16206
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16205
2024-02-09 15:55:57 -08:00
Wayne Stambaugh
04ccf7e885
Explicitly create wxStrings for assignment to make MSVC builds happy.
2024-02-09 17:37:36 -05:00
Wayne Stambaugh
9e9ee96181
Explicitly create wxString for return value.
2024-02-09 17:11:49 -05:00
Jeff Young
dc48af3e5c
EDA_ITEM::SwapData() must not swap the parent pointer.
...
The image's parent pointer might have gone out of scope.
2024-02-09 20:10:12 +00:00
Wayne Stambaugh
302038fbfd
Do not assume schematic child objects have a valid parent.
2024-02-09 13:16:07 -05:00
Wayne Stambaugh
1ac5666164
Do not de-reference null library pin object pointers in SCH_PIN object.
2024-02-09 11:07:04 -05:00
Wayne Stambaugh
3d690da305
Fix schematic editor crash when dragging symbols.
...
Do not set view items or update connectivity until after commit changes
are updated in the SCH_SREEN. Updating the screen can force LIB_SYMBOL
changes which and lead to stale LIB_PIN object pointers stored in SCH_PIN
objects.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16846
2024-02-09 10:38:29 -05:00
Jeff Young
aef6b2a66e
nullptr safety and a bit of wxT'ing.
2024-02-09 13:56:01 +00:00
Jon Evans
334b414826
Make sure SCH_PIN->LIB_PIN pointers get cleared
2024-02-09 08:09:19 -05:00
Jeff Young
3c45145401
Set move flags at beginning of move.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16891
2024-02-09 10:19:39 +00:00
Jon Evans
ca6b40ef1c
Make sure to create power axis when restoring state
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16912
2024-02-08 17:48:12 -05:00
Jeff Young
f8b8bc78bd
Make m_originalColWidths impervious to init-order issues.
2024-02-08 15:09:07 +00:00
Jeff Young
b4c361f5cc
Order matters in PEGTL grammar.
...
(Because a flagParam will also match "param", but not the
other way around.)
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16900
2024-02-08 14:54:54 +00:00
Mike Williams
1a91bb369c
SCH<->PCB: fix pin cross probing
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16910
2024-02-08 09:02:03 -05:00
Jeff Young
8efd90e6e8
Allow reading of 0 text sizes.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16902
2024-02-07 16:46:42 +00:00
Jeff Young
bce372c8a3
Don't clear the undo/redo list when we're just trimming it.
...
We only allow a certain number of commands on the lists
and trim them when they overflow. PCB_BASE_EDIT_FRAME and
PL_EDITOR_FRAME implemented this correctly; SCH_EDIT_FRAME
and SYMBOL_EDIT_FRAME did not.
2024-02-07 14:52:10 +00:00
Alex
e55a803572
Altium schematic import: do not overwrite sheet name.
2024-02-07 05:06:49 +03:00
Alex
a32d5174a1
Altium schematic import: clear harness port list after parsing Additional.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16894
2024-02-07 05:06:49 +03:00
Alex Shvartzkop
65c0a0a629
ConvertImageToPolygons: fix images with no alpha.
...
Fixes KICAD-714
2024-02-06 21:38:00 +03:00
Marek Roszko
08b02f2a1a
Add junction color property
2024-02-05 19:12:09 -05:00
Marek Roszko
899ed59f7b
Add missing pin numbers/names properties
2024-02-05 19:08:56 -05:00
Alex Shvartzkop
0778a7d46d
Fix Windows build.
2024-02-06 00:38:21 +03:00
Alex Shvartzkop
be1bbda8ce
Altium: Fix bug when symbol uses multiple display modes on one sheet.
2024-02-05 22:36:30 +03:00
Alex Shvartzkop
d8c72e845c
Altium schematic: support component's DISPLAYMODE being a string.
2024-02-05 22:36:25 +03:00
Jeff Young
82e353deb7
Notify property inspector after sheet properties dialog.
2024-02-05 19:10:22 +00:00
Jeff Young
1ff36f23b8
Clean up stale TODOs.
2024-02-05 15:49:57 +00:00
Jeff Young
da46a96623
Update a few strings based on new string freeze policy.
2024-02-05 15:49:57 +00:00
Mike Williams
6a9914bf89
Lib Symbol Properties: make exclude from BOM string same as symbol props
...
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/16876
2024-02-05 09:02:46 -05:00
Andre Iwers
a0c39715df
HTTP LIB - Fine tuning
2024-02-05 12:11:01 +00:00
Marek Roszko
c39e7b2225
Tweaks in eeschema for hidpi
2024-02-05 01:03:52 -05:00
Wayne Stambaugh
92c2ddf77a
Do not parent dialogs to non top level windows in panels or widgets.
2024-02-03 10:40:28 -05:00
Emile Cormier
b58f318d3f
Add volume to IBIS cache path
...
Fixes #16655
2024-02-03 09:35:36 +00:00
Jeff Young
7cc663ad77
Schematic parity checking for CLI DRC.
2024-02-02 23:05:37 +00:00
Wayne Stambaugh
2b1bf369f2
Do not parent file or directory dialogs to panels.
...
Parenting dialogs to child windows of top level windows is most likely
not defined behavior. It's also likely that this behavior varies across
platforms so it' best not to risk doing it. wxWidgets does not check if
the dialog parent is actually a top level window. There may be other
places we are doing this with our message dialogs so we should do an
audit.
2024-02-02 09:20:36 -05:00
ecorm
ff3288dab6
Add quotes around paths when KIBIS generates waveforms via ngspice
...
Fixes #16655
2024-02-01 17:20:16 +00:00
jean-pierre charras
e8f51b61a6
EEschema, net navigator: save settings when closing Eeschema.
...
Fixes #16845
https://gitlab.com/kicad/code/kicad/-/issues/16845
2024-02-01 12:53:33 +01:00
Ma Han
7c6ee16b22
removed the dots for several strings in the settings dialog
...
https://gitlab.com/kicad/code/kicad/-/issues/16651
2024-02-01 08:52:57 +00:00
Seth Hillbrand
7664c345e2
Revert "Schematic performance enhancements"
...
This reverts commit df654ac12f
.
2024-02-01 09:00:13 +01:00
Yon Uriarte
df654ac12f
Schematic performance enhancements
2024-02-01 02:28:09 +00:00
Wayne Stambaugh
466c707e91
Check for invalid library pin object pointer.
2024-01-31 12:17:11 -05:00
Roberto Fernandez Bautista
079478f989
EDA_ANGLE: use constexpr for constant angles
...
Remove all statics in the class and instead use constexpr to
ensure correct ordering
2024-01-31 19:17:46 +03:00
Alex Shvartzkop
6ff3b0eb95
Altium schematic: remove border from symlib ellipse inner polygon.
2024-01-31 19:08:36 +03:00
Alex Shvartzkop
7f29ac39d8
Altium schematic: case-insensitive search for subsheet files.
...
Also fixes open polylines on sheet.
Also prevents adding polylines with less than 2 points.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16829
2024-01-31 17:57:10 +03:00
jean-pierre charras
d012a5cbe0
Eeschema menubar, view menu: group Show/Hide Net Navigator with other Show/hide menus
2024-01-31 12:40:21 +01:00
Alex Shvartzkop
1e5b68cb87
Altium schematic: add polygon inside filled ellipse.
2024-01-31 09:34:36 +03:00
Alex
6225ef69b6
Altium schematic import: fix power ports.
...
Use different symbol names for different port port styles.
Also fixes curved shapes construction.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16823
2024-01-31 08:22:27 +03:00
Alex
c64b74918f
Altium schematic import: put Template items on sheet.
...
So we can use variable resolution.
2024-01-31 07:00:02 +03:00
Alex
9ed735ef5d
Fixes for Altium/CircuitStudio schematic import
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16825
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16824
Adds support for Templates.
Also fixes symbols on schematic with multiple display modes.
2024-01-31 02:07:06 +03:00
jean-pierre charras
a3e6e08d92
Spice Simulator : update simulation after tuning cursor moved by arrow keys.
...
Fixes #16808
https://gitlab.com/kicad/code/kicad/-/issues/16808
2024-01-30 15:57:46 +01:00
Jeff Young
94cb00392e
Repair connectivity if bus aliases changed.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16503
2024-01-30 14:16:55 +00:00
Jeff Young
b77709bb4d
Formatting.
2024-01-30 14:03:38 +00:00
Jeff Young
ee5e2e56c0
Naming conventions; no functional changes.
2024-01-29 16:00:06 +00:00
Jeff Young
00aed2aa3e
Don't attempt to test for recursion on unsaved file.
...
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16722
2024-01-28 15:37:08 +00:00
Wayne Stambaugh
92308698ba
Coding policy fixes.
2024-01-28 09:26:46 -05:00
Wayne Stambaugh
2f0337974b
Update schematic connectivity when redoing changes.
...
Apparently we forgot to handle schematic connectivity changes when redoing
undone changes. The same connectivity update logic that was added to the
commit object is now used in SCH_EDIT_FRAME::PutDataInPreviousState().
Please note the granularity of connectivity rebuilds on schematic object
property changes is at the object level which is overly aggressive. This
means that connectivity rebuilds will happen when connectivity changes
that have nothing to do with and objects connectivity are changed. Until
objects can handle their own connectivity state, this will have to suffice.
2024-01-27 12:02:53 -05:00
Jeff Young
c0cbaa4c53
Finish earlier commit that somehow escaped my notice.
...
(String is existing.)
2024-01-27 15:55:05 +00:00
Jeff Young
d2f0acae6b
Expose pin visibility to property manager.
...
Also re-orders properties in Pin Properties dialog order.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16785
2024-01-27 15:52:59 +00:00
jean-pierre charras
ad1a929404
Do not mark an empty string as translatable
...
It is not accepted by our tools
2024-01-27 09:06:03 +01:00