# # This program source code file is part of KICAD, a free EDA CAD application. # # Copyright (C) 2007-2020 Kicad Developers, see AUTHORS.txt for contributors. # # This program is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License # as published by the Free Software Foundation; either version 2 # of the License, or (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program; if not, you may find one here: # http://www.gnu.org/licenses/old-licenses/gpl-2.0.html # or you may search the http://www.gnu.org website for the version 2 license, # or you may write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA # # Only configure warnings for Clang and GCC if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" ) # The SWIG-generated files tend to throw a lot of warnings, so # we do not add the warnings directly to the flags here but instead # keep track of them and add them to the flags later in a controlled manner # (that way we can not put any warnings on the SWIG-generated files) set( COMPILER_SUPPORTS_WARNINGS TRUE ) # Establish -Wall early, so specialized relaxations of this may come # subsequently on the command line, such as in pcbnew/github/CMakeLists.txt set( WARN_FLAGS_C "-Wall" ) set( WARN_FLAGS_CXX "-Wall" ) # Warn about missing override specifiers CHECK_CXX_COMPILER_FLAG( "-Wsuggest-override" COMPILER_SUPPORTS_WSUGGEST_OVERRIDE ) if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsuggest-override" ) message( STATUS "Enabling warning -Wsuggest-override" ) endif() # This is Clang's version of -Wsuggest-override CHECK_CXX_COMPILER_FLAG( "-Winconsistent-missing-override" COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE ) if( COMPILER_SUPPORTS_WINCONSISTENT_MISSING_OVERRIDE ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Winconsistent-missing-override" ) # Also use this to guard warning removal of the warning inside the code set( HAVE_WINCONSISTENT_MISSING_OVERRIDE true ) message( STATUS "Enabling warning -Winconsistent-missing-override" ) endif() # Warn on duplicated branches CHECK_CXX_COMPILER_FLAG( "-Wduplicated-branches" COMPILER_SUPPORTS_WDUPLICATED_BRANCHES ) if( COMPILER_SUPPORTS_WDUPLICATED_BRANCHES ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-branches" ) message( STATUS "Enabling warning -Wduplicated-branches" ) endif() # Warn on duplicated conditions CHECK_CXX_COMPILER_FLAG( "-Wduplicated-cond" COMPILER_SUPPORTS_WDUPLICATED_COND ) if( COMPILER_SUPPORTS_WDUPLICATED_COND ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wduplicated-cond" ) message( STATUS "Enabling warning -Wduplicated-cond" ) endif() # Error on variable length arrays (gcc extension) CHECK_CXX_COMPILER_FLAG( "-Wvla" COMPILER_SUPPORTS_WVLA ) if( COMPILER_SUPPORTS_WVLA ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=vla" ) message( STATUS "Enabling error for -Wvla" ) endif() # Warn on implicit switch fallthrough CHECK_CXX_COMPILER_FLAG( "-Wimplicit-fallthrough" COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH ) if( COMPILER_SUPPORTS_WIMPLICIT_FALLTHROUGH ) if( CMAKE_COMPILER_IS_GNUCXX ) # GCC level 5 does not allow comments - mirrors the Clang warning set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough=5" ) else() set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wimplicit-fallthrough" ) endif() message( STATUS "Enabling warning -Wimplicit-fallthrough" ) endif() # Error if there is a problem with function returns CHECK_CXX_COMPILER_FLAG( "-Wreturn-type" COMPILER_SUPPORTS_WRETURN_TYPE ) if( COMPILER_SUPPORTS_WRETURN_TYPE ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Werror=return-type" ) message( STATUS "Enabling error for -Wreturn-type" ) endif() # Warn about shadowed variables CHECK_CXX_COMPILER_FLAG( "-Wshadow" COMPILER_SUPPORTS_WSHADOW ) if( COMPILER_SUPPORTS_WSHADOW ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wshadow" ) message( STATUS "Enabling warning -Wshadow" ) endif() # Add additional warning flags to avoid signed/unsigned comparison CHECK_CXX_COMPILER_FLAG( "-Wsign-compare" COMPILER_SUPPORTS_WSIGN ) if( COMPILER_SUPPORTS_WSIGN ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsign-compare" ) message( STATUS "Enabling warning -Wsign-compare" ) endif() # Warn about missing initializers in construction CHECK_CXX_COMPILER_FLAG( "-Wmissing-field-initializers" COMPILER_SUPPORTS_WMISSING_INIT ) if( COMPILER_SUPPORTS_WMISSING_INIT ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmissing-field-initializers" ) message( STATUS "Enabling warning -Wmissing-field-initializers" ) endif() # Warn about empty if/for/while bodies CHECK_CXX_COMPILER_FLAG( "-Wempty-body" COMPILER_SUPPORTS_WEMPTY_BODY ) if( COMPILER_SUPPORTS_WEMPTY_BODY ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wempty-body" ) message( STATUS "Enabling warning -Wempty-body" ) endif() # Warn about out of order intialization CHECK_CXX_COMPILER_FLAG( "-Wreorder" COMPILER_SUPPORTS_WREORDER ) if( COMPILER_SUPPORTS_WREORDER ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wreorder" ) message( STATUS "Enabling warning -Wreorder" ) endif() # Warn about mismatched class/struct declarations CHECK_CXX_COMPILER_FLAG( "-Wmismatched-tags" COMPILER_SUPPORTS_WMISMATCHED_TAGS ) if( COMPILER_SUPPORTS_WMISMATCHED_TAGS ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wmismatched-tags" ) message( STATUS "Enabling warning -Wmismatched-tags" ) endif() # See if the compiler will throw warnings on these conversions CHECK_CXX_COMPILER_FLAG( "-Wimplicit-int-float-conversion" COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION ) if( COMPILER_SUPPORTS_WIMPLICIT_FLOAT_CONVERSION ) # This one is different, it is used to guard warning removal for this inside the code set( HAVE_WIMPLICIT_FLOAT_CONVERSION true ) endif() # Suppress GCC warnings about unknown/unused attributes (e.g. cdecl, [[maybe_unused, etc) if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-attributes" ) endif() # Avoid ABI warnings, specifically one about an ABI change on ppc64el from gcc5 to gcc 6. CHECK_CXX_COMPILER_FLAG( "-Wpsabi" COMPILER_SUPPORTS_WPSABI ) if( COMPILER_SUPPORTS_WPSABI ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wno-psabi" ) message( STATUS "Disabling warning -Wpsabi" ) endif() # Append any additional warning flags so the end of the warning string if( KICAD_ADDITIONAL_WARN_FLAGS ) set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} ${KICAD_ADDITIONAL_WARN_FLAGS}" ) message( STATUS "Adding additional warning flags: ${KICAD_ADDITIONAL_WARN_FLAGS}") endif() endif()