From 7b1984b7bccd7f4a4f7f96a32d5bdadf337cb20d Mon Sep 17 00:00:00 2001
From: Thomas Refis <thomas.refis@gmail.com>
Date: Wed, 16 Oct 2013 10:18:44 +0200
Subject: [PATCH 1/2] extend typeof directive

---
 src/lib/uTop_main.ml | 69 +++++++++++++++++++++++++++++++++++---------
 1 file changed, 56 insertions(+), 13 deletions(-)

diff --git a/src/lib/uTop_main.ml b/src/lib/uTop_main.ml
index a79ed44..c4fc456 100644
--- a/src/lib/uTop_main.ml
+++ b/src/lib/uTop_main.ml
@@ -934,29 +934,72 @@ end
 
 #if ocaml_version > (4, 00, 1)
 
-let typeof id =
+let typeof sid =
+  let id  = Longident.parse sid in
   let env = !Toploop.toplevel_env in
-  match try Some (Env.lookup_type id env) with Not_found -> None with
-  | Some (path, ty_decl) ->
-    let id = Ident.create (Path.name path) in
-    let osig =
-      Printtyp.wrap_printing_env env
-        (fun () ->
-          Printtyp.tree_of_type_declaration id ty_decl Types.Trec_not)
-    in
+  let from_type_desc = function
+    | Types.Tconstr (path, _, _) ->
+      let typ_decl = Env.find_type path env in
+      path, typ_decl
+    | _ -> assert false
+  in
+  let out_sig_item =
+    try
+      let (path, ty_decl) = Env.lookup_type id env in
+      let id = Ident.create (Path.name path) in
+      Some (Printtyp.tree_of_type_declaration id ty_decl Types.Trec_not)
+    with Not_found ->
+    try
+      let (path, val_descr) = Env.lookup_value id env in
+      let id = Ident.create (Path.name path) in
+      Some (Printtyp.tree_of_value_description id val_descr)
+    with Not_found ->
+    try
+      let lbl_desc = Env.lookup_label id env in
+      let (path, ty_decl) = from_type_desc lbl_desc.Types.lbl_res.desc in
+      let id = Ident.create (Path.name path) in
+      Some (Printtyp.tree_of_type_declaration id ty_decl Types.Trec_not)
+    with Not_found ->
+    try
+      let (path, mod_typ) = Env.lookup_module id env in
+      let id = Ident.create (Path.name path) in
+      Some (Printtyp.tree_of_module id mod_typ Types.Trec_not)
+    with Not_found ->
+    try
+      let (path, mty_decl) = Env.lookup_modtype id env in
+      let id = Ident.create (Path.name path) in
+      Some (Printtyp.tree_of_modtype_declaration id mty_decl)
+    with Not_found ->
+    try
+      let cstr_desc = Env.lookup_constructor id env in
+      match cstr_desc.Types.cstr_tag with
+      | Types.Cstr_exception (_path, loc) ->
+        let path, exn_decl = Typedecl.transl_exn_rebind env loc id in
+        let id = Ident.create (Path.name path) in
+        Some (Printtyp.tree_of_exception_declaration id exn_decl)
+      | _ ->
+        let (path, ty_decl) = from_type_desc cstr_desc.Types.cstr_res.desc in
+        let id = Ident.create (Path.name path) in
+        Some (Printtyp.tree_of_type_declaration id ty_decl Types.Trec_not)
+    with Not_found ->
+      None
+  in
+  match out_sig_item with
+  | None ->
+    Lwt_main.run (Lazy.force LTerm.stdout >>= fun term ->
+                  print_error term "Unknown type\n")
+  | Some osig ->
     let buf = Buffer.create 128 in
     let pp = Format.formatter_of_buffer buf in
     !Toploop.print_out_signature pp [osig];
     Format.pp_print_newline pp ();
     let str = Buffer.contents buf in
     Lwt_main.run (Lazy.force LTerm.stdout >>= fun term -> render_out_phrase term str)
-  | None ->
-    Lwt_main.run (Lazy.force LTerm.stdout >>= fun term ->
-                  print_error term "Unknown type\n")
+
 
 let () =
   Hashtbl.add Toploop.directive_table "typeof"
-    (Toploop.Directive_ident typeof)
+    (Toploop.Directive_string typeof)
 
 #endif
 

From 7d56719b15701a3f63d2687eab2bb37c892a2f08 Mon Sep 17 00:00:00 2001
From: Thomas Refis <thomas.refis@gmail.com>
Date: Wed, 16 Oct 2013 14:33:02 +0200
Subject: [PATCH 2/2] add completion on typeof directive

---
 src/lib/uTop_complete.ml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/src/lib/uTop_complete.ml b/src/lib/uTop_complete.ml
index af88b69..f73c766 100644
--- a/src/lib/uTop_complete.ml
+++ b/src/lib/uTop_complete.ml
@@ -813,6 +813,20 @@ let complete ~syntax ~phrase_terminator ~input =
         let pkgs = lookup pkg (Fl_package_base.list_packages ()) in
         (loc.idx1 + 1, List.map (fun pkg -> (pkg, "\"" ^ phrase_terminator)) (List.sort compare pkgs))
 
+    | [(Symbol "#", _); (Lident "typeof", _); (String false, loc)] ->
+      let prefix = String.sub input (loc.ofs1 + 1) (String.length input - loc.ofs1 - 1) in
+      begin match Longident.parse prefix with
+      | Longident.Ldot (lident, last_prefix) ->
+        let set = names_of_module lident in
+        let compls = lookup last_prefix (String_set.elements set) in
+        let start = loc.idx1 + 1 + (String.length prefix - String.length last_prefix) in
+        (start, List.map (fun w -> (w, "")) compls)
+      | _ ->
+        let set = global_names syntax in
+        let compls = lookup prefix (String_set.elements set) in
+        (loc.idx1 + 1, List.map (fun w -> (w, "")) compls)
+      end
+
     (* Completion on #load. *)
     | [(Symbol "#", _); (Lident "load", _); (String false, loc)] ->
         let file = String.sub input (loc.ofs1 + 1) (String.length input - loc.ofs1 - 1) in