From a96baad0d7008b8c47bb26cdd17d20aeb470e239 Mon Sep 17 00:00:00 2001 From: Brian Cain Date: Tue, 13 Mar 2018 16:24:46 -0700 Subject: [PATCH] Add comments for later dev --- plugins/kernel_v2/config/trigger.rb | 1 + plugins/kernel_v2/config/vm_trigger.rb | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/kernel_v2/config/trigger.rb b/plugins/kernel_v2/config/trigger.rb index b486aaf55..6e77f225f 100644 --- a/plugins/kernel_v2/config/trigger.rb +++ b/plugins/kernel_v2/config/trigger.rb @@ -90,6 +90,7 @@ module VagrantPlugins end # Validate Trigger settings + # TODO: Validate not called if there are providers defined in vagrantfile def validate(machine) errors = _detected_errors @_before_triggers.each do |bt| diff --git a/plugins/kernel_v2/config/vm_trigger.rb b/plugins/kernel_v2/config/vm_trigger.rb index 7211bca88..72bccdd3a 100644 --- a/plugins/kernel_v2/config/vm_trigger.rb +++ b/plugins/kernel_v2/config/vm_trigger.rb @@ -114,12 +114,12 @@ module VagrantPlugins errors = _detected_errors commands = [] - # TODO: Should this be cached...? Vagrant.plugin("2").manager.commands.each do |key,data| commands.push(key) end if !commands.include?(@command) + # does this make sense to print on this machine? machine.ui.warn(I18n.t("vagrant.config.triggers.bad_command_warning", cmd: @command)) end