haskal
/
vagrant
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Provide a custom user agent header to cURL request so that URL shorteners are able to track the amount of downloads

This commit is contained in:
Fabio Rehm 2013-07-28 20:06:36 -03:00
parent e98e8bf9d7
commit c7aed1a6a1
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/vagrant/util/downloader.rb
View File

@ -9,6 +9,10 @@ module Vagrant
# to cURL. cURL is a much more capable and complete download tool than
# a hand-rolled Ruby library, so we defer to it's expertise.
class Downloader
# Custom user agent provided to cURL so that requests to URL shorteners
# are properly tracked.
USER_AGENT = "Vagrant cURL Downloader"
def initialize(source, destination, options=nil)
@logger = Log4r::Logger.new("vagrant::util::downloader")
@source = source.to_s
@ -32,6 +36,7 @@ module Vagrant
"--fail",
"--location",
"--max-redirs", "10",
"--user-agent", USER_AGENT,
"--output", @destination
]

4
test/unit/vagrant/util/downloader_test.rb
View File

@ -25,7 +25,7 @@ describe Vagrant::Util::Downloader do
let(:exit_code) { 0 }
it "downloads the file and returns true" do
curl_options = ["--fail", "--location", "--max-redirs", "10", "--output", destination, source, {}]
curl_options = ["--fail", "--location", "--max-redirs", "10", "--user-agent", described_class::USER_AGENT, "--output", destination, source, {}]
Vagrant::Util::Subprocess.should_receive(:execute).
with("curl", *curl_options).
@ -39,7 +39,7 @@ describe Vagrant::Util::Downloader do
let(:exit_code) { 1 }
it "raises an exception" do
curl_options = ["--fail", "--location", "--max-redirs", "10", "--output", destination, source, {}]
curl_options = ["--fail", "--location", "--max-redirs", "10", "--user-agent", described_class::USER_AGENT, "--output", destination, source, {}]
Vagrant::Util::Subprocess.should_receive(:execute).
with("curl", *curl_options).