6afb4326fa
Move NFS to a built-in middleware
2013-02-08 15:34:04 -08:00
36cdced052
Update wording on requiring a Vagrantfile [GH-1362]
2013-02-07 16:42:18 -08:00
d1b55e934c
Reword the port collision resume message to address general programs instead of just VMs
2013-02-07 19:07:10 +07:00
4a1a990491
Raise a proper SSH error on ECONNRESET
2013-02-06 18:08:55 -08:00
1b3250e3b6
`vagrant plugin i nstall` shows version it installed
2013-02-06 17:08:48 -08:00
1af3255559
Be more sane about cookbook_paths default in Chef
2013-02-05 22:02:12 -08:00
661ccef6e2
Clarify a plugin loading error that 1.0.x not supported
2013-02-05 09:10:06 -08:00
3304a7701c
Update the Vagrantfile template
2013-02-04 11:56:06 -08:00
55c905b43b
`vagrant plugin license` command.
2013-02-04 10:32:04 -08:00
635949980b
Handle the case a plugin install is a plugin not found
2013-02-03 14:29:29 -08:00
3df6088db0
Make plugin loading more robust to errors
2013-02-03 14:13:27 -08:00
1162c2dbfc
Instead of shelling out, use the RubyGems API to install plugins
...
This gets us an accurate name of the gem even if it is installed
from a file.
2013-02-03 13:59:43 -08:00
8cde263a14
Fix some locale stuff to `vagrant plugin`
2013-02-03 13:27:35 -08:00
455745277c
List plugins should have output when no plugins
2013-02-03 13:13:22 -08:00
9690754983
Plugin listing is a bit more sophisticated, shows version
2013-02-03 12:59:32 -08:00
0d7322578b
`vagrant plugin uninstall`
2013-02-03 10:47:32 -08:00
d404eee770
Make the bundler environment error more correct
2013-02-02 23:41:18 -08:00
fa50f06a4c
Error if RubyGems failed.
2013-02-02 23:31:53 -08:00
a2ef7790de
Start creating the plugin middleware sequences
2013-02-02 18:42:04 -08:00
b3571eb5bb
Add message about removing box so something is clearly happening
2013-02-02 16:43:16 -08:00
2dc14af825
`vagrant up` says what provider it will use
2013-02-01 14:03:59 -08:00
26adfb0de6
Put the provider name in the status output
2013-02-01 13:54:52 -08:00
165dd63f78
New HandleBoxUrl built-in middleware to handlet the "box_url" config
2013-02-01 11:31:08 -08:00
c8ae1a265a
Extra protection in the rgloader file
2013-01-31 19:54:50 -08:00
67c2e205be
Create rgloader/loader.rb files for encoded files
2013-01-31 18:48:56 -08:00
1392d9b4a5
Detect if a VM name is already taken for VirtualBox
2013-01-30 23:22:45 -08:00
9d2f26604e
Properly handle paused VirtualBox VMs [GH-1184]
2013-01-30 22:47:45 -08:00
c3bacf3e1d
Improved error message for bad SSH key encryption [GH-1211]
2013-01-30 22:26:30 -08:00
e5f8faeeea
Make error message for port collisions more correct [GH-1312]
2013-01-30 21:07:55 -08:00
c57ba9de58
Give a nice human-friendly error message when problems loading Vfile
2013-01-30 20:01:41 -08:00
51c537fca3
Merge pull request #1327 from samet/master
...
Patch to solve Issue 1322.
2013-01-29 11:01:35 -08:00
0d27cd5bcb
Warn if Vagrant is run outside of installers
2013-01-28 13:39:56 -08:00
e6a0023713
Switch to bsdtar for unpackaging a box
2013-01-28 13:01:43 -08:00
ca0af2866e
Change output to not include the name
2013-01-23 09:45:56 -08:00
4059a4ba2f
Define synced_folders on V2 vm config
2013-01-23 09:21:49 -08:00
8ad8f73846
Raise an exception if a non-MachineState is returned
2013-01-21 11:31:20 -06:00
4b5909d532
Private key path is put into quotes in case of space-including username.
2013-01-21 15:19:35 +02:00
2d57afbbda
Support warnings/errors when upgrading Vagrantfiles internally
2013-01-20 22:04:50 -05:00
7f55d5eac8
Builtin: ConfigValidate will validate your configuration
2013-01-18 13:26:14 -08:00
fff021e51d
Update Chef provisioner to new validation API
2013-01-18 13:12:02 -08:00
3e9e422ce0
Convert existing validate methods to new API for kernel
2013-01-18 12:33:37 -08:00
bae6555836
Remove DeprecationError
2013-01-18 12:23:29 -08:00
42a1ce6e9d
Remove the old config validation error
2013-01-18 12:15:36 -08:00
22571bf05b
Rescue the EHOSTDOWN error for SSH
2013-01-12 12:47:49 -08:00
48eaa93745
Raise proper error if there aren't any NIC slots available
2013-01-11 15:57:08 -08:00
07157b47ae
Only allow one provider active machine at a time.
...
Temporary limitation of Vagrant to only allow one active machine with a
provider at a time. That means you cant `up` a machine with both vmware
and virtualbox at the same time. In the future you will be able to but
to avoid various edge cases for now we're disallowing it.
2012-12-30 10:52:01 -10:00
4e649cc987
Upgrade V1-style dotfile to V2
...
See the code and comments for details on how this is done. As usual, we
are very careful about this so as not to inadvertently destruct real
user data.
2012-12-26 22:41:42 -08:00
cc18492c7a
Local data path introduced
...
The local data path is set to the `ROOT_DIR/.vagrant` by default and is
a directory where Vagrant can store environment-local state. This can be
overriden on a per-Environment basis using the `local_data_path`
option.
2012-12-26 21:45:23 -08:00
54a2f6b89e
Change boot_mode to a provider config `gui`.
...
OLD:
config.vm.boot_mode = :gui
NEW:
config.vm.provider :virtualbox do |vb|
vb.gui = true
end
2012-12-25 09:00:06 -08:00
2cfc5986d2
Wording changes in the status command. VM => machine
2012-12-24 10:00:28 -08:00
94ce12683e
Show node name in logging
2012-12-17 11:58:15 -05:00
370d6b0c98
Delete Chef client and node on cleanup
...
This fixes #1253 by shelling out to `knife` on cleanup, as per
@mitchellh's suggestion in #1255
2012-12-17 11:49:27 -05:00
67855be77b
Add the Environment#machine method
...
This will eventually replace the Environment#vms method. Because of the
introduction of providers, the environment doesn't know what the backing
of the machines will be (and they're _machines_ now, not _vms_).
Instead, users of Environment will now call `#machine` on the
environment to retrieve a machine with the given backing provider as it
needs it.
2012-11-07 21:45:09 -08:00
3e6fe7406b
Update the Vagrantfile template to use V2 by default.
2012-11-06 21:34:22 -08:00
d2625d0efa
Update some translations
2012-09-27 14:00:20 -07:00
b2585b8ede
Merge pull request #1048 from spk/locales
...
Locales
2012-09-27 13:58:00 -07:00
1cbdbf4b0c
Merge pull request #1071 from bcwaldon/confirm-opt-default
...
Convey default destroy confirmation choice as 'N'
2012-09-09 20:34:50 -07:00
7158445c2d
Error message on ECONNRESET for box downloading via HTTP [GH-1090]
2012-09-09 20:16:43 -07:00
46feb55396
Add missing "saving" transition for VirtualBox machine [GH-1110]
2012-09-09 19:49:03 -07:00
dcc36322f2
Convey default destroy confirmation choice as 'N'
...
The convention is to capitalize the default choice when presenting
the user with a confirmation dialog. This alters the choices for
'vagrant destroy' confirmation from [Y/N] to [y/N].
2012-08-15 14:01:09 -04:00
db11c16b79
ssh_config works with new machine abstraction
2012-08-13 19:48:26 -07:00
28f341ec75
Begin working on the #guest method for Machine instances
2012-08-12 16:46:00 -07:00
b1ced46d7c
SSHExec raises proper exception if SSH is not yet ready
2012-08-06 10:29:25 -07:00
8aeb02992e
Added already_exists locale.
2012-07-27 23:43:51 +02:00
b739887116
Added untar_failure locale.
2012-07-27 21:57:13 +02:00
8f0375d7f3
Machines can call actions on their providers.
2012-07-16 14:12:58 -07:00
6bb621026f
`vagrant box add` uses the new API.
...
This assumes VirtualBox boxes for now, which is fine.
2012-07-11 18:36:22 -07:00
9cb0015b6e
Test that an added box provider must match expected.
2012-07-11 18:36:21 -07:00
9d1924811e
Box collection can detect V1 boxes and throws an exception
...
The exception notifies the caller that the box needs to be upgraded. The
upgrade process is not yet done but is coming ina future commit.
2012-07-11 18:36:20 -07:00
61621369d2
Catch Net::SSH::Disconnect when connecting to SSH
...
This error was experienced by @pearkes. It is thrown when the remote end
unexpectedly closes the remote end. This is usually caused by SSH not
being able to properly setup the connection.
2012-07-04 08:26:09 -10:00
639a6a72ed
Don't set the gateway for host only, this sometimes causes internet
...
breakge
2012-06-29 12:05:42 -07:00
0b3e703498
Add the gateway to hostonly network interfaces on Debian [GH-990]
2012-06-27 11:18:23 -07:00
53d8c28c8e
Move guests to Vagrant.plugin("1", :guest)
2012-06-26 16:28:49 -07:00
2e00a007ce
Move provisioner superclass into the V1 namespace
2012-06-26 15:06:04 -07:00
635920e56e
Small error message fix.
2012-06-25 16:13:18 -04:00
fa99eb7e54
Check for permission denied when using SCP to upload [GH-924]
2012-06-22 21:04:21 -07:00
a46640c720
Fixes minor typo
2012-06-20 11:16:29 +03:00
5bbabaf5a5
Fix multiple ethernet interface support on Arch Linux
2012-06-01 14:23:15 +02:00
1ef679f683
SSH log level fatal. Thanks @petejkim
...
This change makes it so that SSH errors are shown, whereas QUIET hid
those as well. The main change to QUIET was to get rid of warnings,
not errors, so this fixes that.
2012-05-31 23:42:28 +02:00
268b13b799
Merge pull request #947 from justinlynn/add_dhcp_default_route_option
...
add workaround for ubuntu precise not properly loading routes from dhcp
2012-05-25 08:42:52 -07:00
736ed6b590
add workaround for ubuntu precise not properly loading routes
2012-05-24 11:53:46 -07:00
3204b3a580
Vagrant.configure and versioned configuration
...
Vagrant.configure is now how configuration is done in Vagrantfiles
(previously it was Vagrant::Config.run). This function takes a single
argument which is the version of configuration to use.
Various internals were updated for this new versioned configuration.
Note that multiple versions of configuration aren't yet used so aren't
fully supported by Vagrant, but the foundation is being set here.
2012-05-21 21:47:01 -07:00
d3686465db
Avoid `unless`
2012-05-06 14:47:52 -07:00
73c8299ecd
Merge pull request #868 from justinlynn/add_dhcp_default_route_option
...
Issue #862 : Allow bridged networking without removing the interface's DHCP assigned default route
2012-05-06 14:46:58 -07:00
bc0643613a
Vagrant.require_plugin [GH-916]
2012-05-06 14:01:10 -07:00
bf3d3b0245
add use_dhcp_assigned_default_route setting to allow for dhcp bridged interfaces which have a default route assigned by dhcp
2012-04-05 09:21:09 -07:00
e98cedf0e1
LogLevel QUIET for SSH to suppress known hosts warning [GH-847]
2012-04-02 09:57:16 -07:00
db6cd14f9e
Detect when the VirtualBox installation is incomplete and error
2012-03-30 19:29:39 -07:00
9f6bc9ee03
Catch Errno::ETIMEDOUT for downloading boxes [GH-849]
2012-03-30 19:28:10 -07:00
2ed6695f78
Improve the SSH ready? check [GH-841]
2012-03-28 22:30:01 -07:00
bfe20a223f
Fail fast if the VM fails to boot properly. [GH-825]
2012-03-25 10:00:27 -07:00
a1b16fd96d
Merge pull request #816 from Oakie3CR/chef-solo-encrypted-databags
...
Add encrypted data bag options to chef-solo
2012-03-23 06:21:36 -07:00
ab926ed5f4
Adds chef.roles_path and chef.data_bags_path to template
2012-03-21 10:44:41 -04:00
b4e24c91f5
Add encrypted databag options to chef-solo
2012-03-13 16:27:11 -06:00
3ff4be3632
Nicer error for unsupported SSH key type [GH-805]
2012-03-13 14:27:16 -07:00
7fe39b61bc
Add missing translation for paused state
...
After pausing VM via VirtualBox directly when running 'vagrant status'
the error 'translation missing: en.vagrant.commands.status.paused' surfaces.
This patch adds a (hopefully) useful translation for this translation key.
2012-03-10 14:16:26 -06:00
3046845215
Show nice error if vagrant destroy can't confirm [GH-779]
2012-03-07 22:35:40 -08:00
95b3e9f82f
UI errors if a TTY is required and not given
2012-03-07 22:32:44 -08:00
9990311f20
Added Fedora 16 handling.
2012-03-04 18:42:37 -05:00
0f63171a4d
Support for bridged networks in FreeBSD
2012-02-23 18:06:40 -08:00
af884e4b74
Add the missing translation for guru meditatin. [GH-745]
2012-02-18 20:00:08 -08:00
034477b52a
Add `fsid` to linux exports for NFS. [GH-736]
2012-02-14 23:08:32 -08:00
5c49d693d4
You can no longer output a package to a directory [GH-730]
2012-02-10 17:57:40 -08:00
ae62c9bd68
Convert example host only IPs to RFC1918
2012-02-08 14:50:33 -08:00
6ed6c0c085
`destroy` asks for confirmation. [GH-699]
2012-02-07 22:54:51 -08:00
a3d9615a13
Custom help for `vagrant gem` on top of RubyGems help
2012-02-06 22:52:34 -05:00
4444e7150c
`vagarnt gem` cannot be called within a bundler env
2012-02-06 22:22:28 -05:00
a6a42b31df
Ability to specify `:bridge` to networking [GH-655]
2012-02-04 15:04:28 +01:00
f2272fdba8
Fix missing interpolation argument. [GH-708]
2012-02-04 13:59:16 +01:00
2d327055f3
Do not allow BSD hosts to double-quote in exports
...
This is not allowed on *BSD
2012-01-30 19:52:59 -08:00
e1dbc7f9b1
Fix some puppet translation
2012-01-27 10:52:27 -08:00
0714c235fe
Add missing translation for chef binary missing [GH-687]
2012-01-27 10:50:25 -08:00
ce2ea4ea93
Error message when kernel module is not loaded for VirtualBox [GH-677]
2012-01-24 19:30:55 -08:00
9fce04c2cd
Test for the correct number of arguments to box add
2012-01-20 15:21:54 -08:00
be97cec8b5
Allow shell expansions in shared folder guest paths again [GH-656]
2012-01-19 20:14:05 -08:00
ac48d270eb
Error if :vagrant is used as chef JSON key. [GH-661]
2012-01-19 19:48:57 -08:00
f4ea1f800c
Update Arch guest to the new networks API
2012-01-17 11:25:40 -08:00
3a2546907e
Update Gentoo guest to new networks API
2012-01-17 11:17:12 -08:00
3456bfd2fe
Warn user we're pruning exports
2012-01-12 23:33:17 -08:00
829f64406e
Add `attempts` to chef provisioners. [GH-282]
2012-01-12 23:10:30 -08:00
5630dc144d
Fix up NFS to use the new VirtualBox drivers
2012-01-12 22:19:23 -08:00
6d212efdbd
Fix ppk path by just... not using ppk anymore. [GH-634]
2012-01-12 18:03:35 -08:00
fc7111734b
Clean up the Puppet provisioner a bit
2012-01-11 09:56:33 -08:00
73bff1b457
Fix up puppet provisioner a bit
2012-01-11 09:48:18 -08:00
eaf6ce7372
Verify shared folders for puppet
2012-01-11 09:29:30 -08:00
cb6020869f
Prompt for `reload` if shared folders aren't setup for Chef [GH-253]
2012-01-10 22:36:39 -08:00
fe012e800f
Printing help due to invalid options should have error exit status
2012-01-10 20:30:18 -08:00
ef37f692bd
Revert the check for duplicate Vagrantfiles.
...
This is just tricky with case sensitive/insensitive file systems.
Reverting since it doesn't seem worth it.
2012-01-08 23:15:18 -08:00
8aa4e58ea8
Check for conflicting DHCP servers
2012-01-08 20:33:12 -08:00
ec9a6182a8
Update to Vagrantfile template. A name is not required for the forwarding port.
2012-01-08 20:10:37 -08:00
8c00d1d652
Raise an error if multiple matching Vagrantfiles are found [GH-588]
2012-01-08 11:54:32 -08:00
89eb256f9d
Proper error handling if the shared folder cannot be created [GH-604]
2012-01-08 11:29:52 -08:00
27372ef313
Namespace ssh-config template
2012-01-07 21:56:14 -08:00
acbc0d4b28
Namespace provisioner templates
2012-01-07 21:55:08 -08:00
d07f0f8dd2
Support VirtualBox 4.0
2012-01-07 21:16:40 -08:00
7fce25e858
Show `attempting graceful shutdown` message from action, not guest
2012-01-07 11:44:53 -08:00
0f580fd2c0
Re-use SSH connection
2012-01-07 11:38:27 -08:00
47a368fbfd
VM raises SSHPortNotDetected if ssh_info can't get the port
...
Also, I updated the wording on that error message a bit since it
turns out that it is possible through user error that there will
be no SSH port.
2012-01-06 20:07:31 -08:00
40a6dfaf9d
Locale formatting
2012-01-05 15:10:10 -08:00
46feef4f24
Make the error message when the VM is not running more clear
2012-01-05 15:09:41 -08:00
a04fce880c
Changes to enable rhel/centos-style bridged & hostonly networking
2012-01-04 21:39:36 -08:00
33551eca47
Delete default routes for bridged networking on coming up
2012-01-03 13:22:33 -08:00
a1b66f82aa
Consistently generate names for forwarded ports.
...
To do this, I convert the ports to base 32 strings in the format
of "guestport-hostport." This makes a consistent mapping we can use
to look up if the forwarded port is set.
2012-01-03 10:34:35 -08:00
2d1ed88bcd
Forwarded ports no longer require a name paramter
2012-01-03 10:22:42 -08:00
248f087578
Fix up wording for network error
2012-01-03 09:37:10 -08:00
ad6974d3da
Fix typo in Vagrantfile
2012-01-03 09:35:14 -08:00
7982f01f2e
Check for adapter collisions
2012-01-03 09:34:32 -08:00
20edb5d05a
Error if no available network adapters are found
2012-01-03 08:01:26 -08:00
ccd688593f
adding note to Vagrantfile template aobut bridged networking
2012-01-03 07:52:29 -08:00
09945fe4f9
Better documentation and error messages for unsupported guest features
2012-01-03 07:50:01 -08:00
97f7fa633d
Re-implement how networking is done internally
2012-01-02 19:51:38 -08:00
76a77432b8
Clear all network adapters during the boot process
2012-01-01 22:02:30 -08:00
22d042cb94
Vagrant now asks what adapter to bridge to
2012-01-01 00:05:47 -08:00
c48a31d6bd
Fix template paths for other guests
2011-12-31 19:08:56 -08:00
474ac3a63d
Enabling bridged networks on Debian
2011-12-31 11:53:04 -08:00
42883cbd20
Bridged networking basics.
2011-12-31 11:35:09 -08:00
b36e3c447e
Add a deprecation error for the old style of configuring host only networks
2011-12-30 23:39:16 -08:00
b5b3805157
Add validation once again for host only networks
2011-12-31 10:55:37 +09:00
4428daf344
A regex string can be passed to commands in Multi-VM
2011-12-26 18:12:02 -08:00
ad7f4c79ad
Make requiring a single VM target in a command more DRY
2011-12-26 17:59:18 -08:00
76f605f08d
Nice error message if port collisions are detected on `resume` [GH-602]
2011-12-25 09:48:49 -08:00
3eede78876
Get rid of 64-bit Windows error since it should work now
2011-12-22 12:51:20 -08:00
c42fe7ac6f
Update the error message shown if VBoxManage is not found
2011-12-22 12:49:45 -08:00
b7fce678e4
Make the non-NAT message one line to make things look better
2011-12-22 11:49:17 -08:00
4093e79027
Removed deprecation notice for chef_server to chef_client
2011-12-21 23:27:43 -08:00
ecbf7df859
Host only networks now work with VBoxManage
2011-12-21 22:27:06 -08:00
a3395f94ab
Catch and handle customization errors
2011-12-21 16:37:59 -08:00
e1d0ce19ce
Customizations are back in!
2011-12-21 16:25:58 -08:00
306945dd26
Nice error messages if VBoxManage command fails
2011-12-21 15:41:14 -08:00
48ea8173c6
Lots more VBoxManage
2011-12-21 13:37:59 -08:00
96868e5d29
Import and destroy work with the new driver interface
2011-12-20 21:20:45 -08:00
a8f5ed1863
Require vagrant environments for some commands.
2011-12-18 13:26:15 -08:00
a5052131df
Delete strings for unused command
2011-12-18 13:21:35 -08:00
98df762f8c
`vagrant init` uses new OptParse based CLI
2011-12-17 21:06:00 -08:00
5ae19f4782
Fix locale that referenced Vagrant::Systems::Base still
2011-12-15 21:08:12 -08:00
7157bd9cdb
Re-namespace messages for systems to the vagrant.guest
2011-12-15 21:07:43 -08:00
bfc8794d95
Update error output for systems to use the word "guest"
2011-12-15 20:56:19 -08:00
5fe50c8b5d
Change config.vm.system to config.vm.guest. Rename internals.
2011-12-15 20:55:16 -08:00
fd9b752938
Make host class available to all actions
2011-12-11 23:27:53 -08:00
98b8d858c4
Error message for improperly packaged boxes [GH-198]
2011-12-10 21:49:00 -08:00
f44f1831ef
Special error message if SCP is unavailable [GH-568]
2011-12-10 21:30:04 -08:00
d9e2c8b788
Raise a nice error if home directory is not accessible
2011-12-10 17:14:07 -08:00
73a672cff1
load_config! is kind of working again.
...
Specifically: Global configuration load appears to be working. More
unit tests should reveal if proper VM configuration is loading.
2011-12-03 18:31:17 -08:00
b133b0a357
Update CHANGELOG
2011-11-27 11:11:50 -07:00
8c3af5cade
Add file-local emacs and vi filetype settings for Vagrantfile
2011-11-27 11:11:04 -07:00
66eb32d202
Fix typo in creation message.
2011-09-16 14:08:37 -03:00
7219f3d05b
Show warning if forwarding port less than 1024 [closes GH-487]
2011-09-11 23:56:02 -07:00
327a6f9d94
Add a check for VM accessibility before every action
2011-08-28 20:32:22 -07:00
2efe1f9135
Handle inaccessible VMs with "vagrant status"
2011-08-28 20:17:25 -07:00
14d1b987ae
Add validation to args for shell provisioner
2011-08-28 00:02:42 -07:00
3c1b16f286
vagrant ssh -c no longer emits prefix and newlines [closes GH-462]
2011-08-14 13:51:20 -07:00
a42ab2ce20
init command should mention :chef_client provisioner instead of :chef_server [closes GH-464]
2011-08-10 22:45:30 -07:00
18a7b48b89
Change message for virualbox_not_detected to accurately indicate which version of VirtualBox is required. [closes GH-458]
2011-08-09 23:19:13 -07:00
860a458a9c
archlinux host only network support [closes GH-448]
2011-07-30 12:05:09 -07:00
070f20dad7
Get rid of chef json "merge" in default Vagrantfile
2011-07-30 10:28:38 -07:00
2ca46ced57
Fix message when provision is run on halted machine [closes GH-447]
2011-07-30 09:58:29 -07:00
14ca7ecc24
Better validation for networking configuration
2011-07-22 23:53:19 -07:00
a0719d1414
Merge branch 'version_check_40'
2011-07-19 14:40:56 -07:00
09346c2346
v0.7.8
2011-07-19 14:39:49 -07:00
667405c4d7
Require VirtualBox 4.1.x
2011-07-19 14:32:27 -07:00
Mitchell Hashimoto
Hoang Xuan Phu
Samet Atdag
Nate Smith
Brian Waldon
Laurent Arnoud
Julian Connor
Alvaro Videla
Marco Monteiro
Mitchell Hashimoto
Justin Lynn
Hunter Morris
Lorin Hochstein
Christian Rigdon
Susan Potter
Wayne E. Seguin
Ian Downes
Bob Van Zant
Scott Sanders
Richard Millan
Mike Fiedler
William Roe
Steve Losh
Joseph Anthony Pasquale Holsten
Brian J Brennan
Thomas Pelletier