ba7b964b1e
Better error handling for WinRM (using winrm v1.3.0.dev.2)
2014-12-11 13:22:39 -05:00
24f919c4d3
Fix accessors used by in communicator.rb
2014-12-11 13:22:39 -05:00
2caaf82ae0
Change default transport back to :plaintext, for backwards compatibility
2014-12-11 13:21:58 -05:00
02f4adc895
Fix broken variable references
2014-12-11 13:21:58 -05:00
072bb26a30
Change @ssl to @transport
2014-12-11 13:21:58 -05:00
b3480049ad
DRY the Shell: Don't duplicate the Config, especially since there were differing default values
2014-12-11 13:21:58 -05:00
1beb221bf3
Rename no_ssl_peer_verification to ssl_peer_verification, and make it configurable
2014-12-11 13:21:58 -05:00
243cc5dc37
config.rb: set default port based on @ssl
2014-12-11 13:20:22 -05:00
52d8fddf38
shell.rb: fix precedence
2014-12-11 13:20:22 -05:00
4455d2401b
Add ssl option to winrm config.rb
2014-12-11 13:19:09 -05:00
a99d32f60a
Add WinRM over SSL support
2014-12-11 13:19:09 -05:00
94b2a8a56b
communicators/ssh: insert random key, remove insecure key
2014-10-24 09:58:18 -07:00
381f1332c8
Merge pull request #4670 from gildegoma/dry-check-ssh-perms
...
Check SSH key permissions in machine.ssh_info
2014-10-23 09:14:31 -07:00
15f16181f5
communicators/ssh: clear out some comments
2014-10-23 09:06:28 -07:00
c332287665
Addresses issue #2163
...
In the situation where the SSH key has invalid permissions/owner, the reconnect-loop keeps failing repeatedly yet stays silent about the reasons. A message must be reported from the default exception handler (added). In addition, the situations where the SSH key owner or permissions are wrong must lead to a proper failure (added). Ideally, though, the owner/permissions check must happen before launching the VM, hence this is not a perfect fix.
2014-10-23 15:11:10 +03:00
5ebd10c19c
communicators/ssh: timeout on connection check
2014-10-21 17:00:05 -07:00
4e81be879c
Check SSH key permissions in machine.ssh_info
...
With this change, any caller of machine.ssh_info is assured that best
efforts will be done to fix possible wrong permissions on the private
key files.
Fix #4652
2014-10-20 17:33:06 +02:00
4af0f9b9c6
whitespace
2014-10-18 16:13:01 -07:00
1bb61fb3f9
Fix for issue #4452 : undefined stdout in communicator.rb
...
Fixes #4452 .
The stdout variable was changed during commit
https://github.com/mitchellh/vagrant/commit/138aa5aad375ac0c076a0e0a3493
e25906ce0434 . This commit just corrects this omission.
2014-09-03 20:47:46 -05:00
be6665864d
communicators/ssh: nicer errors for SSH exceptions [GH-4367]
2014-08-29 11:40:50 -07:00
069230a563
Merge pull request #4383 from mwrock/error
...
communicators/winrm: handle errors that do not set an exit code
2014-08-29 09:50:41 -07:00
138aa5aad3
communicators/ssh: cleanup PTY code for GH-4408]
2014-08-29 09:41:35 -07:00
87fb5d11fe
Preserve exit code while using pseudo-terminal hack.
2014-08-29 11:50:22 +02:00
a0d3719b52
Scrub SSH PTY output to filter out command echo-ing.
2014-08-28 18:02:27 +02:00
e22767184b
exit wit code 1 from powershell commands that fail but do not send an exit code
2014-08-24 10:18:03 -07:00
f0ef46f648
write to stdout before exit 1
2014-08-17 16:22:35 +02:00
6e4541110b
Merge pull request #4313 from w3ttr3y/master
...
Fixes 4309: Error when provisioning Windows host using Puppet
2014-08-08 18:24:53 -07:00
0da5d7b650
communicators/ssh: clean error on max session [GH-4044]
2014-08-08 09:11:25 -07:00
5ed0b22c78
communicators/ssh: cleaner error if remote disconnect [GH-4038]
2014-08-07 11:53:44 -07:00
4a2566c646
Fixes 4309
...
When the winrm communicator executes a command in an elevated shell,
this patch causes it to escape double quotes.
This is necessary as the first line in the file that it produces and
then executes it puts the command into a variable called command that
is delimited by double quotes.
2014-08-07 08:49:36 -04:00
00bd226fc7
guests/nixos: don't detect as Windows [GH-4302]
2014-08-06 11:17:41 -07:00
94841ef1bc
Merge pull request #4094 from mitchellh/improved-winrm-command-failure-messaging
...
provisioners/winrm: Better WinRM command failure messaging
2014-08-06 10:44:35 -07:00
120b15bc39
Modified WinRM rm filter to account for -f switch, handle recurse properly
2014-07-30 15:43:37 -04:00
361d41527a
Added mkdir command filter for WinRM to be compatible with PS4+
2014-07-30 15:43:11 -04:00
50d0861de4
Removed extra n from the word "connection"
...
Removed extra n from the word "connection" in "Attempting SSH connection" in logger call.
2014-06-27 19:27:23 -04:00
c72a412600
Better WinRM command failure messaging
...
Command failures include the stdout and stderr in the error message just like the SSH communicator.
Its now possible to specify only an error_class and have that use the correct error_key by default.
2014-06-24 10:09:11 -07:00
291f01045b
Fixed issue 3918
...
Running Windows guest commands through a scheduled task were not returning the correct exit codes, they were only returning 1 or 0. This has negative consequences especially for Puppet which can return an exit code of 2 for partial success.
Since we're running an executable from inside a powershell encoded command we need to ensure we explicitly propagate the exit code to the original caller just like a regular PowerShell script - in this case cmd /c which in return is called from a scheduled task.
2014-05-28 08:54:36 -07:00
bb052366f7
Change symbols inside hashes to 1.9 JSON-like syntax
2014-05-22 12:35:12 -04:00
d7fa60b5df
communicators/winrm: use winrm_info cap if available [GH-3832]
2014-05-20 20:13:36 -07:00
0485413d0a
Merge pull request #3847 from mitchellh/command-line-too-long-fix-for-winrm
...
guests/windows: fix #3816 long arg list
2014-05-20 19:38:53 -07:00
690c119ae2
communicators/winrm: don't look up forwarded port if non-local [GH-3861]
2014-05-20 19:30:53 -07:00
0d3979f80d
Fixed issue 3816
...
Elevated command line is now rendered to a script which is uploaded to the guest and executed. This allows the command line itself to be less than 100 chars to start the script and any user commands are puts into the script which has unlimited* length.
2014-05-19 08:04:59 -07:00
823e80fa32
Fixed issue 3729
...
The logic used to read the file contents sometimes would leave lines behind unread. It now defaults to reading all lines and counts each line it has actually read.
2014-05-15 09:17:57 -07:00
782c3762cc
communicators/ssh: rescue another exception for reset
2014-05-09 15:59:15 -07:00
b47df84887
communicators/winrm: fix tests
2014-05-07 10:09:14 -07:00
882c9ad7f6
communicators/winrm: good_exit option
2014-05-07 09:47:47 -07:00
604ae6caa3
communicators/ssh: detect if config.ssh.shell is non-functional [GH-3040]
2014-05-01 21:35:02 -07:00
30b0399431
Use new Ruby hash initializer syntax
2014-04-26 21:07:26 -07:00
f18a397289
Allow WinRM commands to be run elevated via scheduled task
2014-04-26 21:07:26 -07:00
1dd081d866
Don't use interpolated strings for username and password
...
Its possible that usernames and passwords may contain special characters like $
2014-04-26 21:07:26 -07:00
045e06455a
Added WinRM elevated shell wrapper script
...
This script creates an immediately run scheduled task using fresh credentials. This is a generic implementation used by the Chef provisioners. The script gets around several limitations in WinRM.
1. Credential hopping
2. The non-default Administrator account sometimes doesn't have true Administrator access when run through WinRM even with UAC disabled.
In short, this script allows commands to run through WinRM just as if they were run directly on the box.
2014-04-26 21:07:26 -07:00
cad3dde760
Fixed whitespacing in command_filter and file_manager
2014-04-24 07:52:13 -07:00
afeb60c850
ivars should be alphabetized
2014-04-24 07:50:24 -07:00
d5d9918e48
Cleanup whitespace and comments in WinRM command filters
2014-04-24 07:49:19 -07:00
ab51a786ff
Extract execution_output method from WinRM comm execute
2014-04-23 21:49:28 -07:00
4a2a147926
Refactored WinRM test command filter
2014-04-23 21:15:05 -07:00
f44c795eed
Integrated WinRM command filter into communicator
...
*nix commands are now filtered out instead of being sent to the guest. This means the command_alias PowerShell script is no longer needed.
Moved the PowerShell exit code helper to the WinRM shell and changed it to always return an exit code.
2014-04-23 20:38:16 -07:00
1525aa0f78
Added WinRM grep command filter
...
This is needed because isn't available on Windows and Vagrant guest detection attempts to use grep for some OSs.
2014-04-23 20:37:15 -07:00
ac81841b01
test command should expand environment variables
...
'$Env:SystemRoot' does not expand
"$Env:SystemRoot" does expand
2014-04-23 18:26:45 -07:00
96ab8f60c5
Added WinRM command filters
...
These will be used to replace the guest side command_alias script that is sent with every communicator execute call. This avoids some uncessary remote calls to the guest, makes it unit testable, and allows larger PowerShell commands to be invoked.
2014-04-23 17:50:20 -07:00
eae3f3243e
Merge pull request #3517 from mitchellh/communicator-support-for-wql
...
communicator/winrm: Communicator support for wql
2014-04-23 06:02:24 -07:00
5f4a900d8e
Add WinRM file transfer error and english text
2014-04-22 14:54:13 -07:00
f292232ca8
Added Windows guest file manager for recursive uploads
...
- Since WinRM uploads are so slow, MD5 content checking is used
2014-04-22 14:42:13 -07:00
9177bd8a48
Added WQL support to Vagrant communicator execute
...
- Removed duplication for WQL specific commands
2014-04-22 11:29:22 -07:00
db64fbf6ef
communicators/winrm: reload shell on reload so we get proper port
2014-04-21 13:56:42 -07:00
6721d8e964
communicators/ssh: just use Ruby 2.0 features
2014-04-21 13:54:52 -07:00
bd51c16700
provisioners/puppet: execute properly with WinRM
2014-04-21 13:54:00 -07:00
47b5a3fcdb
communicators/winrm: silence warnings loading winrm
...
/cc @sneal - I silenced warnings using the built-in util. Also, can you
see if we load here if that load error goes away?
2014-04-21 13:51:27 -07:00
7223e29330
communicators/winrm: fix powershell execution
2014-04-21 13:51:05 -07:00
21ac0810fd
communicators/winrm: more tests
2014-04-21 13:51:04 -07:00
bb9f0aef32
communicators/winrm: autodetect port based on forwarded ports
2014-04-21 13:51:03 -07:00
eebebd8837
communicators/winrm: Config unit tests (a little)
2014-04-21 13:50:59 -07:00
2a8a04ebb9
communicators/winrm: initial import from vagrant-windows
2014-04-21 13:50:58 -07:00
ad8d133293
communicators/ssh: throttle warnings [GH-3442]
2014-04-11 16:17:17 -07:00
77c92d0d11
communicators/ssh: only show warnings after a few attempts [GH-3442]
2014-04-11 14:36:19 -07:00
a7cc402258
vagrant ssh accept utf8, fix #2744
...
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
2014-03-30 12:15:53 +09:00
f7adeadf8d
communicators/ssh: change wording on retry
2014-03-21 17:48:03 -07:00
fb4cb4636e
fix timout typo
2014-03-11 17:27:47 +08:00
c877fc27a7
communicators/ssh: call ready? when waiting
...
This lets things like the SSH key go in
2014-02-26 11:35:41 -08:00
67a0d3d5f1
communicators/ssh: rescue/show correct error messages
2014-02-23 22:31:37 -08:00
2fe2fe79ed
communicators/ssh: properly allow errors through while waiting
2014-02-13 21:04:41 -08:00
ed5e544e63
communicators/ssh: more verbose output about waiting for SSH
2014-02-13 20:59:26 -08:00
14b27ae215
communicators/ssh: cache ssh_info
...
This lowers the number of subprocesses with VirtualBox quite a bit.
2014-02-13 20:34:51 -08:00
3c10bf7721
communicators/ssh: better error message
2014-02-03 12:09:13 +01:00
a633b7343a
Fix wording of upload permission error
...
SCPPermissionDenied expects a path, and this is most likely the
destination (to) and not source (from).
[#2804 ]
2014-01-28 13:49:14 -05:00
732a03c1c4
guests/linux: properly quote and insert public key
2014-01-08 15:12:26 -08:00
4c6957b5cf
communicators/ssh: if insert_key is false, don't insert a key
2014-01-03 11:29:44 -08:00
54e640b0c9
communicators/ssh: output UI when inserting key
2014-01-03 11:22:05 -08:00
b3a9e6a088
insert_public_key cap, and use that if it exists
2014-01-03 11:13:21 -08:00
38e7166a21
communicators/ssh: support passwords
2014-01-03 09:55:34 -08:00
9cd9e6e55d
communicators/ssh: add -E to sudo to preserve env
2013-12-03 12:07:14 -08:00
45e09eb677
core: allow multiple private keys [GH-907]
2013-11-25 15:45:39 -08:00
6baab10df4
communicators/ssh: pty can be enabled
2013-11-24 16:48:07 -08:00
d5dcf84d62
Allow the FreeBSD plugin to install without bash [GH-2485]
...
The default shell is "bash -l" which does not get installed by default
on FreeBSD. This change allows the plugin to override the default shell
and use a known installed shell (sh).
2013-11-22 15:30:12 -08:00
f9e4ea9ce8
communicators/ssh: timeout waiting for connection + header [GH-2226]
2013-09-18 09:32:30 -07:00
93f2e9ebbb
communicators/ssh: increase conect timeout [GH-2163]
2013-09-15 17:37:40 -07:00
4c35f6d071
core: exec with the proxy command if specified
2013-09-04 17:23:43 -07:00
763bdc42f4
Merge pull request #1537 from wormzer/master
...
communicator/ssh: Additional proxy_command option
2013-09-04 17:18:59 -07:00
a656a99654
communicators/ssh: remove use of nonexistent config
2013-09-02 09:11:39 -07:00
50fdf1358c
communicators/ssh: handle closed connection without exception
2013-08-29 10:36:23 -07:00
Max Lincoln
Peter Ericson
Mitchell Hashimoto
Mitchell Hashimoto
Konstantin Tretyakov
Gilles Cornu
Nicolas Philippe
Leo Simons
Matt Wrock
Stefan Scherer
William E. Triest. III
Richard Guin
jdmulloy
Shawn Neal
Kalman Hazins
Hiroshi Miura
krazyLee
Justin Campbell
Mark Peek