From 487252150fbeb9c0265ad7e9a6aa4057e09b4246 Mon Sep 17 00:00:00 2001 From: Allen Ibara Date: Fri, 10 Jan 2014 10:59:44 -0800 Subject: [PATCH] LPC: Cleanup regs_size (in bytes). Also use sizeof() to make it clear why we multiple and divide by 4. --- src/arm7tdmi.c | 2 +- src/lpc11xx.c | 2 +- src/lpc43xx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/arm7tdmi.c b/src/arm7tdmi.c index ad38ab3..26c5233 100644 --- a/src/arm7tdmi.c +++ b/src/arm7tdmi.c @@ -131,7 +131,7 @@ void arm7tdmi_jtag_handler(jtag_dev_t *dev) t->mem_write_words = (void *)do_nothing; t->mem_read_bytes = (void *)do_nothing; t->mem_write_bytes = (void *)do_nothing; - t->regs_size = 16 * 4; + t->regs_size = 16 * sizeof(uint32_t); t->regs_read = (void *)arm7_regs_read; t->regs_write = (void *)arm7_regs_write; t->pc_write = (void *)do_nothing; diff --git a/src/lpc11xx.c b/src/lpc11xx.c index 9adbe2b..01afd87 100644 --- a/src/lpc11xx.c +++ b/src/lpc11xx.c @@ -116,7 +116,7 @@ lpc11xx_probe(struct target_s *target) static void lpc11x_iap_call(struct target_s *target, struct flash_param *param, unsigned param_len) { - uint32_t regs[target->regs_size / 4]; + uint32_t regs[target->regs_size / sizeof(uint32_t)]; /* fill out the remainder of the parameters and copy the structure to RAM */ param->opcodes[0] = 0xbe00; diff --git a/src/lpc43xx.c b/src/lpc43xx.c index 758c2f1..fbd3941 100644 --- a/src/lpc43xx.c +++ b/src/lpc43xx.c @@ -331,7 +331,7 @@ static int32_t sector_number(uint32_t addr) static void lpc43xx_iap_call(struct target_s *target, struct flash_param *param, unsigned param_len) { - uint32_t regs[target->regs_size / 4]; + uint32_t regs[target->regs_size / sizeof(uint32_t)]; uint32_t iap_entry; target_mem_read_words(target, &iap_entry, IAP_ENTRYPOINT_LOCATION, sizeof(iap_entry));