From 9f9d42861dd2772b25557fb13cbae7e56c09d20c Mon Sep 17 00:00:00 2001
From: andrew1x000 <39840105+andrew1x000@users.noreply.github.com>
Date: Tue, 20 Sep 2022 21:03:27 +0300
Subject: [PATCH] stm32f4: fix wrong idcode when probing (#1242)

* stm32f4: fixed wrong idcode when probing

* stm32f4: fixed formatting

* stm32f4: t->part_id detection via DBGMCU_IDCODE

* stm32f4: stm32f4_probe() changes after check

* stm32f4: added missing t->mass_erase assignment

Co-authored-by: Andrew Novikov <andrew.novikov@cprime.com>
---
 src/target/stm32f4.c | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/src/target/stm32f4.c b/src/target/stm32f4.c
index fd7ffdf..0d2755f 100644
--- a/src/target/stm32f4.c
+++ b/src/target/stm32f4.c
@@ -207,36 +207,39 @@ static void stm32f4_detach(target *t)
 
 bool stm32f4_probe(target *t)
 {
-	if (t->part_id == ID_STM32F20X) {
+	uint16_t mcu_idcode = target_mem_read32(t, DBGMCU_IDCODE) & 0xfffU;
+
+	if (mcu_idcode == ID_STM32F20X) {
 		/* F405 revision A have a wrong IDCODE, use ARM_CPUID to make the
 		 * distinction with F205. Revision is also wrong (0x2000 instead
 		 * of 0x1000). See F40x/F41x errata. */
 		if ((t->cpuid & 0xFFF0) == CORTEX_M4)
-			t->part_id = ID_STM32F40X;
+			mcu_idcode = ID_STM32F40X;
 	}
-	switch(t->part_id) {
+
+	switch (mcu_idcode) {
 	case ID_STM32F74X: /* F74x RM0385 Rev.4 */
 	case ID_STM32F76X: /* F76x F77x RM0410 */
 	case ID_STM32F72X: /* F72x F73x RM0431 */
-	case ID_STM32F40X:
 	case ID_STM32F42X: /* 427/437 */
 	case ID_STM32F46X: /* 469/479 */
 	case ID_STM32F20X: /* F205 */
-	case ID_STM32F446: /* F446 */
+	case ID_STM32F40X:
+	case ID_STM32F446:  /* F446 */
 	case ID_STM32F401C: /* F401 B/C RM0368 Rev.3 */
-	case ID_STM32F411: /* F411     RM0383 Rev.4 */
-	case ID_STM32F412: /* F412     RM0402 Rev.4, 256 kB Ram */
+	case ID_STM32F411:  /* F411     RM0383 Rev.4 */
+	case ID_STM32F412:  /* F412     RM0402 Rev.4, 256 kB Ram */
 	case ID_STM32F401E: /* F401 D/E RM0368 Rev.3 */
-	case ID_STM32F413: /* F413     RM0430 Rev.2, 320 kB Ram, 1.5 MB flash. */
-		t->mass_erase = stm32f4_mass_erase;
-		t->detach = stm32f4_detach;
-		t->driver = stm32f4_get_chip_name(t->part_id);
+	case ID_STM32F413:  /* F413     RM0430 Rev.2, 320 kB Ram, 1.5 MB flash. */
 		t->attach = stm32f4_attach;
+		t->detach = stm32f4_detach;
+		t->mass_erase = stm32f4_mass_erase;
+		t->driver = stm32f4_get_chip_name(t->part_id);
+		t->part_id = mcu_idcode;
 		target_add_commands(t, stm32f4_cmd_list, t->driver);
 		return true;
-	default:
-		return false;
 	}
+	return false;
 }
 
 static bool stm32f4_attach(target *t)