Refactor KioskTab.equals

2021-05-22 00:13:17 -04:00 · 2021-05-22 00:13:17 -04:00 · 1cac3895dc
parent 01aab25889
commit 1cac3895dc
1 changed files with 7 additions and 2 deletions
--- a/app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java
+++ b/app/src/main/java/org/schabi/newpipe/settings/tabs/Tab.java
@ -362,8 +362,13 @@ public abstract class Tab {

        @Override
        public boolean equals(final Object obj) {
-            return super.equals(obj) && kioskServiceId == ((KioskTab) obj).kioskServiceId
-                    && Objects.equals(kioskId, ((KioskTab) obj).kioskId);
+            if (!(obj instanceof KioskTab)) {
+                return false;
+            }
+            final KioskTab other = (KioskTab) obj;
+            return super.equals(obj)
+                    && kioskServiceId == other.kioskServiceId
+                    && kioskId.equals(other.kioskId);
        }

        public int getKioskServiceId() {