be-gay-do-crimes
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

Refactor and optimize equals 

- Remove multiple casts of obj

 - Simply use object equals on the streams because PlayQueueItem’s
   equals already compares urls
This commit is contained in:
Eric Xu 2021-05-21 00:33:11 -04:00 committed by Zhiheng Xu
parent 139ced885d
commit 57474e2dab
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/java/org/schabi/newpipe/player/playqueue/PlayQueue.java
View File

@ -500,22 +500,14 @@ public abstract class PlayQueue implements Serializable {
* we don't have to do anything with new queue. * we don't have to do anything with new queue.
* This method also gives a chance to track history of items in a queue in * This method also gives a chance to track history of items in a queue in
* VideoDetailFragment without duplicating items from two identical queues * VideoDetailFragment without duplicating items from two identical queues
* */ */
@Override @Override
public boolean equals(@Nullable final Object obj) { public boolean equals(@Nullable final Object obj) {
if (!(obj instanceof PlayQueue) if (!(obj instanceof PlayQueue)) {
|| getStreams().size() != ((PlayQueue) obj).getStreams().size()) {
return false; return false;
} }
final PlayQueue other = (PlayQueue) obj; final PlayQueue other = (PlayQueue) obj;
for (int i = 0; i < getStreams().size(); i++) { return streams.equals(other.streams);
if (!getItem(i).getUrl().equals(other.getItem(i).getUrl())) {
return false;
}
}
return true;
} }
public boolean isDisposed() { public boolean isDisposed() {