be-gay-do-crimes
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix Player controls colors on KitKat 

AppCompatImageButton ignores "tint" theme attribute on API 19, therefore, they had to be specified directly, these attributes can be removed after the KitKat support is dropped.
This commit is contained in:
krlvm 2021-04-02 23:58:10 +03:00
parent 24247fd6a6
commit 6b5a1d0202
No known key found for this signature in database
GPG Key ID: B8552A91FD265536
2 changed files with 28 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/src/main/res/layout-large-land/player.xml
View File

@ -103,6 +103,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_close" app:srcCompat="@drawable/ic_close"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -188,6 +189,7 @@
android:paddingBottom="3dp" android:paddingBottom="3dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_list" app:srcCompat="@drawable/ic_list"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -206,6 +208,7 @@
android:paddingBottom="3dp" android:paddingBottom="3dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_format_list_numbered" app:srcCompat="@drawable/ic_format_list_numbered"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -219,6 +222,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_expand_more" app:srcCompat="@drawable/ic_expand_more"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -283,6 +287,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_cast" app:srcCompat="@drawable/ic_cast"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -297,6 +302,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_language" app:srcCompat="@drawable/ic_language"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -311,6 +317,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_share" app:srcCompat="@drawable/ic_share"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -324,6 +331,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_volume_off" app:srcCompat="@drawable/ic_volume_off"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -337,6 +345,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_fullscreen" app:srcCompat="@drawable/ic_fullscreen"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -416,6 +425,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_fullscreen" app:srcCompat="@drawable/ic_fullscreen"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -439,6 +449,7 @@
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_previous" app:srcCompat="@drawable/ic_previous"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -450,6 +461,7 @@
android:layout_weight="1" android:layout_weight="1"
android:background="?attr/selectableItemBackgroundBorderless" android:background="?attr/selectableItemBackgroundBorderless"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_pause" app:srcCompat="@drawable/ic_pause"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -463,6 +475,7 @@
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_next" app:srcCompat="@drawable/ic_next"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -515,6 +528,7 @@
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_close" /> app:srcCompat="@drawable/ic_close" />
<ImageButton <ImageButton

14
app/src/main/res/layout/player.xml
View File

@ -101,6 +101,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_close" app:srcCompat="@drawable/ic_close"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -190,6 +191,7 @@
android:paddingBottom="3dp" android:paddingBottom="3dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_list" app:srcCompat="@drawable/ic_list"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -207,6 +209,7 @@
android:paddingBottom="3dp" android:paddingBottom="3dp"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_format_list_numbered" app:srcCompat="@drawable/ic_format_list_numbered"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -219,6 +222,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_expand_more" app:srcCompat="@drawable/ic_expand_more"
tools:ignore="ContentDescription,RtlHardcoded" /> tools:ignore="ContentDescription,RtlHardcoded" />
@ -282,6 +286,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_cast" app:srcCompat="@drawable/ic_cast"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -296,6 +301,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_language" app:srcCompat="@drawable/ic_language"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -310,6 +316,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_share" app:srcCompat="@drawable/ic_share"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -323,6 +330,7 @@
android:focusable="true" android:focusable="true"
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_volume_off" app:srcCompat="@drawable/ic_volume_off"
tools:ignore="RtlHardcoded" /> tools:ignore="RtlHardcoded" />
@ -336,6 +344,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_fullscreen" app:srcCompat="@drawable/ic_fullscreen"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -413,6 +422,7 @@
android:padding="@dimen/player_main_buttons_padding" android:padding="@dimen/player_main_buttons_padding"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:visibility="gone" android:visibility="gone"
app:tint="@color/white"
app:srcCompat="@drawable/ic_fullscreen" app:srcCompat="@drawable/ic_fullscreen"
tools:ignore="ContentDescription,RtlHardcoded" tools:ignore="ContentDescription,RtlHardcoded"
tools:visibility="visible" /> tools:visibility="visible" />
@ -436,6 +446,7 @@
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_previous" app:srcCompat="@drawable/ic_previous"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -447,6 +458,7 @@
android:layout_weight="1" android:layout_weight="1"
android:background="?attr/selectableItemBackgroundBorderless" android:background="?attr/selectableItemBackgroundBorderless"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_pause" app:srcCompat="@drawable/ic_pause"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -460,6 +472,7 @@
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:scaleType="fitCenter" android:scaleType="fitCenter"
app:tint="@color/white"
app:srcCompat="@drawable/ic_next" app:srcCompat="@drawable/ic_next"
tools:ignore="ContentDescription" /> tools:ignore="ContentDescription" />
@ -511,6 +524,7 @@
android:focusable="true" android:focusable="true"
android:padding="10dp" android:padding="10dp"
android:scaleType="fitXY" android:scaleType="fitXY"
app:tint="@color/white"
app:srcCompat="@drawable/ic_close" /> app:srcCompat="@drawable/ic_close" />
<androidx.appcompat.widget.AppCompatImageButton <androidx.appcompat.widget.AppCompatImageButton