be-gay-do-crimes
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

apply @stypox suggestions

This commit is contained in:
bopol 2020-05-19 21:51:39 +02:00
parent 9a938093e2
commit 97437b8af3
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/main/java/org/schabi/newpipe/util/ShareUtils.java
View File

@ -16,36 +16,33 @@ public final class ShareUtils {
* Open the url with the system default browser. * Open the url with the system default browser.
* <p> * <p>
* If no browser is set as default, fallbacks to * If no browser is set as default, fallbacks to
* {@link ShareUtils#openUrlBrowserChooser(Context, String)} * {@link ShareUtils#openInDefaultApp(Context, String)}
* *
* @param context the context to use * @param context the context to use
* @param url the url to browse * @param url the url to browse
*/ */
public static void openUrlInBrowser(final Context context, final String url) { public static void openUrlInBrowser(final Context context, final String url) {
final Intent intent = new Intent(Intent.ACTION_VIEW);
intent.setData(Uri.parse(url));
final String defaultBrowserPackageName = getDefaultBrowserPackageName(context); final String defaultBrowserPackageName = getDefaultBrowserPackageName(context);
if (defaultBrowserPackageName.equals("android")) { if (defaultBrowserPackageName.equals("android")) {
// no browser set as default // no browser set as default
openUrlBrowserChooser(context, url); openInDefaultApp(context, url);
} else { } else {
final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
intent.setPackage(defaultBrowserPackageName); intent.setPackage(defaultBrowserPackageName);
context.startActivity(intent); context.startActivity(intent);
} }
} }
/** /**
* Open the url with application chooser, including browser and apps able to open url. * Open the url in the default app set to open this type of link
* <p> * <p>
* If any app (except browser, typically NewPipe) is set as default, * If no app is set as default, it will open a chooser
* it will nor open in browser, neither open the chooser, but just the default app.
* *
* @param context the context to use * @param context the context to use
* @param url the url to browse * @param url the url to browse
*/ */
private static void openUrlBrowserChooser(final Context context, final String url) { private static void openInDefaultApp(final Context context, final String url) {
final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url)); final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
context.startActivity(Intent.createChooser( context.startActivity(Intent.createChooser(
intent, context.getString(R.string.share_dialog_title))); intent, context.getString(R.string.share_dialog_title)));