be-gay-do-crimes
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

Moved timeout control from the tests to the CI pipeline 

How fast a tests is executed on a shared CI pipeline is not predictable as the build might be throttled because other builds are running.
Therefore adding extremely short timeouts inside the tests - where they can't be changed - is a bad idea.
Removed them for now.
This commit is contained in:
litetex 2022-01-21 22:15:34 +01:00
parent 3c21be8fa5
commit a6515d5450
3 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.github/workflows/ci.yml vendored
View File

@ -52,6 +52,7 @@ jobs:
test-android: test-android:
# macos has hardware acceleration. See android-emulator-runner action # macos has hardware acceleration. See android-emulator-runner action
runs-on: macos-latest runs-on: macos-latest
timeout-minutes: 20
strategy: strategy:
matrix: matrix:
# api-level 19 is min sdk, but throws errors related to desugaring # api-level 19 is min sdk, but throws errors related to desugaring

3
app/src/androidTest/java/org/schabi/newpipe/local/history/HistoryRecordManagerTest.kt
View File

@ -25,9 +25,6 @@ class HistoryRecordManagerTest {
@get:Rule @get:Rule
val trampolineScheduler = TrampolineSchedulerRule() val trampolineScheduler = TrampolineSchedulerRule()
@get:Rule
val timeout = Timeout(1, TimeUnit.SECONDS)
@Before @Before
fun setup() { fun setup() {
database = TestDatabase.createReplacingNewPipeDatabase() database = TestDatabase.createReplacingNewPipeDatabase()

3
app/src/androidTest/java/org/schabi/newpipe/local/playlist/LocalPlaylistManagerTest.kt
View File

@ -20,9 +20,6 @@ class LocalPlaylistManagerTest {
@get:Rule @get:Rule
val trampolineScheduler = TrampolineSchedulerRule() val trampolineScheduler = TrampolineSchedulerRule()
@get:Rule
val timeout = Timeout(1, TimeUnit.SECONDS)
@Before @Before
fun setup() { fun setup() {
database = TestDatabase.createReplacingNewPipeDatabase() database = TestDatabase.createReplacingNewPipeDatabase()