be-gay-do-crimes
/
NewPipe
mirror of https://github.com/TeamNewPipe/NewPipe
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #10085 from TacoTheDank/bumpLeakCanary 

Update LeakCanary library
This commit is contained in:
Stypox 2023-07-12 19:05:38 +02:00 committed by GitHub
parent 5c7a9a52f5 db7de05f2b
commit f8599d17c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/build.gradle
View File

@ -119,7 +119,7 @@ ext {
groupieVersion = '2.10.1'
markwonVersion = '4.6.2'
leakCanaryVersion = '2.9.1'
leakCanaryVersion = '2.12'
stethoVersion = '1.6.0'
mockitoVersion = '4.0.0'
}
@ -290,7 +290,7 @@ dependencies {
// Memory leak detection
implementation "com.squareup.leakcanary:leakcanary-object-watcher-android:${leakCanaryVersion}"
implementation "com.squareup.leakcanary:plumber-android:${leakCanaryVersion}"
debugImplementation "com.squareup.leakcanary:leakcanary-android:${leakCanaryVersion}"
debugImplementation "com.squareup.leakcanary:leakcanary-android-core:${leakCanaryVersion}"
// Debug bridge for Android
debugImplementation "com.facebook.stetho:stetho:${stethoVersion}"
debugImplementation "com.facebook.stetho:stetho-okhttp3:${stethoVersion}"

2
app/src/debug/java/org/schabi/newpipe/DebugApp.kt
View File

@ -14,7 +14,7 @@ class DebugApp : App() {
initStetho()
// Give each object 10 seconds to be GC'ed, before LeakCanary gets nosy on it
AppWatcher.config = AppWatcher.config.copy(watchDurationMillis = 10000)
AppWatcher.manualInstall(this, retainedDelayMillis = 10000)
LeakCanary.config = LeakCanary.config.copy(
dumpHeap = PreferenceManager
.getDefaultSharedPreferences(this).getBoolean(

3
app/src/main/java/org/schabi/newpipe/BaseFragment.java
View File

@ -81,7 +81,8 @@ public abstract class BaseFragment extends Fragment {
public void onDestroy() {
super.onDestroy();
AppWatcher.INSTANCE.getObjectWatcher().watch(this);
AppWatcher.INSTANCE.getObjectWatcher().expectWeaklyReachable(
this, "Watch for leaks from destroyed fragments.");
}
/*//////////////////////////////////////////////////////////////////////////