b3554a6a49
Added the number of duplicates to the toast text.
2023-01-14 18:01:48 +01:00
5fb7b3266b
Removed the duplicate dialog and added another toast option
2023-01-14 18:01:48 +01:00
8b6e110635
Fixed the functionality, improved performance & general code cleanup
2023-01-14 18:01:47 +01:00
f5a1f915be
Continued working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
ac15339911
Started working on a way to show that items are already in a playlist
2023-01-14 18:01:47 +01:00
fdfeac081a
Implemented a warning before adding duplicate to playlist.
2023-01-14 18:01:46 +01:00
31396a632f
Chenged the name of the icon
2023-01-14 09:21:37 +01:00
223150aa42
Update desugar_jdk_libs to 2.0.0.
2023-01-14 11:00:00 +05:30
135fc08212
Implemented the "remove duplicates" feature.
2023-01-13 21:35:22 +01:00
5e3caf68a5
Chenged the What's New icon
2023-01-13 16:33:45 +01:00
262b3a2945
Merge pull request #9664 from Marius1501/whats_new_section_to_default_tabs
...
Added the "What's New"-section to the default tabs
2023-01-13 13:25:02 +01:00
e44d09208c
Merge pull request #9642 from Jared234/8582_empty_playlists_not_shown
...
Fixed a bug that prevented the display of multiple empty playlists
2023-01-13 13:20:42 +01:00
0546c9b9fc
Merge pull request #9445 from Jared234/9122_remove_watched_bug
...
Fixed a bug that incorrectly removed videos from a playlist when using the "Remove Viewed" dialog
2023-01-12 23:45:48 +01:00
38c4a1ed85
Fixed the "Remove Watched" bug
...
Reverted changes and fixed bug in a different way
2023-01-12 23:44:26 +01:00
fd8e92cf77
Merge pull request #9523 from Jared234/9468_permanently_set_thumbnail
...
Allow the user to permanently set a thumbnail
2023-01-12 23:27:50 +01:00
062570cc47
Merge pull request #8886 from Isira-Seneviratne/Remove_Runnable_variables
...
Remove Runnable variables for Handlers.
2023-01-12 15:34:12 +01:00
9514316be3
Remove Runnable variables for Handlers.
2023-01-12 15:30:19 +01:00
a15a5adacc
Merge pull request #9619 from Redirion/avoidreflectionifpossible
...
Check availability of Samsung DeX only on Samsung devices
2023-01-12 12:06:19 +01:00
b6e6d39985
Fix toast crash on API 33
...
You shouldn't call getView() on toasts.
Also simplified some duplicate code.
2023-01-12 11:39:25 +01:00
48ae830262
Merge pull request #9653 from petlyh/fix-popup-crash
...
Ask for permission when enqueuing in a popup
2023-01-12 11:24:21 +01:00
03f5dd71a5
Merge pull request #9499 from pratyaksh1610/branch-9466
...
Added Language suffix for subtitle downloads
2023-01-11 19:46:51 +01:00
2afbe58722
UX improvements: keep user edits & do not reset cursor
2023-01-11 19:45:55 +01:00
0a64eac778
Added the "What's New"-section to the default tabs
2023-01-11 16:06:11 +01:00
ad605e2c5a
Actually there is no need to use flatMap
...
`null` values returned in the lambda are converted to empty `Optional`s in the `map` method: https://developer.android.com/reference/java/util/Optional#map(java.util.function.Function%3C?%20super%20T,%20?%20extends%20U%3E)
2023-01-11 15:26:46 +01:00
eed44b3231
Merge pull request #9135 from devlearner/routeractivity-screen-rotate
...
Improve screen rotation handling in Open action menu
2023-01-11 15:20:47 +01:00
944e295ae7
Use Optional for simpler code
2023-01-11 15:14:18 +01:00
28109fef38
Improve showing of toast
...
We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
2023-01-11 14:53:48 +01:00
40442f3f82
Utilize Lifecycle observer
...
I thought it would have required an extra dependency; apparently that doesn't seem to be the case...
2023-01-11 14:53:48 +01:00
61da167b4f
Oops, added back missing return;
2023-01-11 14:53:48 +01:00
c744f6756b
Fix Sonar reported code smell
2023-01-11 14:53:48 +01:00
de7057ac3a
Skip REORDER_TO_FRONT trick which doesn't seem to work on newer Androids
...
probably due to background restrictions on Android 10+
2023-01-11 14:53:48 +01:00
585bfff11d
Utilize a retained fragment to safekeep network requests in flight
...
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
2023-01-11 14:53:48 +01:00
0f9c20c986
Improve (un)registering FragmentLifecycleCallbacks
...
to avoid adding it multiple times and ensure proper cleanup
2023-01-11 14:53:48 +01:00
f860392ae9
Address LayoutParams.FLAG_NOT_TOUCHABLE restriction on Andriod 12+
2023-01-11 14:53:48 +01:00
391830558e
Ensure our transparent activity doesn't block touch events to underlying windows
...
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
2023-01-11 14:53:48 +01:00
c1f37d8591
Also show toast in openDownloadDialog()
...
and lengthened a bit to inform user to wait...
2023-01-11 14:53:48 +01:00
b175774ad8
Try to amicably handle DialogFragment in FragmentManager when recreated from orientation change
...
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
2023-01-11 14:53:48 +01:00
73e32889b6
Don't finish() to allow recreate
...
when orientation change is on foot
2023-01-11 14:53:48 +01:00
400ee808e0
Set up theme/locale before super.create()
...
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
2023-01-11 14:53:48 +01:00
87976693f8
Merge pull request #9285 from Isira-Seneviratne/Optional_cleanup
...
Clean up Optional-related code.
2023-01-11 14:52:25 +01:00
9c7ed80662
Use Optional.map correctly and other improvements
2023-01-11 14:47:53 +01:00
eb3363d4dd
Created the first draft.
2023-01-10 20:55:18 +01:00
edff696ecc
Ask for permission when enqueuing in a popup
2023-01-10 14:16:19 +01:00
9c19e9813a
Fixed a bug that caused multiple empty playlists to be not shown.
2023-01-08 11:53:42 +01:00
2679a4bf1e
Removed the "Unset Thumbnail" item if you can't use this feature
2023-01-04 16:21:16 +01:00
e8216b2e80
Apply code review suggestions.
2023-01-04 06:10:14 +05:30
e3062d7c66
Use Optional chaining.
2023-01-04 05:16:21 +05:30
fd55d85bbf
Remove SimplifyOptionalCallChains.
2023-01-04 05:16:21 +05:30
f10d591462
Samsung DeX should only be checked on Samsung devices
...
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2023-01-03 15:12:02 +01:00
3e15c77a05
move string to donottranslate.xml and fix nits
2023-01-03 14:07:28 +05:30
Jared Fantaye
ge78fug
Isira Seneviratne
Stypox
devlearner
petlyh
Robin
pratyaksh1610