instead use service.stopService() which inturn calls stopSelf() and
triggers hopefully onDestroy() to be called. Eventually we have to make
sure that all ServiceConnections are closed to successfully stop the service
now!
Cleanup within stopService() and not only onDestroy()
So we make sure that all listeners can react to onServiceStopped()
and close their ServiceConnections. Afterwards the android framework
is ready to stop the Service.
It seems due to #6394 updating the FragmentX library there was a
change to the order of lifecycle calls, as such onResume() was no longer
before onCreateOptionsMenu() creating a null pointer exception when
using service in onCreateOptionsMenu() as it is only set in onResume().
By moving the initialization of service to onStart() which still happens
before onCreateOptionsMenu() this crash can be avoided. This commit also
adds a check for a null service to prevent future crashes for similar
issues.
System is now not restarted with `System.exit(0)`.
Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Kurdish)
Currently translated at 1.9% (1 of 51 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Kurdish (Central))
Currently translated at 87.8% (586 of 667 strings)
Translated using Weblate (Estonian)
Currently translated at 92.2% (615 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Punjabi)
Currently translated at 3.9% (2 of 51 strings)
Translated using Weblate (Greek)
Currently translated at 31.3% (16 of 51 strings)
Translated using Weblate (Bengali)
Currently translated at 89.6% (598 of 667 strings)
Translated using Weblate (Bengali (India))
Currently translated at 54.1% (361 of 667 strings)
Translated using Weblate (Interlingua)
Currently translated at 41.0% (274 of 667 strings)
Translated using Weblate (Punjabi)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Slovak)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 31.3% (16 of 51 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Hebrew)
Currently translated at 47.0% (24 of 51 strings)
Translated using Weblate (Interlingua)
Currently translated at 39.8% (266 of 667 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 27.4% (14 of 51 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Ukrainian)
Currently translated at 99.4% (663 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 98.3% (656 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 99.2% (662 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Santali)
Currently translated at 14.2% (95 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 66.6% (34 of 51 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 99.7% (665 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (French)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Co-authored-by: AioiLight <info@aioilight.space>
Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it>
Co-authored-by: Andrij Mizyk <andmizyk@gmail.com>
Co-authored-by: C. Rüdinger <Mail-an-CR@web.de>
Co-authored-by: David Braz <davidbrazps2@gmail.com>
Co-authored-by: Digiwizkid <subhadiplayek@gmail.com>
Co-authored-by: Emin Tufan Çetin <etcetin@gmail.com>
Co-authored-by: Eric <spice2wolf@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: JY3 <GeeyunJY3@gmail.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Karl Tammik <karltammik@protonmail.com>
Co-authored-by: Ldm Public <ldmpub@gmail.com>
Co-authored-by: Marian Hanzel <marulinko@gmail.com>
Co-authored-by: Michal L <michalrmsmi@wp.pl>
Co-authored-by: MohammedSR Vevo <mohammednajmidin@gmail.com>
Co-authored-by: Prasanta-Hembram <Prasantahembram720@gmail.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: Santiago <abridgement_phasiron@aleeas.com>
Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Co-authored-by: SomeRetardedThatTranslatesStuff <the.eumitosis@simplelogin.fr>
Co-authored-by: THANOS SIOURDAKIS <siourdakisthanos@gmail.com>
Co-authored-by: Tari <tumbleweed@tuta.io>
Co-authored-by: TobiGr <tobigr@mail.de>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: WaldiS <sto@tutanota.de>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: Yngvar Skjaldulfsson <irrorate_browns@slmail.me>
Co-authored-by: bomzhellino <adm.bomzh@gmail.com>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: gnu-ewm <gnu.ewm@protonmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Co-authored-by: pjammo <adrianoghr@hotmail.it>
Co-authored-by: thami simo <simo.azad@gmail.com>
Co-authored-by: zeritti <woodenmo@posteo.de>
Co-authored-by: zmni <zmni@outlook.com>
Co-authored-by: Обилић <mudo2233@tutanota.com>
Co-authored-by: Слободан Симић(Slobodan Simić) <slsimic@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/el/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ku/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/
Translation: NewPipe/Metadata
Translated using Weblate (English)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (French)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Slovak)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Ukrainian)
Currently translated at 99.4% (663 of 667 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Bengali)
Currently translated at 93.1% (621 of 667 strings)
E/WindowManager: android.view.WindowLeaked: Activity org.schabi.newpipe.RouterActivity has leaked window DecorView@d99fe3b[] that was originally added here
at android.view.ViewRootImpl.<init>(ViewRootImpl.java:418)
Fix the error due to the rebase on the dev branch of this branch
Add a shareText method in the ShareUtils class which has 3 parameters and calls
the original shareText method with an empty string for the
imagePreviewUrl param.
This commit adds supports for opening hashtags in plain text descriptions, using the same logic as timestamps.
Every hashtag opens a search on the current service with the text in the hashtag.
Also use a better regular expression for parsing timestamps.
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
This commit tries to change the title of the system chooser shown, which is from Android System ("Open links with"), when no defaut browser is present, for the update notification.
Add a boolean param, showToast, in ShareUtils.openIntentInApp and only show toast "No app on your device can open this" if this boolean is true.
Fix the action of play with Kodi button by applying the fix provided in #5599 (adding the flag Intent.FLAG_ACTIVITY_NEW_TASK to the intent in NavigationHelper.playWithKore method).
Do also some cleanup in viewWithFileProvider and shareFile methods of MissionAdapter class.
This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp.
In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
This commit adds support of opening recognized timestamps in the popup
player instead of starting an intent which opens the YouTube website with
the video timestamp.
Revert "Annotate methode parameters as NonNull"
This reverts commit 004907d306.
Revert "Commit path immediately when import backup"
This reverts commit 05eb0d0fbe.
Revert "Set ImportExportDataPath only on successful import"
This reverts commit f13a1b04e6.
Revert "Set ImportExportDataPath only on successful export"
This reverts commit fd4408e572.
Revert "Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability"
This reverts commit 92ab9cae27.
Revert "Move ContentSettingsFragment.isValidPath to helpers and add unit test for it."
This reverts commit fa2b11b768.
Revert "Save backup import/export location for feature import/exports"
This reverts commit 82f43ac6a6.
Remove FilePathHelperTest file
Currently translated at 100.0% (51 of 51 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (657 of 657 strings)
Co-authored-by: Emin Tufan Çetin <etcetin@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: bomzhellino <adm.bomzh@gmail.com>
Co-authored-by: whenwesober <naomi16i_1298q@cikuh.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/
Translation: NewPipe/Metadata
Currently translated at 100.0% (51 of 51 strings)
Translated using Weblate (German)
Currently translated at 56.8% (29 of 51 strings)
Translated using Weblate (Polish)
Currently translated at 99.6% (655 of 657 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (French)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (German)
Currently translated at 56.8% (29 of 51 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (51 of 51 strings)
Translated using Weblate (Interlingua)
Currently translated at 40.1% (264 of 657 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (French)
Currently translated at 99.8% (656 of 657 strings)
Translated using Weblate (German)
Currently translated at 100.0% (657 of 657 strings)
Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it>
Co-authored-by: Eric <spice2wolf@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: J. Lavoie <j.lavoie@net-c.ca>
Co-authored-by: Michal L <michalrmsmi@wp.pl>
Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Co-authored-by: TiA4f8R <avdivers84@gmail.com>
Co-authored-by: TobiGr <tobigr@mail.de>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/
Translation: NewPipe/Metadata
Currently translated at 56.0% (28 of 50 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (German)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Interlingua)
Currently translated at 40.0% (263 of 657 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Slovak)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Greek)
Currently translated at 99.8% (656 of 657 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Russian)
Currently translated at 98.9% (650 of 657 strings)
Translated using Weblate (French)
Currently translated at 99.8% (656 of 657 strings)
Translated using Weblate (German)
Currently translated at 98.9% (650 of 657 strings)
Translated using Weblate (English)
Currently translated at 100.0% (657 of 657 strings)
Translated using Weblate (Interlingua)
Currently translated at 34.6% (222 of 641 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (641 of 641 strings)
Translated using Weblate (Serbian)
Currently translated at 16.0% (8 of 50 strings)
Translated using Weblate (Odia)
Currently translated at 4.2% (27 of 641 strings)
Translated using Weblate (Odia)
Currently translated at 2.0% (1 of 50 strings)
Translated using Weblate (Dutch (Belgium))
Currently translated at 99.3% (637 of 641 strings)
Translated using Weblate (Swedish)
Currently translated at 87.3% (560 of 641 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (641 of 641 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (641 of 641 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (641 of 641 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (50 of 50 strings)
Translated using Weblate (French)
Currently translated at 70.0% (35 of 50 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (50 of 50 strings)
Translated using Weblate (Ukrainian)
Currently translated at 8.0% (4 of 50 strings)
Translated using Weblate (Lithuanian)
Currently translated at 4.0% (2 of 50 strings)
Translated using Weblate (Bengali)
Currently translated at 93.7% (601 of 641 strings)
Translated using Weblate (Interlingua)
Currently translated at 34.3% (220 of 641 strings)
Translated using Weblate (Ukrainian)
Currently translated at 8.0% (4 of 50 strings)
Co-authored-by: Andrij Mizyk <andmizyk@gmail.com>
Co-authored-by: David Braz <davidbrazps2@gmail.com>
Co-authored-by: Eric <spice2wolf@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Hritik R <hpujhari7@gmail.com>
Co-authored-by: JY3 <GeeyunJY3@gmail.com>
Co-authored-by: Jacque Fresco <aidter@use.startmail.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Juraj Timko <timko@netrix.sk>
Co-authored-by: Kristoffer Grundström <swedishsailfishosuser@tutanota.com>
Co-authored-by: Ldm Public <ldmpub@gmail.com>
Co-authored-by: Louis Morel <louismorel03@outlook.fr>
Co-authored-by: Oymate <dhruboadittya96@gmail.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: S3aBreeze <paperwork@evilcorp.ltd>
Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Co-authored-by: Terry Louwers <t.louwers@gmail.com>
Co-authored-by: TobiGr <tobigr@mail.de>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: Zhiheng Xu <xeric.2002@gmail.com>
Co-authored-by: bomzhellino <adm.bomzh@gmail.com>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: gymka <gymka@archlinux.lt>
Co-authored-by: jul-debug <jul333666@gmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Co-authored-by: random r <epsilin@yopmail.com>
Co-authored-by: whenwesober <naomi16i_1298q@cikuh.com>
Co-authored-by: Обилић <mudo2233@tutanota.com>
Co-authored-by: Слободан Симић(Slobodan Simić) <slsimic@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/de/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/id/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/lt/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/or/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/sr/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/
Translation: NewPipe/Metadata