Commit Graph

141 Commits

Author SHA1 Message Date
Trust_04zh 91e1d35a10 update to current checkstyle.xml path 2022-04-11 19:59:14 +08:00
litetex 7225199deb
Fixed typo
It was late when I typed this 😆
2022-02-16 20:31:15 +01:00
litetex c08a4e851b
Improved image-minimizer
* Don't minimize images that are too wide -> they will get stretched otherwise
* Don't try to modify the issue/comment when nothing changed
* Fixed typo
2022-02-15 20:09:21 +01:00
litetex e2a7b9ac56
Switch to GitHub issue forms (#7773)
* Switched to GitHub issue forms

See also
* https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms
* https://github.blog/changelog/2021-06-23-issues-forms-beta-for-public-repositories/

* Switched expected and actual behavior

* Improved/Reworked issue template

Credits to @TheAssassin

* CI: Ignore changes to issue-templates

* Improved/Reworked issue template

Credits to @opusforlife2 and @mhmdanas

* Further improved the issue templates

* Next round of review

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2022-02-12 19:34:08 +00:00
litetex f388a1af67
Added image-minimizer (#7772)
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-02-11 19:54:12 +00:00
litetex 1278fc27ae
Merge pull request #7803 from mhmdanas/paths-ignore-doc-dir
Add some stuff to `paths-ignore`
2022-02-09 19:57:47 +01:00
Poussinou 5bf439ad9e
Update FUNDING.yml (#7682)
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-02-04 10:36:00 +00:00
Mohammed Anas 3b1b23ba2a
Add `FUNDING.yml` to `paths-ignore` 2022-02-04 10:32:33 +00:00
Mohammed Anas 9274e6417a
Add files in `doc` to `paths-ignore` 2022-02-04 10:13:10 +00:00
litetex a6515d5450 Moved timeout control from the tests to the CI pipeline
How fast a tests is executed on a shared CI pipeline is not predictable as the build might be throttled because other builds are running.
Therefore adding extremely short timeouts inside the tests - where they can't be changed - is a bad idea.
Removed them for now.
2022-01-21 22:15:34 +01:00
litetex 552734faa5
CI: Upload test-report when an error occurs 2022-01-09 18:09:47 +01:00
XiangRongLin dc67628ba5 Log test-android CI job in stacktrace mode 2021-12-22 09:55:16 +01:00
XiangRongLin e06342eacf Readd sonar CI job 2021-12-19 12:18:37 +01:00
opusforlife2 2e3e7f9bf2
Drastically simplify Feature Request template (#7165)
Making the experience of filling it out as hassle-free as possible would ensure fewer users ignore/misread the template.
2021-10-02 12:17:14 +03:00
litetex fc52a6e871
Merge branch 'dev' into update-android-build-tools-gradle 2021-09-03 23:18:16 +02:00
Stypox 15691ba41a
Merge pull request #7002 from litetex/gh-actions-use-integrated-cache-setup-java
Using integrated cache in ``actions/setup-java``
2021-08-31 12:01:26 +02:00
Stypox 5ffba55b4a
Merge pull request #6990 from CBSkarmory/dev
fix typo / reword part of bug report template
2021-08-30 15:51:47 +02:00
litetex a825253b7f
Using integrated cache in ``actions/setup-java``
https://github.com/actions/setup-java#caching-gradle-dependencies
2021-08-28 15:22:04 +02:00
litetex 05f6ea6401
Using Eclipse ``temurin``
as AdoptOpenJDK is getting deprecated.

Eclipse ``temurin`` is a defacto renamed AdoptOpenJDK.

Ref:
* https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/
* https://github.com/actions/setup-java#supported-distributions
2021-08-27 15:21:48 +02:00
George T 4cd7c42b9e
fix typo / reword part of bug report template 2021-08-26 19:02:50 -05:00
litetex 36e72d5a41
Update ci.yml
Using Java 11
2021-08-25 17:05:10 +02:00
Mohammed Anas 71610a365f
Make workflow run daily instead of hourly 2021-08-19 21:08:23 +00:00
mhmdanas 44860f2ea7 Add no-response workflow 2021-08-19 00:46:31 +03:00
XiangRongLin 52cc3f10c1 Add gradle parameter to skip formatKtLint and use in CI 2021-08-06 18:11:22 +02:00
litetex 12e46e0a36
Allow manual execution of ci workflow (#6809) 2021-08-04 17:00:15 +00:00
Mohammed Anas c7f75bf7d1
Ignore paths unrelated to builds in CI (#6789) 2021-08-02 13:29:39 +00:00
litetex 903296014a
Check formatting of kotlin files in CI 2021-07-28 21:03:51 +02:00
XiangRongLin c422f65935
Readd api level 29 to android CI tests
The action got fixed and released https://github.com/ReactiveCircus/android-emulator-runner/releases/tag/v2.19.1
2021-07-20 18:28:46 +02:00
Stypox bec8512c7b
Merge pull request #6659 from TeamNewPipe/Redirion-kotlin-section
Added a Kotlin section in CONTRIBUTING.md
2021-07-19 11:54:48 +02:00
XiangRongLin d3375a921d
Remove api level 29 from android ci tests 2021-07-16 10:19:58 +02:00
Robin a2eb810df0
removed Extractor line 2021-07-14 13:23:01 +02:00
Robin 6e576a165c
Added a Kotlin section in CONTRIBUTING.md
Core team does not want to convert to Kotlin yet and sees Java as the easier to learn and more well adopted language.

This stance might of course change in the future. For example it could be reasonable to do a complete transition to Kotlin once it is decides that the minSdk is raised to 21 or higher, as we then could use Jetpack particularly Lifecycle and Compose.
2021-07-14 13:08:07 +02:00
Tobi 4d5b68792b
Merge pull request #6560 from TeamNewPipe/fix_ci_emulator
Specify emulator-build version in CI job
2021-07-12 16:16:06 +02:00
Tobi a73a4afcad
Fix APK testing section (#6623)
* Fix APK testing section

Correct the instructions to download a test APK

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
2021-07-09 14:47:44 +00:00
litetex 09435a1b63
Update bug_report.md
Fixed a typo / made the wording consistent
2021-07-06 21:45:15 +02:00
XiangRongLin 9c636f5ee2 Specify emulator-build version in CI job
This is a workaround for the emulator bug https://github.com/ReactiveCircus/android-emulator-runner/issues/160
2021-07-06 16:26:01 +02:00
Mohammed Anas d8a0a74d47
Allow asking multiple questions at once 2021-07-05 13:12:54 +00:00
mhmdanas 23f6e1084b Add question template 2021-07-02 00:31:20 +03:00
bopol c398308872
Merge pull request #6539 from TeamNewPipe/screenshots_for_UI_changes
Ask for screenshots/video of UI changes in PR template
2021-06-24 17:25:15 +02:00
opusforlife2 090c063644
Address Bopol's review
Changed the location, added option to delete, and also fixed a tiny grammar thingy.
2021-06-24 15:15:12 +00:00
opusforlife2 ec40c8ed1e
Merge pull request #6482 from Stypox/build-instructions
Update Build instructions to make it easier for contributors to start contributing.
2021-06-24 15:02:59 +00:00
Stypox 25914b0263
Third round of review 2021-06-24 10:46:53 +02:00
XiangRongLin b996fa7eef Add comments explaining decisions in test-android ci job 2021-06-23 20:16:23 +02:00
XiangRongLin 5ebf3726ed Comment out test-android CI job 2021-06-23 20:14:27 +02:00
opusforlife2 a9e85abd7f
Ask for screenshots/video of UI changes
If the PR author has changed the UI of the app, they should include screenshots or a video so that developers and users alike can pinpoint exactly what changed.
2021-06-20 21:15:25 +00:00
Stypox 0db3406ad8
Fix SonarLint references and explanation 2021-06-18 12:26:50 +02:00
Stypox 8b3e32b6eb
First round of review 2021-06-17 20:47:22 +02:00
Stypox 6063ff063b
CONTRIBUTING.md: add "Build instructions" section and improve ordering 2021-06-13 21:06:59 +02:00
Tobi 81d00f2e97
Run CI on PRs which target the master branch
This is a fix for the release PRs
2021-06-05 17:34:27 +02:00
TiA4f8R fe7536e374
Change NewPipe IRC links in the contribution guidelines (#6415)
* Change NewPipe IRC links in the contribution guidelines

* Remove redundant line break

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2021-06-02 16:27:08 +00:00