be-gay-do-crimes
/
NewPipeExtractor
mirror of https://github.com/TeamNewPipe/NewPipeExtractor
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve YouTubeSearchPagingtest

This commit is contained in:
TobiGr 2019-12-31 00:18:53 +01:00
parent 64729e5357
commit 0b6e37e71f
1 changed files with 10 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
extractor/src/test/java/org/schabi/newpipe/extractor/services/youtube/search/YoutubeSearchPagingTest.java
View File

@ -24,7 +24,8 @@ public class YoutubeSearchPagingTest {
private static ListExtractor.InfoItemsPage<InfoItem> page2; private static ListExtractor.InfoItemsPage<InfoItem> page2;
private static Set<String> urlList1; private static Set<String> urlList1;
private static Set<String> urlList2; private static Set<String> urlList2;
private static int pageSize; private static int page1Size;
private static int page2Size;
@BeforeClass @BeforeClass
public static void setUpClass() throws Exception { public static void setUpClass() throws Exception {
@ -36,14 +37,15 @@ public class YoutubeSearchPagingTest {
extractor.fetchPage(); extractor.fetchPage();
page1 = extractor.getInitialPage(); page1 = extractor.getInitialPage();
urlList1 = extractUrls(page1.getItems()); urlList1 = extractUrls(page1.getItems());
assertTrue("page with items loaded", 15 < page1.getItems().size()); assertTrue("failed to load search result page one: too few items", 15 < page1.getItems().size());
pageSize = page1.getItems().size(); page1Size = page1.getItems().size();
assertEquals("they are all distinct, no repetition", pageSize, urlList1.size()); assertEquals("duplicated items in search result on page one", page1Size, urlList1.size());
assertTrue("has more than one page of results", page1.hasNextPage()); assertTrue("search result has no second page", page1.hasNextPage());
assertNotNull("has next page url", page1.getNextPageUrl()); assertNotNull("next page url is null", page1.getNextPageUrl());
page2 = extractor.getPage(page1.getNextPageUrl()); page2 = extractor.getPage(page1.getNextPageUrl());
urlList2 = extractUrls(page2.getItems()); urlList2 = extractUrls(page2.getItems());
page2Size = page2.getItems().size();
} }
private static Set<String> extractUrls(List<InfoItem> list) { private static Set<String> extractUrls(List<InfoItem> list) {
@ -54,27 +56,16 @@ public class YoutubeSearchPagingTest {
return result; return result;
} }
@Test
public void firstPageOk() {
assertTrue("first page contains the expected number of items", 15 < page1.getItems().size());
assertEquals("they are all distinct, no repetition", pageSize, urlList1.size());
}
@Test
public void secondPageLength() {
assertEquals("second page contains only the expected number of items", pageSize, page2.getItems().size());
}
@Test @Test
public void secondPageUniqueVideos() { public void secondPageUniqueVideos() {
assertEquals("they are all distinct, no repetition", pageSize, urlList2.size()); assertEquals("Second search result page has duplicated items", page2Size, urlList2.size());
} }
@Test @Test
public void noRepeatingVideosInPages() { public void noRepeatingVideosInPages() {
Set<String> intersection = new HashSet<>(urlList2); Set<String> intersection = new HashSet<>(urlList2);
intersection.retainAll(urlList1); intersection.retainAll(urlList1);
assertEquals("Found a duplicated video on second search page", 0, intersection.size()); assertEquals("Found the same item on first AND second search page", 0, intersection.size());
} }
} }