Merge pull request #1236 from Thompson3142/fix_scrubbing_seekbar_preview_crash
Add documentation for faulty framesets
This commit is contained in:
commit
c343e31ed2
|
@ -1377,6 +1377,20 @@ public class YoutubeStreamExtractor extends StreamExtractor {
|
||||||
return itagInfo;
|
return itagInfo;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
/**
|
||||||
|
* {@inheritDoc}
|
||||||
|
* Should return a list of Frameset object that contains preview of stream frames
|
||||||
|
*
|
||||||
|
* <p><b>Warning:</b> When using this method be aware
|
||||||
|
* that the YouTube API very rarely returns framesets,
|
||||||
|
* that are slightly too small e.g. framesPerPageX = 5, frameWidth = 160, but the url contains
|
||||||
|
* a storyboard that is only 795 pixels wide (5*160 > 795). You will need to handle this
|
||||||
|
* "manually" to avoid errors.</p>
|
||||||
|
*
|
||||||
|
* @see <a href="https://github.com/TeamNewPipe/NewPipe/pull/11596">
|
||||||
|
* TeamNewPipe/NewPipe#11596</a>
|
||||||
|
*/
|
||||||
@Nonnull
|
@Nonnull
|
||||||
@Override
|
@Override
|
||||||
public List<Frameset> getFrames() throws ExtractionException {
|
public List<Frameset> getFrames() throws ExtractionException {
|
||||||
|
|
Loading…
Reference in New Issue