be-gay-do-crimes
/
NewPipeExtractor
mirror of https://github.com/TeamNewPipe/NewPipeExtractor
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #807 from FireMasterK/no-commentsinfo-instance 

Remove the need for a CommentsInfo instance in CommentsInfo.getMoreItems and fix PeertubeCommentsExtractorTest.Default test
This commit is contained in:
litetex 2022-03-15 15:06:56 +01:00 committed by GitHub
parent d806984aa8 60cc71e944
commit e7aee0ca57
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
extractor/src/main/java/org/schabi/newpipe/extractor/comments/CommentsInfo.java
View File

@ -56,18 +56,21 @@ public class CommentsInfo extends ListInfo<CommentsInfoItem> {
public static InfoItemsPage<CommentsInfoItem> getMoreItems( public static InfoItemsPage<CommentsInfoItem> getMoreItems(
final CommentsInfo commentsInfo, final CommentsInfo commentsInfo,
final Page page) throws ExtractionException, IOException { final Page page) throws ExtractionException, IOException {
return getMoreItems(NewPipe.getService(commentsInfo.getServiceId()), commentsInfo, page); return getMoreItems(NewPipe.getService(commentsInfo.getServiceId()), commentsInfo.getUrl(), page);
} }
public static InfoItemsPage<CommentsInfoItem> getMoreItems( public static InfoItemsPage<CommentsInfoItem> getMoreItems(
final StreamingService service, final StreamingService service,
final CommentsInfo commentsInfo, final CommentsInfo commentsInfo,
final Page page) throws IOException, ExtractionException { final Page page) throws IOException, ExtractionException {
if (commentsInfo.getCommentsExtractor() == null) { return getMoreItems(service, commentsInfo.getUrl(), page);
commentsInfo.setCommentsExtractor(service.getCommentsExtractor(commentsInfo.getUrl())); }
commentsInfo.getCommentsExtractor().fetchPage();
} public static InfoItemsPage<CommentsInfoItem> getMoreItems(
return commentsInfo.getCommentsExtractor().getPage(page); final StreamingService service,
final String url,
final Page page) throws IOException, ExtractionException {
return service.getCommentsExtractor(url).getPage(page);
} }
private transient CommentsExtractor commentsExtractor; private transient CommentsExtractor commentsExtractor;

12
extractor/src/test/java/org/schabi/newpipe/extractor/services/peertube/PeertubeCommentsExtractorTest.java
View File

@ -28,17 +28,17 @@ public class PeertubeCommentsExtractorTest {
public static void setUp() throws Exception { public static void setUp() throws Exception {
NewPipe.init(DownloaderTestImpl.getInstance()); NewPipe.init(DownloaderTestImpl.getInstance());
extractor = (PeertubeCommentsExtractor) PeerTube extractor = (PeertubeCommentsExtractor) PeerTube
.getCommentsExtractor("https://framatube.org/videos/watch/04af977f-4201-4697-be67-a8d8cae6fa7a"); .getCommentsExtractor("https://framatube.org/videos/watch/9c9de5e8-0a1e-484a-b099-e80766180a6d");
} }
@Test @Test
public void testGetComments() throws IOException, ExtractionException { public void testGetComments() throws IOException, ExtractionException {
InfoItemsPage<CommentsInfoItem> comments = extractor.getInitialPage(); InfoItemsPage<CommentsInfoItem> comments = extractor.getInitialPage();
boolean result = findInComments(comments, "@root A great documentary on a great guy."); boolean result = findInComments(comments, "Cool.");
while (comments.hasNextPage() && !result) { while (comments.hasNextPage() && !result) {
comments = extractor.getPage(comments.getNextPage()); comments = extractor.getPage(comments.getNextPage());
result = findInComments(comments, "@root A great documentary on a great guy."); result = findInComments(comments, "Cool.");
} }
assertTrue(result); assertTrue(result);
@ -46,16 +46,16 @@ public class PeertubeCommentsExtractorTest {
@Test @Test
public void testGetCommentsFromCommentsInfo() throws IOException, ExtractionException { public void testGetCommentsFromCommentsInfo() throws IOException, ExtractionException {
CommentsInfo commentsInfo = CommentsInfo.getInfo("https://framatube.org/videos/watch/a8ea95b8-0396-49a6-8f30-e25e25fb2828"); CommentsInfo commentsInfo = CommentsInfo.getInfo("https://framatube.org/videos/watch/217eefeb-883d-45be-b7fc-a788ad8507d3");
assertEquals("Comments", commentsInfo.getName()); assertEquals("Comments", commentsInfo.getName());
boolean result = findInComments(commentsInfo.getRelatedItems(), "Loved it!!!"); boolean result = findInComments(commentsInfo.getRelatedItems(), "Cool");
Page nextPage = commentsInfo.getNextPage(); Page nextPage = commentsInfo.getNextPage();
InfoItemsPage<CommentsInfoItem> moreItems = new InfoItemsPage<>(null, nextPage, null); InfoItemsPage<CommentsInfoItem> moreItems = new InfoItemsPage<>(null, nextPage, null);
while (moreItems.hasNextPage() && !result) { while (moreItems.hasNextPage() && !result) {
moreItems = CommentsInfo.getMoreItems(PeerTube, commentsInfo, nextPage); moreItems = CommentsInfo.getMoreItems(PeerTube, commentsInfo, nextPage);
result = findInComments(moreItems.getItems(), "Loved it!!!"); result = findInComments(moreItems.getItems(), "Cool");
nextPage = moreItems.getNextPage(); nextPage = moreItems.getNextPage();
} }