2017-10-13 19:31:05 +00:00
|
|
|
// @flow
|
|
|
|
|
|
|
|
import { JitsiTrackErrors } from '../lib-jitsi-meet';
|
2018-08-16 15:11:06 +00:00
|
|
|
import {
|
|
|
|
getLocalParticipant,
|
|
|
|
hiddenParticipantJoined,
|
|
|
|
hiddenParticipantLeft,
|
|
|
|
participantJoined,
|
|
|
|
participantLeft
|
|
|
|
} from '../participants';
|
2017-10-13 19:31:05 +00:00
|
|
|
import { toState } from '../redux';
|
|
|
|
|
2017-10-06 17:52:23 +00:00
|
|
|
import {
|
|
|
|
AVATAR_ID_COMMAND,
|
|
|
|
AVATAR_URL_COMMAND,
|
fix(base/participants): ensure default local id outside of conference
Makes sure that whenever a conference is left or switched, the local
participant's id will be equal to the default value.
The problem fixed by this commit is a situation where the local
participant may end up sharing the same ID with it's "ghost" when
rejoining a disconnected conference. The most important and easiest to
hit case is when the conference is left after the CONFERENCE_FAILED
event.
Another rare and harder to encounter in the real world issue is
where CONFERENCE_LEFT may come with the delay due to it's asynchronous
nature. The step by step scenario is as follows: trying to leave a
conference, but the network is not doing well, so it takes time,
requests are timing out. After getting back to the welcome page the
the CONFERENCE_LEFT has not arrived yet. The same conference is joined
again and the load config may timeout, but it will be read from the
cache. Now the network gets better and conference is joining which
results in our ghost participant added to the redux state. At this point
there's the root issue: two participants with the same id, because the
local one was neither cleared nor set to the new one yet
(PARTICIPANT_JOINED come, before CONFERENCE_JOINED where we adjust the
id). Then comes CONFERENCE_JOINED and we try to update our local id.
We're updating the ID of both ghost and local participant. It could be
also that the delayed CONFERENCE_LEFT comes for the old conference, but
it's too late and it would update the id for both participants.
The approach here reasons that the ID of the local participant
may be reset as soon as the local participant and, respectively, her ID
is no longer involved in a recoverable JitsiConference of interest to
the user and, consequently, the app.
Co-authored-by: Pawel Domas <pawel.domas@jitsi.org>
Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com>
2018-05-16 20:08:34 +00:00
|
|
|
EMAIL_COMMAND,
|
2018-08-08 18:48:23 +00:00
|
|
|
JITSI_CONFERENCE_URL_KEY,
|
|
|
|
VIDEO_QUALITY_LEVELS
|
2017-10-06 17:52:23 +00:00
|
|
|
} from './constants';
|
2016-10-05 14:36:59 +00:00
|
|
|
|
2018-07-30 14:38:25 +00:00
|
|
|
const logger = require('jitsi-meet-logger').getLogger(__filename);
|
|
|
|
|
2016-10-05 14:36:59 +00:00
|
|
|
/**
|
|
|
|
* Attach a set of local tracks to a conference.
|
|
|
|
*
|
|
|
|
* @param {JitsiConference} conference - Conference instance.
|
|
|
|
* @param {JitsiLocalTrack[]} localTracks - List of local media tracks.
|
2017-09-28 21:25:04 +00:00
|
|
|
* @protected
|
2016-10-05 14:36:59 +00:00
|
|
|
* @returns {Promise}
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function _addLocalTracksToConference(
|
|
|
|
conference: { addTrack: Function, getLocalTracks: Function },
|
|
|
|
localTracks: Array<Object>) {
|
2016-10-05 14:36:59 +00:00
|
|
|
const conferenceLocalTracks = conference.getLocalTracks();
|
|
|
|
const promises = [];
|
|
|
|
|
|
|
|
for (const track of localTracks) {
|
|
|
|
// XXX The library lib-jitsi-meet may be draconian, for example, when
|
|
|
|
// adding one and the same video track multiple times.
|
|
|
|
if (conferenceLocalTracks.indexOf(track) === -1) {
|
2017-02-15 17:19:36 +00:00
|
|
|
promises.push(
|
|
|
|
conference.addTrack(track).catch(err => {
|
2016-10-05 14:36:59 +00:00
|
|
|
_reportError(
|
|
|
|
'Failed to add local track to conference',
|
|
|
|
err);
|
|
|
|
}));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return Promise.all(promises);
|
|
|
|
}
|
|
|
|
|
2018-08-16 15:11:06 +00:00
|
|
|
/**
|
|
|
|
* Logic shared between web and RN which processes the {@code USER_JOINED}
|
|
|
|
* conference event and dispatches either {@link participantJoined} or
|
|
|
|
* {@link hiddenParticipantJoined}.
|
|
|
|
*
|
|
|
|
* @param {Object} store - The redux store.
|
|
|
|
* @param {JitsiMeetConference} conference - The conference for which the
|
|
|
|
* {@code USER_JOINED} event is being processed.
|
|
|
|
* @param {JitsiParticipant} user - The user who has just joined.
|
|
|
|
* @returns {void}
|
|
|
|
*/
|
|
|
|
export function commonUserJoinedHandling(
|
|
|
|
{ dispatch }: Object,
|
|
|
|
conference: Object,
|
|
|
|
user: Object) {
|
|
|
|
const id = user.getId();
|
|
|
|
const displayName = user.getDisplayName();
|
|
|
|
|
|
|
|
if (user.isHidden()) {
|
|
|
|
dispatch(hiddenParticipantJoined(id, displayName));
|
|
|
|
} else {
|
|
|
|
dispatch(participantJoined({
|
|
|
|
botType: user.getBotType(),
|
|
|
|
conference,
|
|
|
|
id,
|
|
|
|
name: displayName,
|
|
|
|
presence: user.getStatus(),
|
|
|
|
role: user.getRole()
|
|
|
|
}));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Logic shared between web and RN which processes the {@code USER_LEFT}
|
|
|
|
* conference event and dispatches either {@link participantLeft} or
|
|
|
|
* {@link hiddenParticipantLeft}.
|
|
|
|
*
|
|
|
|
* @param {Object} store - The redux store.
|
|
|
|
* @param {JitsiMeetConference} conference - The conference for which the
|
|
|
|
* {@code USER_LEFT} event is being processed.
|
|
|
|
* @param {JitsiParticipant} user - The user who has just left.
|
|
|
|
* @returns {void}
|
|
|
|
*/
|
|
|
|
export function commonUserLeftHandling(
|
|
|
|
{ dispatch }: Object,
|
|
|
|
conference: Object,
|
|
|
|
user: Object) {
|
|
|
|
const id = user.getId();
|
|
|
|
|
|
|
|
if (user.isHidden()) {
|
|
|
|
dispatch(hiddenParticipantLeft(id));
|
|
|
|
} else {
|
|
|
|
dispatch(participantLeft(id, conference));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
fix(base/participants): ensure default local id outside of conference
Makes sure that whenever a conference is left or switched, the local
participant's id will be equal to the default value.
The problem fixed by this commit is a situation where the local
participant may end up sharing the same ID with it's "ghost" when
rejoining a disconnected conference. The most important and easiest to
hit case is when the conference is left after the CONFERENCE_FAILED
event.
Another rare and harder to encounter in the real world issue is
where CONFERENCE_LEFT may come with the delay due to it's asynchronous
nature. The step by step scenario is as follows: trying to leave a
conference, but the network is not doing well, so it takes time,
requests are timing out. After getting back to the welcome page the
the CONFERENCE_LEFT has not arrived yet. The same conference is joined
again and the load config may timeout, but it will be read from the
cache. Now the network gets better and conference is joining which
results in our ghost participant added to the redux state. At this point
there's the root issue: two participants with the same id, because the
local one was neither cleared nor set to the new one yet
(PARTICIPANT_JOINED come, before CONFERENCE_JOINED where we adjust the
id). Then comes CONFERENCE_JOINED and we try to update our local id.
We're updating the ID of both ghost and local participant. It could be
also that the delayed CONFERENCE_LEFT comes for the old conference, but
it's too late and it would update the id for both participants.
The approach here reasons that the ID of the local participant
may be reset as soon as the local participant and, respectively, her ID
is no longer involved in a recoverable JitsiConference of interest to
the user and, consequently, the app.
Co-authored-by: Pawel Domas <pawel.domas@jitsi.org>
Co-authored-by: Lyubo Marinov <lmarinov@atlassian.com>
2018-05-16 20:08:34 +00:00
|
|
|
/**
|
|
|
|
* Evaluates a specific predicate for each {@link JitsiConference} known to the
|
|
|
|
* redux state features/base/conference while it returns {@code true}.
|
|
|
|
*
|
|
|
|
* @param {Function | Object} stateful - The redux store, state, or
|
|
|
|
* {@code getState} function.
|
|
|
|
* @param {Function} predicate - The predicate to evaluate for each
|
|
|
|
* {@code JitsiConference} know to the redux state features/base/conference
|
|
|
|
* while it returns {@code true}.
|
|
|
|
* @returns {boolean} If the specified {@code predicate} returned {@code true}
|
|
|
|
* for all {@code JitsiConference} instances known to the redux state
|
|
|
|
* features/base/conference.
|
|
|
|
*/
|
|
|
|
export function forEachConference(
|
|
|
|
stateful: Function | Object,
|
|
|
|
predicate: (Object, URL) => boolean) {
|
|
|
|
const state = toState(stateful)['features/base/conference'];
|
|
|
|
|
|
|
|
for (const v of Object.values(state)) {
|
|
|
|
// Does the value of the base/conference's property look like a
|
|
|
|
// JitsiConference?
|
|
|
|
if (v && typeof v === 'object') {
|
|
|
|
// $FlowFixMe
|
|
|
|
const url: URL = v[JITSI_CONFERENCE_URL_KEY];
|
|
|
|
|
|
|
|
// XXX The Web version of Jitsi Meet does not utilize
|
|
|
|
// JITSI_CONFERENCE_URL_KEY at the time of this writing. An
|
|
|
|
// alternative is necessary then to recognize JitsiConference
|
|
|
|
// instances and myUserId is as good as any other property.
|
|
|
|
if ((url || typeof v.myUserId === 'function')
|
|
|
|
&& !predicate(v, url)) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2019-01-30 15:43:57 +00:00
|
|
|
/**
|
|
|
|
* Returns the display name of the conference.
|
|
|
|
*
|
|
|
|
* @param {Function | Object} stateful - Reference that can be resolved to Redux
|
|
|
|
* state with the {@code toState} function.
|
|
|
|
* @returns {string}
|
|
|
|
*/
|
|
|
|
export function getConferenceName(stateful: Function | Object): string {
|
|
|
|
const state = toState(stateful);
|
|
|
|
const { callee } = state['features/base/jwt'];
|
|
|
|
|
|
|
|
return state['features/base/config'].callDisplayName
|
|
|
|
|| (callee && callee.name)
|
|
|
|
|| state['features/base/conference'].room;
|
|
|
|
}
|
|
|
|
|
2017-09-28 21:25:04 +00:00
|
|
|
/**
|
|
|
|
* Returns the current {@code JitsiConference} which is joining or joined and is
|
|
|
|
* not leaving. Please note the contrast with merely reading the
|
|
|
|
* {@code conference} state of the feature base/conference which is not joining
|
|
|
|
* but may be leaving already.
|
|
|
|
*
|
|
|
|
* @param {Function|Object} stateful - The redux store, state, or
|
|
|
|
* {@code getState} function.
|
|
|
|
* @returns {JitsiConference|undefined}
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function getCurrentConference(stateful: Function | Object) {
|
2017-09-28 21:25:04 +00:00
|
|
|
const { conference, joining, leaving }
|
|
|
|
= toState(stateful)['features/base/conference'];
|
|
|
|
|
|
|
|
return (
|
|
|
|
conference
|
|
|
|
? conference === leaving ? undefined : conference
|
|
|
|
: joining);
|
|
|
|
}
|
|
|
|
|
2018-08-08 18:48:23 +00:00
|
|
|
/**
|
|
|
|
* Finds the nearest match for the passed in {@link availableHeight} to am
|
|
|
|
* enumerated value in {@code VIDEO_QUALITY_LEVELS}.
|
|
|
|
*
|
|
|
|
* @param {number} availableHeight - The height to which a matching video
|
|
|
|
* quality level should be found.
|
|
|
|
* @returns {number} The closest matching value from
|
|
|
|
* {@code VIDEO_QUALITY_LEVELS}.
|
|
|
|
*/
|
|
|
|
export function getNearestReceiverVideoQualityLevel(availableHeight: number) {
|
|
|
|
const qualityLevels = [
|
|
|
|
VIDEO_QUALITY_LEVELS.HIGH,
|
|
|
|
VIDEO_QUALITY_LEVELS.STANDARD,
|
|
|
|
VIDEO_QUALITY_LEVELS.LOW
|
|
|
|
];
|
|
|
|
|
|
|
|
let selectedLevel = qualityLevels[0];
|
|
|
|
|
|
|
|
for (let i = 1; i < qualityLevels.length; i++) {
|
|
|
|
const previousValue = qualityLevels[i - 1];
|
|
|
|
const currentValue = qualityLevels[i];
|
|
|
|
const diffWithCurrent = Math.abs(availableHeight - currentValue);
|
|
|
|
const diffWithPrevious = Math.abs(availableHeight - previousValue);
|
|
|
|
|
|
|
|
if (diffWithCurrent < diffWithPrevious) {
|
|
|
|
selectedLevel = currentValue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return selectedLevel;
|
|
|
|
}
|
|
|
|
|
2016-10-05 14:36:59 +00:00
|
|
|
/**
|
2018-11-08 12:25:02 +00:00
|
|
|
* Handle an error thrown by the backend (i.e. {@code lib-jitsi-meet}) while
|
|
|
|
* manipulating a conference participant (e.g. Pin or select participant).
|
2016-10-05 14:36:59 +00:00
|
|
|
*
|
|
|
|
* @param {Error} err - The Error which was thrown by the backend while
|
|
|
|
* manipulating a conference participant and which is to be handled.
|
2017-09-28 21:25:04 +00:00
|
|
|
* @protected
|
2016-10-05 14:36:59 +00:00
|
|
|
* @returns {void}
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function _handleParticipantError(err: { message: ?string }) {
|
2016-10-05 14:36:59 +00:00
|
|
|
// XXX DataChannels are initialized at some later point when the conference
|
|
|
|
// has multiple participants, but code that pins or selects a participant
|
|
|
|
// might be executed before. So here we're swallowing a particular error.
|
|
|
|
// TODO Lib-jitsi-meet should be fixed to not throw such an exception in
|
|
|
|
// these scenarios.
|
|
|
|
if (err.message !== 'Data channels support is disabled!') {
|
|
|
|
throw err;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Determines whether a specific string is a valid room name.
|
|
|
|
*
|
|
|
|
* @param {(string|undefined)} room - The name of the conference room to check
|
|
|
|
* for validity.
|
|
|
|
* @returns {boolean} If the specified room name is valid, then true; otherwise,
|
|
|
|
* false.
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function isRoomValid(room: ?string) {
|
2016-10-05 14:36:59 +00:00
|
|
|
return typeof room === 'string' && room !== '';
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Remove a set of local tracks from a conference.
|
|
|
|
*
|
|
|
|
* @param {JitsiConference} conference - Conference instance.
|
|
|
|
* @param {JitsiLocalTrack[]} localTracks - List of local media tracks.
|
2017-09-28 21:25:04 +00:00
|
|
|
* @protected
|
2016-10-05 14:36:59 +00:00
|
|
|
* @returns {Promise}
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function _removeLocalTracksFromConference(
|
|
|
|
conference: { removeTrack: Function },
|
|
|
|
localTracks: Array<Object>) {
|
2016-10-05 14:36:59 +00:00
|
|
|
return Promise.all(localTracks.map(track =>
|
|
|
|
conference.removeTrack(track)
|
|
|
|
.catch(err => {
|
|
|
|
// Local track might be already disposed by direct
|
|
|
|
// JitsiTrack#dispose() call. So we should ignore this error
|
|
|
|
// here.
|
|
|
|
if (err.name !== JitsiTrackErrors.TRACK_IS_DISPOSED) {
|
|
|
|
_reportError(
|
|
|
|
'Failed to remove local track from conference',
|
|
|
|
err);
|
|
|
|
}
|
|
|
|
})
|
|
|
|
));
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Reports a specific Error with a specific error message. While the
|
|
|
|
* implementation merely logs the specified msg and err via the console at the
|
|
|
|
* time of this writing, the intention of the function is to abstract the
|
|
|
|
* reporting of errors and facilitate elaborating on it in the future.
|
|
|
|
*
|
|
|
|
* @param {string} msg - The error message to report.
|
|
|
|
* @param {Error} err - The Error to report.
|
|
|
|
* @private
|
|
|
|
* @returns {void}
|
|
|
|
*/
|
|
|
|
function _reportError(msg, err) {
|
|
|
|
// TODO This is a good point to call some global error handler when we have
|
|
|
|
// one.
|
2018-07-30 14:38:25 +00:00
|
|
|
logger.error(msg, err);
|
2016-10-05 14:36:59 +00:00
|
|
|
}
|
2017-10-06 17:52:23 +00:00
|
|
|
|
|
|
|
/**
|
2017-10-13 19:31:05 +00:00
|
|
|
* Sends a representation of the local participant such as her avatar (URL),
|
|
|
|
* e-mail address, and display name to (the remote participants of) a specific
|
|
|
|
* conference.
|
2017-10-06 17:52:23 +00:00
|
|
|
*
|
2017-10-13 19:31:05 +00:00
|
|
|
* @param {Function|Object} stateful - The redux store, state, or
|
|
|
|
* {@code getState} function.
|
|
|
|
* @param {JitsiConference} conference - The {@code JitsiConference} to which
|
|
|
|
* the representation of the local participant is to be sent.
|
2017-10-06 17:52:23 +00:00
|
|
|
* @returns {void}
|
|
|
|
*/
|
2017-10-13 19:31:05 +00:00
|
|
|
export function sendLocalParticipant(
|
|
|
|
stateful: Function | Object,
|
2018-06-15 18:10:22 +00:00
|
|
|
conference: {
|
|
|
|
sendCommand: Function,
|
|
|
|
setDisplayName: Function,
|
|
|
|
setLocalParticipantProperty: Function }) {
|
|
|
|
const {
|
|
|
|
avatarID,
|
|
|
|
avatarURL,
|
|
|
|
email,
|
|
|
|
features,
|
|
|
|
name
|
|
|
|
} = getLocalParticipant(stateful);
|
2017-10-06 17:52:23 +00:00
|
|
|
|
|
|
|
avatarID && conference.sendCommand(AVATAR_ID_COMMAND, {
|
|
|
|
value: avatarID
|
|
|
|
});
|
|
|
|
avatarURL && conference.sendCommand(AVATAR_URL_COMMAND, {
|
|
|
|
value: avatarURL
|
|
|
|
});
|
|
|
|
email && conference.sendCommand(EMAIL_COMMAND, {
|
|
|
|
value: email
|
|
|
|
});
|
2018-06-15 18:10:22 +00:00
|
|
|
|
|
|
|
if (features && features['screen-sharing'] === 'true') {
|
|
|
|
conference.setLocalParticipantProperty('features_screen-sharing', true);
|
|
|
|
}
|
|
|
|
|
2017-10-06 17:52:23 +00:00
|
|
|
conference.setDisplayName(name);
|
|
|
|
}
|