haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #481 from isymchych/fix-pinning 

Do not pin participant if moderator clicked item in remote user menu
This commit is contained in:
Paweł Domas 2016-01-29 13:44:46 -06:00
parent 1176390214 93aac798f3
commit 04858e7f06
2 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
conference.js
View File

@ -111,7 +111,7 @@ class ConferenceConnector {
this._reject(err); this._reject(err);
} }
_onConferenceFailed(err, ...params) { _onConferenceFailed(err, ...params) {
console.error('CONFERENCE FAILED:', err, params); console.error('CONFERENCE FAILED:', err, ...params);
switch (err) { switch (err) {
// room is locked by the password // room is locked by the password
case ConferenceErrors.PASSWORD_REQUIRED: case ConferenceErrors.PASSWORD_REQUIRED:

15
modules/UI/videolayout/RemoteVideo.js
View File

@ -86,13 +86,12 @@ if (!interfaceConfig.filmStripOnly) {
muteLinkItem.className = 'mutelink disabled'; muteLinkItem.className = 'mutelink disabled';
} }
var self = this; muteLinkItem.onclick = (event) => {
muteLinkItem.onclick = function(){
if ($(this).attr('disabled')) { if ($(this).attr('disabled')) {
event.preventDefault(); event.preventDefault();
} }
var isMute = !!self.isMuted; var isMute = !!this.isMuted;
self.emitter.emit(UIEvents.REMOTE_AUDIO_MUTED, self.id); this.emitter.emit(UIEvents.REMOTE_AUDIO_MUTED, this.id);
popupmenuElement.setAttribute('style', 'display:none;'); popupmenuElement.setAttribute('style', 'display:none;');
@ -120,8 +119,8 @@ if (!interfaceConfig.filmStripOnly) {
var ejectText = "<div style='width: 90px;margin-left: 20px;' " + var ejectText = "<div style='width: 90px;margin-left: 20px;' " +
"data-i18n='videothumbnail.kick'>&nbsp;</div>"; "data-i18n='videothumbnail.kick'>&nbsp;</div>";
ejectLinkItem.innerHTML = ejectIndicator + ' ' + ejectText; ejectLinkItem.innerHTML = ejectIndicator + ' ' + ejectText;
ejectLinkItem.onclick = function(){ ejectLinkItem.onclick = (event) => {
self.emitter.emit(UIEvents.USER_KICKED, self.id); this.emitter.emit(UIEvents.USER_KICKED, this.id);
popupmenuElement.setAttribute('style', 'display:none;'); popupmenuElement.setAttribute('style', 'display:none;');
}; };
@ -224,8 +223,12 @@ RemoteVideo.prototype.addRemoteStreamElement = function (stream) {
// Add click handler. // Add click handler.
let onClickHandler = (event) => { let onClickHandler = (event) => {
let source = event.target || event.srcElement;
// ignore click if it was done in popup menu
if ($(source).parents('.popupmenu').length === 0) {
this.VideoLayout.handleVideoThumbClicked(false, this.id); this.VideoLayout.handleVideoThumbClicked(false, this.id);
}
// On IE we need to populate this handler on video <object> // On IE we need to populate this handler on video <object>
// and it does not give event instance as an argument, // and it does not give event instance as an argument,