haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style(iframe_api): Adds _ for every non public property

This commit is contained in:
hristoterezov 2017-07-13 13:20:00 -05:00 committed by yanas
parent cc6fcfd982
commit 07158e8071
1 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
modules/API/external/external_api.js vendored
View File

@ -67,7 +67,7 @@ const MIN_WIDTH = 790;
* @returns {void} * @returns {void}
*/ */
function changeParticipantNumber(APIInstance, number) { function changeParticipantNumber(APIInstance, number) {
APIInstance.numberOfParticipants += number; APIInstance._numberOfParticipants += number;
} }
/** /**
@ -174,8 +174,8 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
noSSL = false, noSSL = false,
jwt = undefined) { jwt = undefined) {
super(); super();
this.parentNode = parentNode; this._parentNode = parentNode;
this.url = generateURL(domain, { this._url = generateURL(domain, {
configOverwrite, configOverwrite,
interfaceConfigOverwrite, interfaceConfigOverwrite,
jwt, jwt,
@ -187,11 +187,11 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
backend: new PostMessageTransportBackend({ backend: new PostMessageTransportBackend({
postisOptions: { postisOptions: {
scope: `jitsi_meet_external_api_${id}`, scope: `jitsi_meet_external_api_${id}`,
window: this.frame.contentWindow window: this._frame.contentWindow
} }
}) })
}); });
this.numberOfParticipants = 1; this._numberOfParticipants = 1;
this._setupListeners(); this._setupListeners();
id++; id++;
} }
@ -231,23 +231,23 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
/* eslint-enable no-param-reassign */ /* eslint-enable no-param-reassign */
this.iframeHolder this._iframeHolder
= this.parentNode.appendChild(document.createElement('div')); = this._parentNode.appendChild(document.createElement('div'));
this.iframeHolder.id = `jitsiConference${id}`; this._iframeHolder.id = `jitsiConference${id}`;
this.iframeHolder.style.width = width; this._iframeHolder.style.width = width;
this.iframeHolder.style.height = height; this._iframeHolder.style.height = height;
this.frameName = `jitsiConferenceFrame${id}`; const frameName = `jitsiConferenceFrame${id}`;
this.frame = document.createElement('iframe'); this._frame = document.createElement('iframe');
this.frame.src = this.url; this._frame.src = this._url;
this.frame.name = this.frameName; this._frame.name = frameName;
this.frame.id = this.frameName; this._frame.id = frameName;
this.frame.width = '100%'; this._frame.width = '100%';
this.frame.height = '100%'; this._frame.height = '100%';
this.frame.setAttribute('allowFullScreen', 'true'); this._frame.setAttribute('allowFullScreen', 'true');
this.frame.style.border = 0; this._frame.style.border = 0;
this.frame = this.iframeHolder.appendChild(this.frame); this._frame = this._iframeHolder.appendChild(this._frame);
} }
/** /**
@ -361,8 +361,8 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
dispose() { dispose() {
this._transport.dispose(); this._transport.dispose();
this.removeAllListeners(); this.removeAllListeners();
if (this.iframeHolder) { if (this._iframeHolder) {
this.iframeHolder.parentNode.removeChild(this.iframeHolder); this._iframeHolder._parentNode.removeChild(this._iframeHolder);
} }
} }
@ -419,7 +419,7 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
* @returns {HTMLElement} The iframe. * @returns {HTMLElement} The iframe.
*/ */
getIFrame() { getIFrame() {
return this.frame; return this._frame;
} }
/** /**
@ -429,7 +429,7 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
* @returns {int} The number of participants in the conference. * @returns {int} The number of participants in the conference.
*/ */
getNumberOfParticipants() { getNumberOfParticipants() {
return this.numberOfParticipants; return this._numberOfParticipants;
} }
/** /**