haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updates connection quality popover only if its visible or about to be visible.

This commit is contained in:
damencho 2016-04-09 12:35:54 -05:00
parent 613569ff09
commit 0974e31da1
1 changed files with 22 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
modules/UI/videolayout/ConnectionIndicator.js
View File

@ -270,6 +270,17 @@ ConnectionIndicator.prototype.create = function () {
APP.translation.translateString("connectionindicator.na") + "</div>", APP.translation.translateString("connectionindicator.na") + "</div>",
skin: "black"}); skin: "black"});
// override popover show method to make sure we will update the content
// before showing the popover
var origShowFunc = this.popover.show;
this.popover.show = function () {
// update content by forcing it, to finish even if popover
// is not visible
this.updatePopoverData(true);
// call the original show, passing its actual this
origShowFunc.call(this.popover);
}.bind(this);
this.emptyIcon = this.connectionIndicatorContainer.appendChild( this.emptyIcon = this.connectionIndicatorContainer.appendChild(
createIcon(["connection", "connection_empty"])); createIcon(["connection", "connection_empty"]));
this.fullIcon = this.connectionIndicatorContainer.appendChild( this.fullIcon = this.connectionIndicatorContainer.appendChild(
@ -335,13 +346,18 @@ ConnectionIndicator.prototype.updateResolution = function (resolution) {
}; };
/** /**
* Updates the content of the popover * Updates the content of the popover if its visible
* @param force to work even if popover is not visible
*/ */
ConnectionIndicator.prototype.updatePopoverData = function () { ConnectionIndicator.prototype.updatePopoverData = function (force) {
this.popover.updateContent( // generate content, translate it and add it to document only if
`<div class="connection_info">${this.generateText()}</div>` // popover is visible or we force to do so.
); if(this.popover.popoverShown || force) {
APP.translation.translateElement($(".connection_info")); this.popover.updateContent(
`<div class="connection_info">${this.generateText()}</div>`
);
APP.translation.translateElement($(".connection_info"));
}
}; };
/** /**