haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removes unused parameters, adds documentation.

This commit is contained in:
Boris Grozev 2015-10-01 15:37:28 -05:00
parent c8f52d5fbd
commit 0aa16c6b4c
2 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
modules/xmpp/JingleSessionPC.js
View File

@ -860,7 +860,11 @@ JingleSessionPC.prototype.sendTerminate = function (reason, text) {
}
};
JingleSessionPC.prototype.addSource = function (elem, fromJid) {
/**
* Handles a Jingle source-add message for this Jingle session.
* @param elem An array of Jingle "content" elements.
*/
JingleSessionPC.prototype.addSource = function (elem) {
var self = this;
// FIXME: dirty waiting
@ -869,7 +873,7 @@ JingleSessionPC.prototype.addSource = function (elem, fromJid) {
logger.warn("addSource - localDescription not ready yet")
setTimeout(function()
{
self.addSource(elem, fromJid);
self.addSource(elem);
},
200
);
@ -942,16 +946,18 @@ JingleSessionPC.prototype.addSource = function (elem, fromJid) {
});
};
JingleSessionPC.prototype.removeSource = function (elem, fromJid) {
/**
* Handles a Jingle source-remove message for this Jingle session.
* @param elem An array of Jingle "content" elements.
*/
JingleSessionPC.prototype.removeSource = function (elem) {
var self = this;
// FIXME: dirty waiting
if (!this.peerconnection.localDescription)
{
logger.warn("removeSource - localDescription not ready yet")
setTimeout(function()
{
self.removeSource(elem, fromJid);
if (!this.peerconnection.localDescription) {
logger.warn("removeSource - localDescription not ready yet");
setTimeout(function() {
self.removeSource(elem);
},
200
);

4
modules/xmpp/strophe.jingle.js
View File

@ -172,11 +172,11 @@ module.exports = function(XMPP, eventEmitter) {
break;
case 'addsource': // FIXME: proprietary, un-jingleish
case 'source-add': // FIXME: proprietary
sess.addSource($(iq).find('>jingle>content'), fromJid);
sess.addSource($(iq).find('>jingle>content'));
break;
case 'removesource': // FIXME: proprietary, un-jingleish
case 'source-remove': // FIXME: proprietary
sess.removeSource($(iq).find('>jingle>content'), fromJid);
sess.removeSource($(iq).find('>jingle>content'));
break;
default:
logger.warn('jingle action not implemented', action);