haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[RN] Ignore mute error if track is disposed 

Refs: https://github.com/jitsi/lib-jitsi-meet/pull/648

It's possible for a track to be disposed but still on the redux store, before
the reducer removed it.
This commit is contained in:
Saúl Ibarra Corretgé 2017-11-21 14:38:53 +01:00 committed by Lyubo Marinov
parent 90e4291751
commit 0aa377fcfc
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package-lock.json generated
View File

@ -11016,7 +11016,7 @@
} }
}, },
"lib-jitsi-meet": { "lib-jitsi-meet": {
"version": "github:jitsi/lib-jitsi-meet#9b99e6bb33048e1f418465ec33db923f1786ba1f", "version": "github:jitsi/lib-jitsi-meet#21b07deabccd0b28b6d8eacaa6eee613e018b482",
"requires": { "requires": {
"async": "0.9.0", "async": "0.9.0",
"current-executing-script": "0.1.3", "current-executing-script": "0.1.3",

2
package.json
View File

@ -47,7 +47,7 @@
"js-md5": "0.6.1", "js-md5": "0.6.1",
"jssha": "2.2.0", "jssha": "2.2.0",
"jwt-decode": "2.2.0", "jwt-decode": "2.2.0",
"lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#9b99e6bb33048e1f418465ec33db923f1786ba1f", "lib-jitsi-meet": "github:jitsi/lib-jitsi-meet#21b07deabccd0b28b6d8eacaa6eee613e018b482",
"lodash": "4.17.4", "lodash": "4.17.4",
"nuclear-js": "1.4.0", "nuclear-js": "1.4.0",
"postis": "2.2.0", "postis": "2.2.0",

11
react/features/base/tracks/functions.js
View File

@ -1,6 +1,7 @@
/* global APP */ /* global APP */
import JitsiMeetJS, { JitsiTrackEvents } from '../lib-jitsi-meet'; import JitsiMeetJS, { JitsiTrackErrors, JitsiTrackEvents }
from '../lib-jitsi-meet';
import { MEDIA_TYPE } from '../media'; import { MEDIA_TYPE } from '../media';
const logger = require('jitsi-meet-logger').getLogger(__filename); const logger = require('jitsi-meet-logger').getLogger(__filename);
@ -214,8 +215,10 @@ export function setTrackMuted(track, muted) {
const f = muted ? 'mute' : 'unmute'; const f = muted ? 'mute' : 'unmute';
return track[f]().catch(error => { return track[f]().catch(error => {
// Track might be already disposed so ignore such an error.
// FIXME Emit mute failed, so that the app can show error dialog. if (error.name !== JitsiTrackErrors.TRACK_IS_DISPOSED) {
console.error(`set track ${f} failed`, error); // FIXME Emit mute failed, so that the app can show error dialog.
console.error(`set track ${f} failed`, error);
}
}); });
} }