fix(dialog) remove obsolete prop no longer used in web

This commit is contained in:
Saúl Ibarra Corretgé 2022-04-25 16:19:53 +02:00 committed by Saúl Ibarra Corretgé
parent 8e65fab544
commit 0ad6bd4d83
4 changed files with 3 additions and 19 deletions

View File

@ -30,17 +30,14 @@ export function hideDialog(component: ?Object) {
* @param {Object} component - The component to display as dialog.
* @param {Object} [componentProps] - The React {@code Component} props of the
* specified {@code component}.
* @param {boolean} rawDialog - True if the dialog is a raw dialog.
* (Doesn't inherit behavior from other common frameworks).
* @returns {{
* type: OPEN_DIALOG,
* component: React.Component,
* componentProps: (Object | undefined)
* }}
*/
export function openDialog(component: Object, componentProps: ?Object, rawDialog?: boolean) {
export function openDialog(component: Object, componentProps: ?Object) {
return {
rawDialog,
type: OPEN_DIALOG,
component,
componentProps

View File

@ -19,11 +19,6 @@ type Props = {
*/
_componentProps: Object,
/**
* True if the dialog is a raw dialog (doesn't inherit behavior from other common frameworks, such as atlaskit).
*/
_rawDialog: boolean,
/**
* True if the UI is in a compact state where we don't show dialogs.
*/
@ -73,7 +68,6 @@ export function abstractMapStateToProps(state: Object): $Shape<Props> {
return {
_component: stateFeaturesBaseDialog.component,
_componentProps: stateFeaturesBaseDialog.componentProps,
_rawDialog: stateFeaturesBaseDialog.rawDialog,
_reducedUI: reducedUI
};
}

View File

@ -20,10 +20,6 @@ class DialogContainer extends AbstractDialogContainer {
* @returns {ReactElement}
*/
render() {
if (this.props._rawDialog) {
return this._renderDialogContent();
}
return (
<ModalTransition>
{ this._renderDialogContent() }
@ -33,4 +29,3 @@ class DialogContainer extends AbstractDialogContainer {
}
export default connect(abstractMapStateToProps)(DialogContainer);

View File

@ -21,8 +21,7 @@ ReducerRegistry.register('features/base/dialog', (state = {}, action) => {
if (typeof component === 'undefined' || state.component === component) {
return assign(state, {
component: undefined,
componentProps: undefined,
rawDialog: false
componentProps: undefined
});
}
break;
@ -31,8 +30,7 @@ ReducerRegistry.register('features/base/dialog', (state = {}, action) => {
case OPEN_DIALOG:
return assign(state, {
component: action.component,
componentProps: action.componentProps,
rawDialog: action.rawDialog
componentProps: action.componentProps
});
}