ref(conference): change when the room reference is removed (#3808)

Delay removing the room reference. This is in case a
consumer of the API is attempting to submit feedback
after hangup but before redirecting to another page.
If the room reference is removed, feedback submission
will fail during this period.
This commit is contained in:
virtuacoplenny 2019-01-17 16:04:35 -08:00 committed by GitHub
parent 7f29b47f3a
commit 10624e87f5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 5 deletions

View File

@ -2509,6 +2509,9 @@ export default {
requestFeedbackPromise,
this.leaveRoomAndDisconnect()
]).then(values => {
this._room = undefined;
room = undefined;
APP.API.notifyReadyToClose();
maybeRedirectToWelcomePage(values[0]);
});
@ -2523,11 +2526,7 @@ export default {
APP.store.dispatch(conferenceWillLeave(room));
return room.leave()
.then(disconnect, disconnect)
.then(() => {
this._room = undefined;
room = undefined;
});
.then(disconnect, disconnect);
},
/**