haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(video-quality) Add pinned participants to selectedSources. 

When mulltiple videos are pinned to the stage filmstrip, the expectation is that the bridge will forward all the videos even if they are of lower quality. For this, the video sources need to be added to selectedSources instead of onStageSources.
This commit is contained in:
Jaya Allamsetty 2023-02-16 09:29:44 -05:00
parent dbeca806bb
commit 123a74b38b
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
react/features/video-quality/subscriber.ts
View File

@ -463,7 +463,17 @@ function _updateReceiverVideoConstraints({ getState }: IStore) {
} }
if (getCurrentLayout(state) === LAYOUTS.STAGE_FILMSTRIP_VIEW && activeParticipantsSources.length > 0) { if (getCurrentLayout(state) === LAYOUTS.STAGE_FILMSTRIP_VIEW && activeParticipantsSources.length > 0) {
const onStageSources = [ ...activeParticipantsSources ]; const selectedSources: string[] = [];
const onStageSources: string[] = [];
// If more than one video source is pinned to the stage filmstrip, they need to be added to the
// 'selectedSources' so that the bridge can allocate bandwidth for all the sources as opposed to doing
// greedy allocation for the sources (which happens when they are added to 'onStageSources').
if (activeParticipantsSources.length > 1) {
selectedSources.push(...activeParticipantsSources);
} else {
onStageSources.push(activeParticipantsSources[0]);
}
activeParticipantsSources.forEach(sourceName => { activeParticipantsSources.forEach(sourceName => {
const isScreenSharing = remoteScreenShares.includes(sourceName); const isScreenSharing = remoteScreenShares.includes(sourceName);
@ -485,6 +495,7 @@ function _updateReceiverVideoConstraints({ getState }: IStore) {
} }
receiverConstraints.onStageSources = onStageSources; receiverConstraints.onStageSources = onStageSources;
receiverConstraints.selectedSources = selectedSources;
} else if (largeVideoSourceName) { } else if (largeVideoSourceName) {
let quality = VIDEO_QUALITY_UNLIMITED; let quality = VIDEO_QUALITY_UNLIMITED;