haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref(PiP/actions): remove 'is ok to enter PiP' check 

Currently enterPictureInPicture action can only be dispatched when
the app is on the conference view and the enter PiP button is displayed,
so no check should be necessary.
This commit is contained in:
paweldomas 2018-04-26 09:18:15 -05:00 committed by Saúl Ibarra Corretgé
parent 565fd37f28
commit 17ae89a56c
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
react/features/mobile/picture-in-picture/actions.js
View File

@ -21,14 +21,10 @@ export function enterPictureInPicture() {
const state = getState();
const { app } = state['features/app'];
// FIXME We want to be able to enter Picture-in-Picture as soon as we
// are on the Conference page i.e. even before `joining` was set in the
// reducer.
const { conference, joining } = state['features/base/conference'];
if (app
&& app.props.pictureInPictureEnabled
&& (conference || joining)) {
// XXX At the time of this writing this action can only be dispatched by
// the button which is on the conference view, which means that it's
// fine to enter PiP mode.
if (app && app.props.pictureInPictureEnabled) {
const { PictureInPicture } = NativeModules;
const p
= Platform.OS === 'android'