haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2024 from virtuacoplenny/lenny/no-resolution 

ref(stats): do not modify stats object from lib
This commit is contained in:
bbaldino 2017-10-03 10:50:39 -07:00 committed by GitHub
parent 86fcfcc535 eb1a44f5ba
commit 1ef3e4b7dc
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
react/features/connection-indicator/statsEmitter.js
View File

@ -108,20 +108,19 @@ const statsEmitter = {
* @returns {void} * @returns {void}
*/ */
_onStatsUpdated(currentUserId, stats) { _onStatsUpdated(currentUserId, stats) {
const allUserFramerates = stats.framerate; const allUserFramerates = stats.framerate || {};
const allUserResolutions = stats.resolution; const allUserResolutions = stats.resolution || {};
const currentUserFramerate = allUserFramerates[currentUserId];
const currentUserResolution = allUserResolutions[currentUserId];
// FIXME resolution and framerate are hashes keyed off of user ids with // FIXME resolution and framerate are hashes keyed off of user ids with
// stat values. Receivers of stats expect resolution and framerate to // stat values. Receivers of stats expect resolution and framerate to
// be primatives, not hashes, so overwrites the 'lib-jitsi-meet' stats // be primatives, not hashes, so overwrites the 'lib-jitsi-meet' stats
// objects. // objects.
stats.framerate = currentUserFramerate; const modifiedLocalStats = Object.assign({}, stats, {
stats.resolution = currentUserResolution; framerate: allUserFramerates[currentUserId],
resolution: allUserResolutions[currentUserId]
});
this._emitStatsUpdate(currentUserId, stats); this._emitStatsUpdate(currentUserId, modifiedLocalStats);
// Get all the unique user ids from the framerate and resolution stats // Get all the unique user ids from the framerate and resolution stats
// and update remote user stats as needed. // and update remote user stats as needed.