feat(config) Added option to remove Show More link from GSM popover

* Whitelisted enableSaveLogs

* Added config option to hide Show More on GSM popover

* Updated config option
This commit is contained in:
robertpin 2021-06-29 16:42:23 +03:00 committed by GitHub
parent d4c7fc8a72
commit 24503c3bd3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 22 additions and 3 deletions

View File

@ -101,6 +101,10 @@ var config = {
// about the call. // about the call.
// enableSaveLogs: false, // enableSaveLogs: false,
// Enabling this will hide the "Show More" link in the GSM popover that can be
// used to display more statistics about the connection (IP, Port, protocol, etc).
// disableShowMoreStats: true,
// Enabling this will run the lib-jitsi-meet noise detection module which will // Enabling this will run the lib-jitsi-meet noise detection module which will
// notify the user if there is noise, other than voice, coming from the current // notify the user if there is noise, other than voice, coming from the current
// selected microphone. The purpose it to let the user know that the input could // selected microphone. The purpose it to let the user know that the input could

View File

@ -96,6 +96,7 @@ export default [
'disableResponsiveTiles', 'disableResponsiveTiles',
'disableRtx', 'disableRtx',
'disableShortcuts', 'disableShortcuts',
'disableShowMoreStats',
'disableSimulcast', 'disableSimulcast',
'disableThirdPartyRequests', 'disableThirdPartyRequests',
'disableTileView', 'disableTileView',
@ -112,6 +113,7 @@ export default [
'enableLipSync', 'enableLipSync',
'enableOpusRed', 'enableOpusRed',
'enableRemb', 'enableRemb',
'enableSaveLogs',
'enableScreenshotCapture', 'enableScreenshotCapture',
'enableTalkWhileMuted', 'enableTalkWhileMuted',
'enableNoAudioDetection', 'enableNoAudioDetection',

View File

@ -90,6 +90,12 @@ type Props = AbstractProps & {
*/ */
enableSaveLogs: boolean, enableSaveLogs: boolean,
/**
* Whether or not should display the "Show More" link in the local video
* stats table.
*/
disableShowMoreStats: boolean,
/** /**
* Whether or not clicking the indicator should display a popover for more * Whether or not clicking the indicator should display a popover for more
* details. * details.
@ -391,6 +397,7 @@ class ConnectionIndicator extends AbstractConnectionIndicator<Props, State> {
bridgeCount = { bridgeCount } bridgeCount = { bridgeCount }
codec = { codec } codec = { codec }
connectionSummary = { this._getConnectionStatusTip() } connectionSummary = { this._getConnectionStatusTip() }
disableShowMoreStats = { this.props.disableShowMoreStats }
e2eRtt = { e2eRtt } e2eRtt = { e2eRtt }
enableSaveLogs = { this.props.enableSaveLogs } enableSaveLogs = { this.props.enableSaveLogs }
framerate = { framerate } framerate = { framerate }
@ -448,7 +455,8 @@ export function _mapStateToProps(state: Object, ownProps: Props) {
= typeof participantId === 'undefined' ? getLocalParticipant(state) : getParticipantById(state, participantId); = typeof participantId === 'undefined' ? getLocalParticipant(state) : getParticipantById(state, participantId);
const props = { const props = {
_connectionStatus: participant?.connectionStatus, _connectionStatus: participant?.connectionStatus,
enableSaveLogs: state['features/base/config'].enableSaveLogs enableSaveLogs: state['features/base/config'].enableSaveLogs,
disableShowMoreStats: state['features/base/config'].disableShowMoreStats
}; };
if (conference) { if (conference) {

View File

@ -59,6 +59,11 @@ type Props = {
*/ */
enableSaveLogs: boolean, enableSaveLogs: boolean,
/**
* Whether or not should display the "Show More" link.
*/
disableShowMoreStats: boolean,
/** /**
* The endpoint id of this client. * The endpoint id of this client.
*/ */
@ -170,7 +175,7 @@ class ConnectionStatsTable extends Component<Props> {
* @returns {ReactElement} * @returns {ReactElement}
*/ */
render() { render() {
const { isLocalVideo, enableSaveLogs } = this.props; const { isLocalVideo, enableSaveLogs, disableShowMoreStats } = this.props;
return ( return (
<div <div
@ -179,7 +184,7 @@ class ConnectionStatsTable extends Component<Props> {
{ this._renderStatistics() } { this._renderStatistics() }
<div className = 'connection-actions'> <div className = 'connection-actions'>
{ isLocalVideo && enableSaveLogs ? this._renderSaveLogs() : null} { isLocalVideo && enableSaveLogs ? this._renderSaveLogs() : null}
{ this._renderShowMoreLink() } { !disableShowMoreStats && this._renderShowMoreLink() }
</div> </div>
{ this.props.shouldShowMore ? this._renderAdditionalStats() : null } { this.props.shouldShowMore ? this._renderAdditionalStats() : null }
</div> </div>