haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(video): use onplaying to ensure video height and width are set 

When using onplay in firefox, the event fires before data is flowing,
which can cause videoHeight and videoWidth to be 0 during resizing.
By using onplaying, there is some assurance data is being received,
so videoHeight and videoWidth should be set.
This commit is contained in:
Leonard Kim 2017-06-05 16:41:16 -07:00 committed by Дамян Минков
parent 96e83989a5
commit 2e08815644
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/UI/videolayout/VideoContainer.js
View File

@ -206,7 +206,7 @@ export class VideoContainer extends LargeContainer {
this.avatarHeight = $("#dominantSpeakerAvatar").height(); this.avatarHeight = $("#dominantSpeakerAvatar").height();
var onPlayCallback = function (event) { var onPlayingCallback = function (event) {
if (typeof resizeContainer === 'function') { if (typeof resizeContainer === 'function') {
resizeContainer(event); resizeContainer(event);
} }
@ -215,7 +215,7 @@ export class VideoContainer extends LargeContainer {
// This does not work with Temasys plugin - has to be a property to be // This does not work with Temasys plugin - has to be a property to be
// copied between new <object> elements // copied between new <object> elements
//this.$video.on('play', onPlay); //this.$video.on('play', onPlay);
this.$video[0].onplay = onPlayCallback; this.$video[0].onplaying = onPlayingCallback;
/** /**
* A Set of functions to invoke when the video element resizes. * A Set of functions to invoke when the video element resizes.