haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(iframe_api): Remove unnecessary div that wraps the iframe

This commit is contained in:
hristoterezov 2017-07-13 13:23:32 -05:00 committed by yanas
parent 07158e8071
commit 3736d6ca78
1 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
modules/API/external/external_api.js vendored
View File

@ -229,25 +229,17 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
width = `${Math.max(width, MIN_WIDTH)}px`; width = `${Math.max(width, MIN_WIDTH)}px`;
} }
/* eslint-enable no-param-reassign */
this._iframeHolder
= this._parentNode.appendChild(document.createElement('div'));
this._iframeHolder.id = `jitsiConference${id}`;
this._iframeHolder.style.width = width;
this._iframeHolder.style.height = height;
const frameName = `jitsiConferenceFrame${id}`; const frameName = `jitsiConferenceFrame${id}`;
this._frame = document.createElement('iframe'); this._frame = document.createElement('iframe');
this._frame.src = this._url; this._frame.src = this._url;
this._frame.name = frameName; this._frame.name = frameName;
this._frame.id = frameName; this._frame.id = frameName;
this._frame.width = '100%'; this._frame.style.width = width;
this._frame.height = '100%'; this._frame.style.height = height;
this._frame.setAttribute('allowFullScreen', 'true'); this._frame.setAttribute('allowFullScreen', 'true');
this._frame.style.border = 0; this._frame.style.border = 0;
this._frame = this._iframeHolder.appendChild(this._frame); this._frame = this._parentNode.appendChild(this._frame);
} }
/** /**
@ -361,8 +353,8 @@ export default class JitsiMeetExternalAPI extends EventEmitter {
dispose() { dispose() {
this._transport.dispose(); this._transport.dispose();
this.removeAllListeners(); this.removeAllListeners();
if (this._iframeHolder) { if (this._frame) {
this._iframeHolder._parentNode.removeChild(this._iframeHolder); this._frame.parentNode.removeChild(this._frame);
} }
} }