haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1114 from jitsi/fix_page_reload_log 

Log the page reload from one place
This commit is contained in:
bgrozev 2016-11-06 11:09:56 -06:00 committed by GitHub
parent 02495e3b31 d256bc317a
commit 38e44440d0
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
conference.js
View File

@ -370,11 +370,6 @@ class ConferenceConnector {
case ConferenceErrors.FOCUS_LEFT:
case ConferenceErrors.VIDEOBRIDGE_NOT_AVAILABLE:
// Log the page reload event
// FIXME (CallStats - issue) this event will not make it to
// the CallStats, because the log queue is not flushed, before
// "fabric terminated" is sent to the backed
APP.conference.logEvent('page.reload');
// FIXME the conference should be stopped by the library and not by
// the app. Both the errors above are unrecoverable from the library
// perspective.

7
modules/UI/reload_overlay/PageReloadOverlay.js
View File

@ -116,6 +116,13 @@ export default {
if (!overlay) {
overlay = new PageReloadOverlayImpl(timeoutSeconds);
}
// Log the page reload event
if (!this.isVisible()) {
// FIXME (CallStats - issue) this event will not make it to
// the CallStats, because the log queue is not flushed, before
// "fabric terminated" is sent to the backed
APP.conference.logEvent('page.reload');
}
overlay.show();
}
};