haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move roomnameGenerator.js out of features/base/util 

Over time features/base/util became a bucket where people seemed to dump
just about anything they couldn't think of a better place for. That's a
trend I don't like encouraging. Given that roomnameGenerator.js is
currently used in features/welcome only, I'm fine with moving it there
for the greater good.
This commit is contained in:
Lyubo Marinov 2017-04-14 13:08:54 -05:00
parent a8b3177e20
commit 3db557e2c9
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
react/features/base/util/index.js
View File

@ -1,3 +1,2 @@
export * from './loadScript'; export * from './loadScript';
export * from './randomUtil'; export * from './randomUtil';
export * from './roomnameGenerator';

3
react/features/welcome/components/AbstractWelcomePage.js
View File

@ -4,7 +4,8 @@ import { appNavigate } from '../../app';
import { isRoomValid } from '../../base/conference'; import { isRoomValid } from '../../base/conference';
import { VideoTrack } from '../../base/media'; import { VideoTrack } from '../../base/media';
import { getLocalVideoTrack } from '../../base/tracks'; import { getLocalVideoTrack } from '../../base/tracks';
import { generateRoomWithoutSeparator } from '../../base/util';
import { generateRoomWithoutSeparator } from '../roomnameGenerator';
/** /**
* Base (abstract) class for container component rendering the welcome page. * Base (abstract) class for container component rendering the welcome page.

2
react/features/base/util/roomnameGenerator.js → react/features/welcome/roomnameGenerator.js
View File

@ -1,6 +1,6 @@
/* @flow */ /* @flow */
import { randomElement } from './randomUtil'; import { randomElement } from '../base/util';
/* /*
const _NOUN_ = [ const _NOUN_ = [

2
react/features/welcome/route.js
View File

@ -1,9 +1,9 @@
/* global APP */ /* global APP */
import { RouteRegistry } from '../base/react'; import { RouteRegistry } from '../base/react';
import { generateRoomWithoutSeparator } from '../base/util';
import { WelcomePage } from './components'; import { WelcomePage } from './components';
import { generateRoomWithoutSeparator } from './roomnameGenerator';
/** /**
* Register route for WelcomePage. * Register route for WelcomePage.