haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref(conn-indicator): remove E2E RTT (#12139) 

There was a fundamental change in how e2e pings work in lib-jitsi-meet where it does few pings at the beginning, pushes metrics and shuts the whole thing down, so there are no more e2ertt updates after that. Plus it's disabled by default. @paweldomas have decided with @bgrozev to remove that instead of trying to adjust. Even if e2e pings are enabled the data is not feed correctly to the indicators, what's wrong there is as soon as the pings stop going the new data does not arrive and then all you get is N/A if the UI component is recreated.
This commit is contained in:
Misha 2022-09-12 22:57:15 +02:00 committed by GitHub
parent 443f4e4feb
commit 3ef3233242
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
50 changed files with 0 additions and 77 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lang/main-ar.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "عدد المخدِّمات: ",
"codecs": "المرماز (A/V): ",
"connectedTo": "وصل إلى:",
"e2e_rtt": "E2E RTT:",
"framerate": "مُعدَّل الإطارات:",
"less": "اخف",
"localaddress": "العنوان المحلي:",

1
lang/main-be.json
View File

@ -90,7 +90,6 @@
"bitrate": "Бітрэйт:",
"bridgeCount": "Колькасць сервераў: ",
"connectedTo": "Падключаны да:",
"e2e_rtt": "E2E RTT:",
"framerate": "Частата кадраў:",
"less": "Кароткая інфармацыя",
"localaddress_0": "Мясцовы адрас:",

1
lang/main-ca.json
View File

@ -145,7 +145,6 @@
"bridgeCount": "Nombre de servidors: ",
"codecs": "Còdecs (A/V):",
"connectedTo": "Connectat a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Taxa de fotogrames:",
"less": "Menys informació",
"localaddress": "Adreça local:",

1
lang/main-cs.json
View File

@ -108,7 +108,6 @@
"bridgeCount": "Počet serverů: ",
"codecs": "Kodeky (A/V): ",
"connectedTo": "Připojeno k:",
"e2e_rtt": "E2E RTT:",
"framerate": "Rychlost snímkování:",
"less": "Zobrazit méně",
"localaddress_0": "Místní adresa:",

1
lang/main-da.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitrate:",
"bridgeCount": "Server antal: ",
"connectedTo": "Forbundet til:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frame rate:",
"less": "Vis mindre",
"localaddress": "Lokal adresse:",

1
lang/main-de.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "Serverzahl: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Verbunden mit:",
"e2e_rtt": "Ende-zu-Ende-Paketumlaufzeit:",
"framerate": "Bildwiederholrate:",
"less": "Weniger anzeigen",
"localaddress": "Lokale Adresse:",

1
lang/main-el.json
View File

@ -105,7 +105,6 @@
"bitrate": "Ρυθμός μετάδοσης:",
"bridgeCount": "Αριθμός server: ",
"connectedTo": "Συνδεδεμένος με:",
"e2e_rtt": "E2E RTT:",
"framerate": "Ρυθμός ανανέωσης:",
"less": "Δείξε λιγότερα",
"localaddress": "Τοπική διεύθυνση:",

1
lang/main-enGB.json
View File

@ -92,7 +92,6 @@
"bridgeCount": "Server count: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Connected to:",
"e2e_rtt": "",
"framerate": "Frame rate:",
"less": "Show less",
"localaddress": "Local address:",

1
lang/main-eo.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitrate:",
"bridgeCount": "Server count: ",
"connectedTo": "Connected to:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frame rate:",
"less": "Show less",
"localaddress": "Local address:",

1
lang/main-es.json
View File

@ -114,7 +114,6 @@
"bridgeCount": "Contador del servidor: ",
"codecs": "Codecs (A/V):",
"connectedTo": "Conectado a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Fotogramas por segundo:",
"less": "Mostrar menos",
"localaddress": "Dirección local:",

1
lang/main-esUS.json
View File

@ -122,7 +122,6 @@
"bridgeCount": "Contador del servidor: ",
"codecs": "Codecs (A/V):",
"connectedTo": "Conectado a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Fotogramas por segundo:",
"less": "Mostrar menos",
"localaddress": "Dirección local:",

1
lang/main-et.json
View File

@ -90,7 +90,6 @@
"bitrate": "Andmeedastuskiirus:",
"bridgeCount": "Serverite arv: ",
"connectedTo": "Ühendatud:",
"e2e_rtt": "E2E RTT:",
"framerate": "Ekraani eraldusvõime:",
"less": "Näita vähem",
"localaddress": "Lokaalne aadress:",

1
lang/main-eu.json
View File

@ -110,7 +110,6 @@
"bridgeCount": "Zerbitzari kopurua: ",
"codecs": "Kodekak (A/B): ",
"connectedTo": "Konektatua hona:",
"e2e_rtt": "E2E RTT:",
"framerate": "Marko-abiadura:",
"less": "Erakutsi gutxiago",
"localaddress": "Helbide lokala:",

1
lang/main-fa.json
View File

@ -134,7 +134,6 @@
"bridgeCount": "تعداد سرور: ",
"codecs": "کدک‌ها (A/V): ",
"connectedTo": "متصل به:",
"e2e_rtt": "E2E RTT:",
"framerate": "نرخ فریم:",
"less": "خلاصه",
"localaddress": "نشانی داخلی:",

1
lang/main-fr.json
View File

@ -134,7 +134,6 @@
"bridgeCount": "Nombre de serveurs :",
"codecs": "Codecs (A/V) :",
"connectedTo": "Connecté à :",
"e2e_rtt": "E2E RTT :",
"framerate": "Images par seconde :",
"less": "Cacher les détails",
"localaddress": "Adresse locale :",

1
lang/main-he.json
View File

@ -90,7 +90,6 @@
"bitrate": "קצב סיביות:",
"bridgeCount": "מספר שרתים: ",
"connectedTo": "מחובר אל:",
"e2e_rtt": "E2E RTT:",
"framerate": "קצב מסגרת:",
"less": "הצג פחות",
"localaddress": "כתובת מקומית:",

1
lang/main-hi.json
View File

@ -109,7 +109,6 @@
"bridgeCount": "सर्वर गणना: ",
"codecs": "कोडेक (ए/वी): ",
"connectedTo": "से जुड़ा हुआ है :",
"e2e_rtt": "ई.2ई. आर.टी.टी.:",
"framerate": "फ्रेम दर:",
"less": "कम दिखाएं",
"localaddress": "स्थानीय पता:",

1
lang/main-hr.json
View File

@ -147,7 +147,6 @@
"bridgeCount": "Broj poslužitelja: ",
"codecs": "Kodeki (A/V): ",
"connectedTo": "Povezan na:",
"e2e_rtt": "E2E RTT:",
"framerate": "Broj sličica u sekundi:",
"less": "Pokaži manje",
"localaddress": "Adresa lokalnog uređaja:",

1
lang/main-hsb.json
View File

@ -145,7 +145,6 @@
"bridgeCount": "ličba serwera: ",
"codecs": "kody (A/V): ",
"connectedTo": "zwjazane z:",
"e2e_rtt": "E2E RTT:",
"framerate": " wobrazowospjetna frekwenca:",
"less": "mjenje pokazać",
"localaddress": "lokalna adresa:",

1
lang/main-hu.json
View File

@ -91,7 +91,6 @@
"bitrate": "Bitsebesség:",
"bridgeCount": "Kiszolgáló száma: ",
"connectedTo": "Kapcsolódva ehhez:",
"e2e_rtt": "E2E RTT:",
"framerate": "Képkockasebesség:",
"less": "Kevesebb megjelenítése",
"localaddress": "Helyi cím:",

1
lang/main-id.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitrate:",
"bridgeCount": "Server count: ",
"connectedTo": "Connected to:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frame rate:",
"less": "Show less",
"localaddress": "Local address:",

1
lang/main-is.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitahraði:",
"bridgeCount": "Fjöldi netþjóna: ",
"connectedTo": "Tengt við:",
"e2e_rtt": "E2E RTT:",
"framerate": "Rammatíðni:",
"less": "Sýna minna",
"localaddress": "Staðvært vistfang:",

1
lang/main-it.json
View File

@ -145,7 +145,6 @@
"bridgeCount": "Conteggio server:",
"codecs": "Codec (A/V): ",
"connectedTo": "Connesso a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Fotogrammi al secondo:",
"less": "Mostra meno",
"localaddress": "Indirizzo locale:",

1
lang/main-ja.json
View File

@ -136,7 +136,6 @@
"bridgeCount": "サーバー数:",
"codecs": "コーデック (A/V): ",
"connectedTo": "接続先:",
"e2e_rtt": "E2E RTT:",
"framerate": "フレームレート:",
"less": "表示を減らす",
"localaddress": "ローカルアドレス:",

1
lang/main-kab.json
View File

@ -114,7 +114,6 @@
"bridgeCount": "Amḍan n uqeddac: ",
"codecs": "Codecs (A/V) : ",
"connectedTo": "Yeqqen ɣer:",
"e2e_rtt": "E2E RTT:",
"framerate": "Afmiḍi n ukatar:",
"less": "Sken-d drus",
"localaddress": "Tansa tadigant:",

1
lang/main-lt.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitrate:",
"bridgeCount": "Serverių skaičius: ",
"connectedTo": "Prijungta prie:",
"e2e_rtt": "E2E RTT:",
"framerate": "Kadrų dažnis:",
"less": "Rodyti mažiau",
"localaddress": "Vietinis adresas:",

1
lang/main-lv.json
View File

@ -90,7 +90,6 @@
"bitrate": "Bitreits:",
"bridgeCount": "Serveru skaits:",
"connectedTo": "Pieslēdzies pie:",
"e2e_rtt": "E2E RTT:",
"framerate": "Kadru ātrums/skaits:",
"less": "Tikai kodolīga informācija",
"localaddress": "Lokālā adrese:",

1
lang/main-ml.json
View File

@ -106,7 +106,6 @@
"bridgeCount": "Server count: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Connected to:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frame rate:",
"less": "Show less",
"localaddress": "Local address:",

1
lang/main-mn.json
View File

@ -90,7 +90,6 @@
"bitrate": "Битрат:",
"bridgeCount": "Серверийн тоо: ",
"connectedTo": "Холбогдсон:",
"e2e_rtt": "E2E RTT:",
"framerate": "Нягтаршил:",
"less": "Хураах",
"localaddress": "Дотоод хаяг:",

1
lang/main-mr.json
View File

@ -90,7 +90,6 @@
"bitrate": "बिटरेट:",
"bridgeCount": "सर्व्हर संख्या:",
"connectedTo": "यांना जोडलेले:",
"e2e_rtt": "E2E आरटीटी:",
"framerate": "फ्रेम दर:",
"less": "कमी दाखवा",
"localaddress": "स्थानिक पत्ता:",

1
lang/main-nl.json
View File

@ -134,7 +134,6 @@
"bridgeCount": "Aantal servers: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Verbonden met:",
"e2e_rtt": "E2E RTT:",
"framerate": "Framesnelheid:",
"less": "Minder weergeven",
"localaddress": "Lokaal adres:",

1
lang/main-oc.json
View File

@ -136,7 +136,6 @@
"bridgeCount": "Nombre de servidor : ",
"codecs": "Codecs (A/V) : ",
"connectedTo": "Connectat a :",
"e2e_rtt": "E2E RTT :",
"framerate": "Frequéncia imatge :",
"less": "Amagar lo detalh",
"localaddress": "Adreça locala :",

1
lang/main-pl.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "Liczba serwerów: ",
"codecs": "Kodeki (A/V): ",
"connectedTo": "Podłączone do:",
"e2e_rtt": "E2E RTT:",
"framerate": "Klatek na sekundę:",
"less": "Pokaż mniej",
"localaddress": "Adres lokalny:",

1
lang/main-pt.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "Servidores: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Ligado a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Taxa de frames:",
"less": "Mostrar menos",
"localaddress": "Endereço local:",

1
lang/main-ptBR.json
View File

@ -114,7 +114,6 @@
"bridgeCount": "Servidores: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Conectado a:",
"e2e_rtt": "E2E RTT:",
"framerate": "Taxa de quadros:",
"less": "Mostrar menos",
"localaddress": "Endereço local:",

1
lang/main-ro.json
View File

@ -91,7 +91,6 @@
"bitrate": "Bitrate:",
"bridgeCount": "Numărul de servere: ",
"connectedTo": "Conectat la:",
"e2e_rtt": "",
"framerate": "Rată cadre:",
"less": "Arătați mai puțin",
"localaddress": "Adresă locala:",

1
lang/main-ru.json
View File

@ -144,7 +144,6 @@
"bridgeCount": "Количество серверов: ",
"codecs": "Кодеки (A/V): ",
"connectedTo": "Подключен к:",
"e2e_rtt": "E2E RTT:",
"framerate": "Частота кадров:",
"less": "Краткая информация",
"localaddress": "Локальный адрес:",

1
lang/main-sc.json
View File

@ -90,7 +90,6 @@
"bitrate": "Velotzidade de bits:",
"bridgeCount": "Nùmeru de servidores: ",
"connectedTo": "Connessione cun:",
"e2e_rtt": "E2E RTT:",
"framerate": "Velotzidade de fotogrammas:",
"less": "Prus pagu informatziones",
"localaddress": "Indiritzu locale:",

1
lang/main-sk.json
View File

@ -105,7 +105,6 @@
"bitrate": "Prenos. rýchlosť:",
"bridgeCount": "Počet serverov: ",
"connectedTo": "Spojenie s:",
"e2e_rtt": "E2E RTT:",
"framerate": "Rýchlosť snímkovania:",
"less": "Zobraziť menej",
"localaddress": "Lokálna adresa:",

1
lang/main-sl.json
View File

@ -114,7 +114,6 @@
"bridgeCount": "Število strežnikov: ",
"codecs": "Kodeki (A/V): ",
"connectedTo": "Povezan v:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frekvenca slik:",
"less": "Prikaži manj",
"localaddress": "Lokalni naslov:",

1
lang/main-sq.json
View File

@ -136,7 +136,6 @@
"bridgeCount": "Numër shërbyesish: ",
"codecs": "Kodekë (A/V): ",
"connectedTo": "Lidhur te:",
"e2e_rtt": "E2E RTT:",
"framerate": "Shpejtësi kuadrosh:",
"less": "Shfaq më pak",
"localaddress": "Adresë vendore:",

1
lang/main-sv.json
View File

@ -122,7 +122,6 @@
"bridgeCount": "Serverantal: ",
"codecs": "Codecs (A/V):",
"connectedTo": "Ansluten till:",
"e2e_rtt": "E2E RTT:",
"framerate": "Bildfrekvens:",
"less": "Visa mindre",
"localaddress": "Lokal adress:",

1
lang/main-te.json
View File

@ -109,7 +109,6 @@
"bridgeCount": "సేవికల సంఖ్య: ",
"codecs": "కోడెక్స్ (A/V): ",
"connectedTo": "దీనికి అనుసంధానమైంది:",
"e2e_rtt": "E2E RTT:",
"framerate": "ఫ్రేమ్ రేటు:",
"less": "తక్కువ చూపించు",
"localaddress": "స్థానిక చిరునామా:",

1
lang/main-tr.json
View File

@ -123,7 +123,6 @@
"bridgeCount": "Sunucu sayısı: ",
"codecs": "Kodekler (A/V): ",
"connectedTo": "Bağlandı şuna:",
"e2e_rtt": "E2E RTT:",
"framerate": "Çerçeve hızı:",
"less": "Daha az göster",
"localaddress": "Yerel adres:",

1
lang/main-uk.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "Кількість серверів: ",
"codecs": "Кодеки (A/V): ",
"connectedTo": "З'єднано з:",
"e2e_rtt": "E2E RTT:",
"framerate": "Частота кадрів:",
"less": "Показати менше",
"localaddress": "Локальна адреса:",

1
lang/main-zhCN.json
View File

@ -106,7 +106,6 @@
"bridgeCount": "服务器数量:",
"codecs": "编解码器（A / V）：",
"connectedTo": "连接到:",
"e2e_rtt": "端到端时延 RTT:",
"framerate": "帧率：",
"less": "显示更少",
"localaddress": "本地地址：",

1
lang/main-zhTW.json
View File

@ -135,7 +135,6 @@
"bridgeCount": "伺服器數量：",
"codecs": "編碼 (A/V)：",
"connectedTo": "已連接至：",
"e2e_rtt": "E2E RTT：",
"framerate": "影格率：",
"less": "顯示較少",
"localaddress": "本機位址：",

1
lang/main.json
View File

@ -146,7 +146,6 @@
"bridgeCount": "Server count: ",
"codecs": "Codecs (A/V): ",
"connectedTo": "Connected to:",
"e2e_rtt": "E2E RTT:",
"framerate": "Frame rate:",
"less": "Show less",
"localaddress": "Local address:",

2
react/features/connection-indicator/components/web/ConnectionIndicatorContent.js
View File

@ -194,7 +194,6 @@ class ConnectionIndicatorContent extends AbstractConnectionIndicator<Props, Stat
bitrate,
bridgeCount,
codec,
e2eRtt,
framerate,
maxEnabledResolution,
packetLoss,
@ -212,7 +211,6 @@ class ConnectionIndicatorContent extends AbstractConnectionIndicator<Props, Stat
codec = { codec }
connectionSummary = { this._getConnectionStatusTip() }
disableShowMoreStats = { this.props._disableShowMoreStats }
e2eRtt = { e2eRtt }
enableSaveLogs = { this.props._enableSaveLogs }
framerate = { framerate }
isLocalVideo = { this.props._isLocalVideo }

27
react/features/connection-stats/components/ConnectionStatsTable.tsx
View File

@ -72,11 +72,6 @@ interface Props extends WithTranslation {
*/
disableShowMoreStats: boolean;
/**
* The end-to-end round-trip-time.
*/
e2eRtt: number;
/**
* Whether or not should display the "Save Logs" link.
*/
@ -524,27 +519,6 @@ class ConnectionStatsTable extends Component<Props> {
);
}
/**
* Creates a table row as a ReactElement for displaying end-to-end RTT and
* the region.
*
* @returns {ReactElement}
* @private
*/
_renderE2eRtt() {
const { e2eRtt, t } = this.props;
const str = e2eRtt ? `${e2eRtt.toFixed(0)}ms` : 'N/A';
return (
<tr>
<td>
<span>{ t('connectionindicator.e2e_rtt') }</span>
</td>
<td>{ str }</td>
</tr>
);
}
/**
* Creates a table row as a ReactElement for displaying the "connected to"
* information.
@ -772,7 +746,6 @@ class ConnectionStatsTable extends Component<Props> {
{ this._renderConnectionSummary() }
{ this._renderBitrate() }
{ this._renderPacketLoss() }
{ isRemoteVideo ? this._renderE2eRtt() : null }
{ isRemoteVideo ? this._renderRegion() : null }
{ this._renderResolution() }
{ this._renderFrameRate() }