haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(context-menu): set height for context menu when it does not have enough space at top

This commit is contained in:
Gabriel Borlea 2023-02-15 16:53:33 +02:00 committed by Gabriel Borlea
parent 72ef1668f2
commit 456ce38a10
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
react/features/base/ui/components/web/ContextMenu.tsx
View File

@ -7,6 +7,7 @@ import JitsiPortal from '../../../../toolbox/components/web/JitsiPortal';
import { showOverflowDrawer } from '../../../../toolbox/functions.web'; import { showOverflowDrawer } from '../../../../toolbox/functions.web';
import participantsPaneTheme from '../../../components/themes/participantsPaneTheme.json'; import participantsPaneTheme from '../../../components/themes/participantsPaneTheme.json';
import { withPixelLineHeight } from '../../../styles/functions.web'; import { withPixelLineHeight } from '../../../styles/functions.web';
import { spacing } from '../../Tokens';
/** /**
* Get a style property from a style declaration as a float. * Get a style property from a style declaration as a float.
@ -194,9 +195,22 @@ const ContextMenu = ({
&& offsetTarget.offsetParent instanceof HTMLElement && offsetTarget.offsetParent instanceof HTMLElement
) { ) {
const { current: container } = containerRef; const { current: container } = containerRef;
// make sure the max height is not set
// @ts-ignore
container.style.maxHeight = null;
const { offsetTop, offsetParent: { offsetHeight, scrollTop } } = offsetTarget; const { offsetTop, offsetParent: { offsetHeight, scrollTop } } = offsetTarget;
const outerHeight = getComputedOuterHeight(container); let outerHeight = getComputedOuterHeight(container);
const height = Math.min(MAX_HEIGHT, outerHeight); let height = Math.min(MAX_HEIGHT, outerHeight);
if (offsetTop + height > offsetHeight + scrollTop && height > offsetTop) {
// top offset and + padding + border
container.style.maxHeight = `${offsetTop - ((spacing[2] * 2) + 2)}px`;
}
// get the height after style changes
outerHeight = getComputedOuterHeight(container);
height = Math.min(MAX_HEIGHT, outerHeight);
container.style.top = offsetTop + height > offsetHeight + scrollTop container.style.top = offsetTop + height > offsetHeight + scrollTop
? `${offsetTop - outerHeight}` ? `${offsetTop - outerHeight}`