Coding style

android/sdk/src/main/java/org/jitsi/meet/sdk/JitsiMeetView.java

@@ -87,7 +87,8 @@ public class JitsiMeetView extends FrameLayout {
                 .addPackage(new com.RNFetchBlob.RNFetchBlobPackage())
                 .addPackage(new com.rnimmersive.RNImmersivePackage())
                 .addPackage(new org.jitsi.meet.sdk.audiomode.AudioModePackage())
-                .addPackage(new org.jitsi.meet.sdk.externalapi.ExternalAPIPackage())
+                .addPackage(
+                    new org.jitsi.meet.sdk.externalapi.ExternalAPIPackage())
                 .addPackage(new org.jitsi.meet.sdk.proximity.ProximityPackage())
                 .setUseDeveloperSupport(BuildConfig.DEBUG)
                 .setInitialLifecycleState(LifecycleState.RESUMED)
@@ -245,8 +246,8 @@ public class JitsiMeetView extends FrameLayout {
      * Releases the React resources (specifically the {@link ReactRootView})
      * associated with this view.
      *
-     * This method MUST be called when the Activity holding this view is destroyed, typically in the
-     * {@code onDestroy} method.
+     * This method MUST be called when the Activity holding this view is
+     * destroyed, typically in the {@code onDestroy} method.
      */
     public void dispose() {
         if (reactRootView != null) {

react/features/base/participants/components/Avatar.native.js

@@ -3,7 +3,6 @@ import { CustomCachedImage } from 'react-native-img-cache';
 
 import AvatarImage from './AvatarImage';
 
-
 /**
  * Implements an avatar as a React Native/mobile {@link Component}.
  */
@@ -55,6 +54,7 @@ export default class Avatar extends Component {
      * @returns {void}
      */
     componentWillReceiveProps(nextProps) {
+        // uri
         const prevURI = this.props && this.props.uri;
         const nextURI = nextProps && nextProps.uri;
 

react/features/base/participants/components/AvatarImage.native.js

@@ -3,27 +3,23 @@ import { Image, View } from 'react-native';
 
 import { Platform } from '../../react';
 
-
 /**
  * The default avatar to be used, in case the requested URI is not available
- * or fails to be loaded.
- *
- * This is an inline version of images/avatar2.png.
+ * or fails to load. It is an inline version of images/avatar2.png.
  *
  * @type {string}
  */
 const DEFAULT_AVATAR = require('./defaultAvatar.png');
 
 /**
- * The amount of time to wait when the avatar URI is undefined before we start
- * showing a default locally generated one. Note that since we have no URI, we
- * have nothing we can cache, so the color will be random.
+ * The number of milliseconds to wait when the avatar URI is undefined before we
+ * start showing a default locally generated one. Note that since we have no
+ * URI, we have nothing we can cache, so the color will be random.
  *
  * @type {number}
  */
 const UNDEFINED_AVATAR_TIMEOUT = 1000;
 
-
 /**
  * Implements an Image component wrapper, which returns a default image if the
  * requested one fails to load. The default image background is chosen by
@@ -86,15 +82,18 @@ export default class AvatarImage extends Component {
      * @returns {void}
      */
     componentWillReceiveProps(nextProps) {
-        const prevURI = this.props.source && this.props.source.uri;
-        const nextURI = nextProps.source && nextProps.source.uri;
+        const prevSource = this.props.source;
+        const prevURI = prevSource && prevSource.uri;
+        const nextSource = nextProps.source;
+        const nextURI = nextSource && nextSource.uri;
 
         if (typeof prevURI === 'undefined') {
             clearTimeout(this._timeout);
             if (typeof nextURI === 'undefined') {
-                this._timeout = setTimeout(() => {
-                    this.setState({ showDefault: true });
-                }, UNDEFINED_AVATAR_TIMEOUT);
+                this._timeout
+                    = setTimeout(
+                        () => this.setState({ showDefault: true }),
+                        UNDEFINED_AVATAR_TIMEOUT);
             } else {
                 this.setState({ showDefault: nextProps.forceDefault });
             }
@@ -115,8 +114,8 @@ export default class AvatarImage extends Component {
      * Computes a hash over the URI and returns a HSL background color. We use
      * 75% as lightness, for nice pastel style colors.
      *
-     * @returns {string} - The HSL CSS property.
      * @private
+     * @returns {string} - The HSL CSS property.
      */
     _getBackgroundColor() {
         const uri = this.props.source.uri;
@@ -157,9 +156,15 @@ export default class AvatarImage extends Component {
      * @inheritdoc
      */
     render() {
-        // eslint-disable-next-line no-unused-vars
-        const { forceDefault, source, style, ...props } = this.props;
         const { failed, showDefault } = this.state;
+        const {
+            // The following is/are forked in state:
+            forceDefault, // eslint-disable-line no-unused-vars
+
+            source,
+            style,
+            ...props
+        } = this.props;
 
         if (failed || showDefault) {
             const coloredBackground = {
@@ -168,19 +173,22 @@ export default class AvatarImage extends Component {
                 overflow: 'hidden'
             };
 
+            // We need to wrap the Image in a View because of a bug in React
+            // Native for Android:
+            // https://github.com/facebook/react-native/issues/3198
+            const workaround3198 = Platform.OS === 'android';
             let element = React.createElement(Image, {
                 ...props,
                 source: DEFAULT_AVATAR,
-                style: Platform.OS === 'android' ? style : coloredBackground
+                style: workaround3198 ? style : coloredBackground
             });
 
-            if (Platform.OS === 'android') {
-                // Here we need to wrap the Image in a View because of a bug in
-                // React Native for Android:
-                // https://github.com/facebook/react-native/issues/3198
-
-                element = React.createElement(View,
-                    { style: coloredBackground }, element);
+            if (workaround3198) {
+                element
+                    = React.createElement(
+                        View,
+                        { style: coloredBackground },
+                        element);
             }
 
             return element;

react/features/mobile/image-cache/middleware.js

@@ -7,21 +7,18 @@ import { CONFERENCE_FAILED, CONFERENCE_LEFT } from '../../base/conference';
 import { MiddlewareRegistry } from '../../base/redux';
 
 /**
- * Middleware that captures conference actions and application startup in order
- * cleans up the image cache.
+ * Middleware which captures app startup and conference actions in order to
+ * clear the image cache.
  *
- * @param {Store} store - Redux store.
  * @returns {Function}
  */
-// eslint-disable-next-line no-unused-vars
-MiddlewareRegistry.register(store => next => action => {
+MiddlewareRegistry.register(() => next => action => {
     switch (action.type) {
     case APP_WILL_MOUNT:
     case CONFERENCE_FAILED:
     case CONFERENCE_LEFT:
         ImageCache.get().clear();
         break;
-
     }
 
     return next(action);