ref(ui-components) Use new Button on prejoin (#12372)

This commit is contained in:
Robert Pintilii 2022-10-13 13:42:39 +03:00 committed by GitHub
parent f5fb402784
commit 51bbc3f87f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 55 additions and 46 deletions

View File

@ -204,3 +204,7 @@
} }
} }
} }
.lobby-button-margin {
margin-bottom: 16px;
}

View File

@ -190,7 +190,8 @@ export const commonStyles = (theme: Theme) => {
}, },
'.prejoin-dialog-btn': { '.prejoin-dialog-btn': {
width: '309px' width: '309px',
marginBottom: '8px'
}, },
'.prejoin-dialog-dialin-container': { '.prejoin-dialog-dialin-container': {

View File

@ -4,9 +4,10 @@ import React from 'react';
import { translate } from '../../../base/i18n'; import { translate } from '../../../base/i18n';
import { Icon, IconClose } from '../../../base/icons'; import { Icon, IconClose } from '../../../base/icons';
import { ActionButton, InputField, PreMeetingScreen } from '../../../base/premeeting'; import { InputField, PreMeetingScreen } from '../../../base/premeeting';
import { LoadingIndicator } from '../../../base/react'; import { LoadingIndicator } from '../../../base/react';
import { connect } from '../../../base/redux'; import { connect } from '../../../base/redux';
import Button from '../../../base/ui/components/web/Button';
import ChatInput from '../../../chat/components/web/ChatInput'; import ChatInput from '../../../chat/components/web/ChatInput';
import MessageContainer from '../../../chat/components/web/MessageContainer'; import MessageContainer from '../../../chat/components/web/MessageContainer';
import AbstractLobbyScreen, { import AbstractLobbyScreen, {
@ -222,22 +223,22 @@ class LobbyScreen extends AbstractLobbyScreen<Props> {
* @inheritdoc * @inheritdoc
*/ */
_renderPasswordJoinButtons() { _renderPasswordJoinButtons() {
const { t } = this.props;
return ( return (
<> <>
<ActionButton <Button
className = 'lobby-button-margin'
fullWidth = { true }
labelKey = 'prejoin.joinMeeting'
onClick = { this._onJoinWithPassword } onClick = { this._onJoinWithPassword }
testId = 'lobby.passwordJoinButton' testId = 'lobby.passwordJoinButton'
type = 'primary'> type = 'primary' />
{ t('prejoin.joinMeeting') } <Button
</ActionButton> className = 'lobby-button-margin'
<ActionButton fullWidth = { true }
labelKey = 'lobby.backToKnockModeButton'
onClick = { this._onSwitchToKnockMode } onClick = { this._onSwitchToKnockMode }
testId = 'lobby.backToKnockModeButton' testId = 'lobby.backToKnockModeButton'
type = 'secondary'> type = 'secondary' />
{ t('lobby.backToKnockModeButton') }
</ActionButton>
</> </>
); );
} }
@ -248,30 +249,35 @@ class LobbyScreen extends AbstractLobbyScreen<Props> {
* @inheritdoc * @inheritdoc
*/ */
_renderStandardButtons() { _renderStandardButtons() {
const { _knocking, _isLobbyChatActive, _renderPassword, t } = this.props; const { _knocking, _isLobbyChatActive, _renderPassword } = this.props;
return ( return (
<> <>
{ _knocking || <ActionButton {_knocking || <Button
className = 'lobby-button-margin'
disabled = { !this.state.displayName } disabled = { !this.state.displayName }
fullWidth = { true }
labelKey = 'lobby.knockButton'
onClick = { this._onAskToJoin } onClick = { this._onAskToJoin }
testId = 'lobby.knockButton' testId = 'lobby.knockButton'
type = 'primary'> type = 'primary' />
{ t('lobby.knockButton') } }
</ActionButton> } {(_knocking && _isLobbyChatActive) && <Button
{ (_knocking && _isLobbyChatActive) && <ActionButton className = 'lobby-button-margin open-chat-button'
className = 'open-chat-button' fullWidth = { true }
labelKey = 'toolbar.openChat'
onClick = { this._onToggleChat } onClick = { this._onToggleChat }
testId = 'toolbar.openChat' testId = 'toolbar.openChat'
type = 'primary' > type = 'primary' />
{ t('toolbar.openChat') } }
</ActionButton> } {_renderPassword && <Button
{_renderPassword && <ActionButton className = 'lobby-button-margin'
fullWidth = { true }
labelKey = 'lobby.enterPasswordButton'
onClick = { this._onSwitchToPasswordMode } onClick = { this._onSwitchToPasswordMode }
testId = 'lobby.enterPasswordButton' testId = 'lobby.enterPasswordButton'
type = 'secondary'> type = 'secondary' />
{ t('lobby.enterPasswordButton') } }
</ActionButton> }
</> </>
); );
} }

View File

@ -8,8 +8,7 @@ import { makeStyles } from 'tss-react/mui';
import { translate } from '../../../base/i18n/functions'; import { translate } from '../../../base/i18n/functions';
import Icon from '../../../base/icons/components/Icon'; import Icon from '../../../base/icons/components/Icon';
import { IconArrowLeft } from '../../../base/icons/svg'; import { IconArrowLeft } from '../../../base/icons/svg';
// @ts-ignore import { Button } from '../../../base/ui/components/web';
import { ActionButton } from '../../../base/premeeting';
// @ts-ignore // @ts-ignore
import { getCountryCodeFromPhone } from '../../utils'; import { getCountryCodeFromPhone } from '../../utils';
// @ts-ignore // @ts-ignore
@ -153,18 +152,18 @@ function DialinDialog(props: Props) {
{t('prejoin.connectedWithAudioQ')} {t('prejoin.connectedWithAudioQ')}
</Label> </Label>
<div className = 'prejoin-dialog-dialin-btns'> <div className = 'prejoin-dialog-dialin-btns'>
<ActionButton <Button
className = 'prejoin-dialog-btn' className = 'prejoin-dialog-btn'
fullWidth = { true }
labelKey = 'prejoin.joinMeeting'
onClick = { onPrimaryButtonClick } onClick = { onPrimaryButtonClick }
type = 'primary'> type = 'primary' />
{t('prejoin.joinMeeting')} <Button
</ActionButton>
<ActionButton
className = 'prejoin-dialog-btn' className = 'prejoin-dialog-btn'
fullWidth = { true }
labelKey = 'dialog.Cancel'
onClick = { onTextButtonClick } onClick = { onTextButtonClick }
type = 'text'> type = 'tertiary' />
{t('dialog.Cancel')}
</ActionButton>
</div> </div>
</div> </div>
); );

View File

@ -8,8 +8,7 @@ import { makeStyles } from 'tss-react/mui';
import { translate } from '../../../base/i18n/functions'; import { translate } from '../../../base/i18n/functions';
import Icon from '../../../base/icons/components/Icon'; import Icon from '../../../base/icons/components/Icon';
import { IconClose } from '../../../base/icons/svg'; import { IconClose } from '../../../base/icons/svg';
// @ts-ignore import { Button } from '../../../base/ui/components/web';
import { ActionButton } from '../../../base/premeeting';
// @ts-ignore // @ts-ignore
import Label from '../Label'; import Label from '../Label';
// @ts-ignore // @ts-ignore
@ -77,12 +76,12 @@ function DialOutDialog(props: Props) {
<div className = { classes.picker }> <div className = { classes.picker }>
<CountryPicker onSubmit = { onSubmit } /> <CountryPicker onSubmit = { onSubmit } />
</div> </div>
<ActionButton <Button
className = 'prejoin-dialog-btn' className = 'prejoin-dialog-btn'
fullWidth = { true }
labelKey = 'prejoin.callMe'
onClick = { onSubmit } onClick = { onSubmit }
type = 'primary'> type = 'primary' />
{t('prejoin.callMe')}
</ActionButton>
<div className = 'prejoin-dialog-delimiter-container'> <div className = 'prejoin-dialog-delimiter-container'>
<div className = 'prejoin-dialog-delimiter' /> <div className = 'prejoin-dialog-delimiter' />
<div className = 'prejoin-dialog-delimiter-txt-container'> <div className = 'prejoin-dialog-delimiter-txt-container'>
@ -92,12 +91,12 @@ function DialOutDialog(props: Props) {
</div> </div>
</div> </div>
<div className = 'prejoin-dialog-dialin-container'> <div className = 'prejoin-dialog-dialin-container'>
<ActionButton <Button
className = 'prejoin-dialog-btn' className = 'prejoin-dialog-btn'
fullWidth = { true }
labelKey = 'prejoin.iWantToDialIn'
onClick = { onTextButtonClick } onClick = { onTextButtonClick }
type = 'text'> type = 'tertiary' />
{t('prejoin.iWantToDialIn')}
</ActionButton>
</div> </div>
</div> </div>
); );