haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #927 from jitsi/fix-feedback-resolve 

Makes sure we always resolve(call the callback) in feedback dialog.
This commit is contained in:
yanas 2016-09-22 17:47:17 -05:00 committed by GitHub
parent 06247266ad eb2e709749
commit 5ef241ae66
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
modules/UI/feedback/FeedbackWindow.js
View File

@ -176,6 +176,13 @@ export default class Dialog {
}); });
this.$el = this.window.$el; this.$el = this.window.$el;
AJS.dialog2(selector).on("hide", function() {
if (this.onCloseCallback) {
this.onCloseCallback();
this.onCloseCallback = null;
}
}.bind(this));
this.setState(); this.setState();
} }
@ -201,11 +208,6 @@ export default class Dialog {
hide() { hide() {
this.window.hide(); this.window.hide();
if (this.onCloseCallback) {
this.onCloseCallback();
this.onCloseCallback = null;
}
} }
onFeedbackSubmitted() { onFeedbackSubmitted() {