haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(LocalVideo): prevent from leaking video elements 

It appears that the TrackEvents.LOCAL_TRACK_STOPPED is not triggered
when switching between camera and screen. This is a temporary workaround
to prevent excessive amount of warnings (added in the previous commit)
about multiple video elements.
This commit is contained in:
paweldomas 2016-11-16 13:05:14 -06:00
parent ad328796cb
commit 703f4f493b
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/UI/videolayout/LocalVideo.js
View File

@ -154,6 +154,19 @@ LocalVideo.prototype.createConnectionIndicator = function() {
};
LocalVideo.prototype.changeVideo = function (stream) {
// FIXME temporary workaround for the fact that 'endedHandler' is not called
// This is to avoid potential side effect of the fact that multiple video
// elements are leaked into the 'localVideoWrapper' after screen sharing
if (this.videoStream) {
var localVideoElement = document.getElementById(this.localVideoId);
if (localVideoElement) {
this.videoStream.detach(localVideoElement);
var container = localVideoElement.parentNode;
if (container) {
container.removeChild(localVideoElement);
}
}
}
this.videoStream = stream;
let localVideoClick = (event) => {
@ -192,6 +205,9 @@ LocalVideo.prototype.changeVideo = function (stream) {
// Attach WebRTC stream
localVideo = stream.attach(localVideo);
// FIXME this is never called for some reason
// It was expected for this callback to be called whenever local video
// stream is switched between camera and screen videos.
let endedHandler = () => {
localVideoContainer.removeChild(localVideo);
// when removing only the video element and we are on stage