haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(multi-stream) Do not show join notifications for SS tiles.

This commit is contained in:
Jaya Allamsetty 2022-04-18 12:34:07 -04:00
parent 221ecac12d
commit 7420113079
2 changed files with 22 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
react/features/base/participants/middleware.js
View File

@ -210,14 +210,22 @@ MiddlewareRegistry.register(store => next => action => {
}
case PARTICIPANT_JOINED: {
_maybePlaySounds(store, action);
const { isFakeScreenShareParticipant } = action.participant;
// Do not play sounds when a fake participant tile is created for screenshare.
!isFakeScreenShareParticipant && _maybePlaySounds(store, action);
return _participantJoinedOrUpdated(store, next, action);
}
case PARTICIPANT_LEFT:
_maybePlaySounds(store, action);
case PARTICIPANT_LEFT: {
const { isFakeScreenShareParticipant } = action.participant;
// Do not play sounds when a tile for screenshare is removed.
!isFakeScreenShareParticipant && _maybePlaySounds(store, action);
break;
}
case PARTICIPANT_UPDATED:
return _participantJoinedOrUpdated(store, next, action);

13
react/features/notifications/middleware.js
View File

@ -128,7 +128,12 @@ MiddlewareRegistry.register(store => next => action => {
const { participant: p } = action;
const { conference } = state['features/base/conference'];
if (conference && !p.local && !joinLeaveNotificationsDisabled() && !p.isReplacing) {
// Do not display notifications for the fake screenshare tiles.
if (conference
&& !p.local
&& !p.isFakeScreenShareParticipant
&& !joinLeaveNotificationsDisabled()
&& !p.isReplacing) {
dispatch(showParticipantJoinedNotification(
getParticipantDisplayName(state, p.id)
));
@ -143,7 +148,11 @@ MiddlewareRegistry.register(store => next => action => {
action.participant.id
);
if (participant && !participant.local && !action.participant.isReplaced) {
// Do not display notifications for the fake screenshare tiles.
if (participant
&& !participant.local
&& !participant.isFakeScreenShareParticipant
&& !action.participant.isReplaced) {
dispatch(showParticipantLeftNotification(
getParticipantDisplayName(state, participant.id)
));