haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes sending logs to callstats. 

When _setLoggingConfig is invoked for the first time old and new config
are equal and _initLogging is not called. Currently, there is no way to
detect when the first time we call it is. We could use APP.logCollector
but it should go away at some point in the future.
This commit is contained in:
damencho 2017-10-11 13:14:37 -05:00 committed by Lyubo Marinov
parent 9452f06b27
commit 90451a640c
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
react/features/base/logging/middleware.js
View File

@ -119,16 +119,19 @@ function _libWillInit({ getState }, next, action) {
* specified {@code action}.
*/
function _setLoggingConfig({ getState }, next, action) {
const oldValue = getState()['features/base/logging'].config;
const result = next(action);
const newValue = getState()['features/base/logging'].config;
if (oldValue !== newValue) {
_setLogLevels(Logger, newValue);
_setLogLevels(JitsiMeetJS, newValue);
// TODO Generally, we'll want to _setLogLevels and _initLogging only if the
// logging config values actually change.
// XXX Unfortunately, we don't currently have a (nice) way of determining
// whether _setLogLevels or _initLogging have been invoked so we have to
// invoke them unconditionally even if none of the values have actually
// changed.
_setLogLevels(Logger, newValue);
_setLogLevels(JitsiMeetJS, newValue);
_initLogging(newValue);
}
_initLogging(newValue);
return result;
}