fix(context-menu) Add max height (#10965)

This commit is contained in:
Robert Pintilii 2022-02-15 13:23:40 +02:00 committed by GitHub
parent 387af2db20
commit 9062c91d77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions

View File

@ -67,6 +67,8 @@ type Props = {
onMouseLeave?: Function onMouseLeave?: Function
}; };
const MAX_HEIGHT = 400;
const useStyles = makeStyles(theme => { const useStyles = makeStyles(theme => {
return { return {
contextMenu: { contextMenu: {
@ -80,7 +82,9 @@ const useStyles = makeStyles(theme => {
position: 'absolute', position: 'absolute',
right: `${participantsPaneTheme.panePadding}px`, right: `${participantsPaneTheme.panePadding}px`,
top: 0, top: 0,
zIndex: 2 zIndex: 2,
maxHeight: `${MAX_HEIGHT}px`,
overflowY: 'auto'
}, },
contextMenuHidden: { contextMenuHidden: {
@ -136,8 +140,9 @@ const ContextMenu = ({
const { current: container } = containerRef; const { current: container } = containerRef;
const { offsetTop, offsetParent: { offsetHeight, scrollTop } } = offsetTarget; const { offsetTop, offsetParent: { offsetHeight, scrollTop } } = offsetTarget;
const outerHeight = getComputedOuterHeight(container); const outerHeight = getComputedOuterHeight(container);
const height = Math.min(MAX_HEIGHT, outerHeight);
container.style.top = offsetTop + outerHeight > offsetHeight + scrollTop container.style.top = offsetTop + height > offsetHeight + scrollTop
? `${offsetTop - outerHeight}` ? `${offsetTop - outerHeight}`
: `${offsetTop}`; : `${offsetTop}`;