haskal
/
jiti-meet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

code review

This commit is contained in:
Tudor-Ovidiu Avram 2022-03-25 10:44:58 +02:00
parent a2186e8cee
commit bb27c5ef12
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
react/features/recording/components/Recording/AbstractHighlightButton.js
View File

@ -108,7 +108,7 @@ export function _abstractMapStateToProps(state: Object) {
const { webhookProxyUrl } = state['features/base/config'];
const {
_disabled: isRecordButtonDisabled,
disabled: isRecordButtonDisabled,
visible: isRecordButtonVisible
} = getRecordButtonProps(state);

4
react/features/recording/components/Recording/AbstractRecordButton.js
View File

@ -135,8 +135,8 @@ export default class AbstractRecordButton<P: Props> extends AbstractButton<P, *>
*/
export function _mapStateToProps(state: Object): Object {
const {
_disabled,
_tooltip,
disabled: _disabled,
tooltip: _tooltip,
visible
} = getRecordButtonProps(state);

22
react/features/recording/functions.js
View File

@ -136,8 +136,8 @@ export function getRecordButtonProps(state: Object): ?string {
// a button can be disabled/enabled if enableFeaturesBasedOnToken
// is on or if the livestreaming is running.
let _disabled;
let _tooltip = '';
let disabled;
let tooltip = '';
// If the containing component provides the visible prop, that is one
// above all, but if not, the button should be autonomus and decide on
@ -153,29 +153,29 @@ export function getRecordButtonProps(state: Object): ?string {
if (enableFeaturesBasedOnToken) {
visible = visible && String(features.recording) === 'true';
_disabled = String(features.recording) === 'disabled';
if (!visible && !_disabled) {
_disabled = true;
disabled = String(features.recording) === 'disabled';
if (!visible && !disabled) {
disabled = true;
visible = true;
_tooltip = 'dialog.recordingDisabledTooltip';
tooltip = 'dialog.recordingDisabledTooltip';
}
}
// disable the button if the livestreaming is running.
if (getActiveSession(state, JitsiRecordingConstants.mode.STREAM)) {
_disabled = true;
_tooltip = 'dialog.recordingDisabledBecauseOfActiveLiveStreamingTooltip';
disabled = true;
tooltip = 'dialog.recordingDisabledBecauseOfActiveLiveStreamingTooltip';
}
// disable the button if we are in a breakout room.
if (isInBreakoutRoom(state)) {
_disabled = true;
disabled = true;
visible = false;
}
return {
_disabled,
_tooltip,
disabled,
tooltip,
visible
};
}